Skip to content

Stabilize substr_range and related methods#141266

Open
wr7 wants to merge 1 commit intorust-lang:mainfrom
wr7:stabilize_substr_range
Open

Stabilize substr_range and related methods#141266
wr7 wants to merge 1 commit intorust-lang:mainfrom
wr7:stabilize_substr_range

Conversation

@wr7
Copy link
Contributor

@wr7 wr7 commented May 20, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented May 20, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2025
@wr7 wr7 mentioned this pull request May 19, 2025
Open
7 tasks
@jieyouxu
Copy link
Member

jieyouxu commented May 20, 2025

r? libs-api (needs fcp)

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 20, 2025
@rustbot rustbot assigned BurntSushi and unassigned tgross35 May 20, 2025
@jieyouxu jieyouxu added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2025
@tgross35
Copy link
Contributor

tgross35 commented Sep 5, 2025

Nominating to discuss possible stabilization. Please see the report at #126769 (comment), and some followup discussion there about API and naming.

@rustbot label +I-libs-api-nominated
r? libs

@rustbot rustbot added I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 5, 2025
@rustbot rustbot assigned ibraheemdev and unassigned BurntSushi Sep 5, 2025
@Amanieu Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 16, 2025
@ibraheemdev ibraheemdev removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2025
@ibraheemdev
Copy link
Member

ibraheemdev commented Oct 14, 2025

r? libs-api

@rustbot rustbot assigned the8472 and unassigned ibraheemdev Oct 14, 2025
@ibraheemdev ibraheemdev added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2025
@wr7 wr7 force-pushed the stabilize_substr_range branch from ecd3bb0 to 2c58efe Compare October 29, 2025 14:53
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@wr7
Copy link
Contributor Author

wr7 commented Nov 3, 2025 •
edited
Loading

@the8472 The FCP has ended. This should be ready to merge AFAIK

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2025

Error: Label finished-final-comment-period can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@tgross35
Copy link
Contributor

tgross35 commented Dec 2, 2025

Last minute concern about the range types used #126769 (comment).

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☔ The latest upstream changes (presumably #150798) made this pull request unmergeable. Please resolve the merge conflicts.

@wr7 wr7 force-pushed the stabilize_substr_range branch from 2c58efe to 0ab4250 Compare January 8, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@the8472 the8472

Labels

needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking Issue for substr_range and related methods

8 participants

@wr7 @rustbot @jieyouxu @tgross35 @ibraheemdev @Amanieu @BurntSushi @the8472