Skip to content

Avoid creating an empty identifer in Symbol::to_ident_string.#141318

Merged
bors merged 1 commit intorust-lang:masterfrom
nnethercote:fix-140884
May 21, 2025
Merged

Avoid creating an empty identifer in Symbol::to_ident_string.#141318
bors merged 1 commit intorust-lang:masterfrom
nnethercote:fix-140884

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented May 21, 2025

Because that causes an assertion failure in debug builds.

Fixes #140884.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after removing crash

@compiler-errors
Copy link
Contributor

compiler-errors commented May 21, 2025

r? compiler-errors @rustbot author

@rustbot rustbot assigned compiler-errors and unassigned oli-obk May 21, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 21, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 21, 2025
@nnethercote
Avoid creating an empty identifer in Symbol::to_ident_string.
1cc0e38 
Because that causes an assertion failure in debug builds.

Fixes rust-lang#140884.
@rustbot
Copy link
Collaborator

rustbot commented May 21, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@nnethercote
Copy link
Contributor Author

nnethercote commented May 21, 2025

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented May 21, 2025

📌 Commit 1cc0e38 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 21, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request May 21, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
@bors
Auto merge of rust-lang#141331 - matthiaskrgr:rollup-k0loxj6, r=matth…
c43786c 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#137759 (Add `std::os::unix::process::CommandExt::chroot` to safely chroot a child process)
 - rust-lang#140994 (replace `cc_detect::cc2ar` with `cc::try_get_archiver`)
 - rust-lang#141213 (Suggest use "{}", self.x instead of {self.x} when resolve x as field of `self`)
 - rust-lang#141283 (Allow `x perf` to find rustc.exe on Windows)
 - rust-lang#141284 (Allow trailing comma after argument in query definition)
 - rust-lang#141317 (typeck: catch `continue`s pointing to blocks)
 - rust-lang#141318 (Avoid creating an empty identifer in `Symbol::to_ident_string`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b150e3 into rust-lang:master May 21, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
@rust-timer
Unrolled build for rust-lang#141318
8cec56e 
Rollup merge of rust-lang#141318 - nnethercote:fix-140884, r=compiler-errors

Avoid creating an empty identifer in `Symbol::to_ident_string`.

Because that causes an assertion failure in debug builds.

Fixes rust-lang#140884.

r? `@oli-obk`
@rustbot rustbot added this to the 1.89.0 milestone May 21, 2025
@nnethercote nnethercote deleted the fix-140884 branch May 21, 2025 23:01
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 12, 2025
Closed
@apiraino
Copy link
Contributor

apiraino commented Jun 16, 2025

IIUC this also fixes #142425

@cuviper cuviper mentioned this pull request Jun 16, 2025
Merged
@cuviper
Copy link
Member

cuviper commented Jun 16, 2025

I'm proposing this backport as a proper fix for #142425, but it was recommended to also backport #140880.

@rustbot label beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 16, 2025
@apiraino
Copy link
Contributor

apiraino commented Jun 19, 2025

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 19, 2025
@cuviper cuviper mentioned this pull request Jun 20, 2025
Merged
@cuviper cuviper modified the milestones: 1.89.0, 1.88.0 Jun 20, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 20, 2025
bors added a commit that referenced this pull request Jun 20, 2025
@bors
Auto merge of #142791 - cuviper:beta-next, r=cuviper
f1453a8 
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730

r? cuviper
rust-bors bot added a commit that referenced this pull request Jun 20, 2025
@rust-bors
Auto merge of #142791 - cuviper:beta-next, r=<try>
1a5e6ea 
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730

r? cuviper

try-job: x86_64-msvc-ext2
bors added a commit that referenced this pull request Jun 21, 2025
@bors
Auto merge of #142791 - cuviper:beta-next, r=cuviper
32084cf 
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730
-  [win][ci] Update LLVM toolchain used to build LLVM to 20 #140757

r? cuviper
@cushionbadak cushionbadak mentioned this pull request Jul 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

ICE: symbol: assertion left != right failed

8 participants

@nnethercote @rust-log-analyzer @compiler-errors @rustbot @bors @apiraino @cuviper @oli-obk