GetUserProfileDirectoryW is now documented to always store the size by RalfJung · Pull Request #141405 · rust-lang/rust

RalfJung · 2025-05-22T18:11:07Z

Update to match MicrosoftDocs/sdk-api#1810

Also fix a bug in the Miri implementation while I am starting at that code...

r? @ChrisDenton
Fixes #141254

rustbot · 2025-05-22T18:11:13Z

The Miri subtree was changed

cc @rust-lang/miri

RalfJung · 2025-05-22T18:11:44Z

src/tools/miri/src/shims/windows/env.rs

            Some(dirs) => {
                let home = dirs.home_dir();
-                let size_avail = if this.ptr_is_null(size.ptr())? {
+                let size_avail = if this.ptr_is_null(buf)? {


The comment already talked about checking buf, not size... and we unconditionally write size so it being null already triggered UB before.

Makes sense to me - docs agree that lpcchSize is required:
https://learn.microsoft.com/en-us/windows/win32/api/userenv/nf-userenv-getuserprofiledirectoryw

As does SAL
https://github.com/microsoft/win32metadata/blob/c7ffce1c97bb724580580f3856b94c6d4ad677ed/generation/WinSDK/RecompiledIdlHeaders/um/UserEnv.h#L375

_In_ HANDLE hToken, _Out_writes_opt_(*lpcchSize) LPWSTR lpProfileDir, _Inout_ LPDWORD lpcchSize

(There's no Opt suffix to denote that nullptr is an allowed value for lpcchSize)

Great work as always :)

ChrisDenton · 2025-05-22T18:41:57Z

Great, thanks!

@bors r+ rollup

bors · 2025-05-22T18:42:00Z

📌 Commit 9818410 has been approved by ChrisDenton

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - #138896 (std: fix aliasing bug in UNIX process implementation) - #140832 (aarch64-linux: Default to FramePointer::NonLeaf) - #141065 (Updated std doctests for wasm) - #141369 (Simplify `format_integer_with_underscore_sep`) - #141374 (make shared_helpers exe function work for both cygwin and non-cygwin hosts) - #141398 (chore: fix typos in comment) - #141457 (Update mdbook to 0.4.50) Failed merges: - #141405 (GetUserProfileDirectoryW is now documented to always store the size) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-05-23T19:19:33Z

☔ The latest upstream changes (presumably #141437) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2025-05-23T20:37:49Z

@bors r=ChrisDenton

bors · 2025-05-23T20:37:52Z

📌 Commit 587653a has been approved by ChrisDenton

It is now in the queue for this repository.

… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? `@ChrisDenton` Fixes rust-lang#141254

Rollup of 8 pull requests Successful merges: - #140790 (Enable xray support for Mac) - #141405 (GetUserProfileDirectoryW is now documented to always store the size) - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING) - #141427 (Disable `triagebot`'s `glacier` handler) - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - #141438 (Do not try to confirm non-dyn compatible method) - #141444 (Improve CONTRIBUTING.md grammar and clarity) - #141446 (Add 2nd Solaris target maintainer) r? `@ghost` `@rustbot` modify labels: rollup

… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ``@ChrisDenton`` Fixes rust-lang#141254

Rollup of 7 pull requests Successful merges: - #141405 (GetUserProfileDirectoryW is now documented to always store the size) - #141427 (Disable `triagebot`'s `glacier` handler) - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - #141438 (Do not try to confirm non-dyn compatible method) - #141444 (Improve CONTRIBUTING.md grammar and clarity) - #141446 (Add 2nd Solaris target maintainer) - #141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141405 - RalfJung:GetUserProfileDirectoryW, r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ```@ChrisDenton``` Fixes #141254

… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ```@ChrisDenton``` Fixes rust-lang#141254

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#141405 (GetUserProfileDirectoryW is now documented to always store the size) - rust-lang#141427 (Disable `triagebot`'s `glacier` handler) - rust-lang#141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - rust-lang#141438 (Do not try to confirm non-dyn compatible method) - rust-lang#141444 (Improve CONTRIBUTING.md grammar and clarity) - rust-lang#141446 (Add 2nd Solaris target maintainer) - rust-lang#141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned ChrisDenton May 22, 2025

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 22, 2025

RalfJung commented May 22, 2025

View reviewed changes

RalfJung mentioned this pull request May 22, 2025

make GetUserProfileDirectoryW more strictly match documented behavior rust-lang/miri#4332

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2025

matthiaskrgr mentioned this pull request May 23, 2025

Rollup of 7 pull requests #141463

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 23, 2025

GetUserProfileDirectoryW is now documented to always store the size

587653a

RalfJung force-pushed the GetUserProfileDirectoryW branch from 9818410 to 587653a Compare May 23, 2025 20:36

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 23, 2025

matthiaskrgr mentioned this pull request May 23, 2025

Rollup of 8 pull requests #141473

Closed

This was referenced May 24, 2025

Rollup of 8 pull requests #141482

Closed

Rollup of 7 pull requests #141484

Merged

bors merged commit 48c4a46 into rust-lang:master May 24, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 24, 2025

RalfJung deleted the GetUserProfileDirectoryW branch May 24, 2025 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GetUserProfileDirectoryW is now documented to always store the size#141405

GetUserProfileDirectoryW is now documented to always store the size#141405
bors merged 1 commit intorust-lang:masterfrom
RalfJung:GetUserProfileDirectoryW

RalfJung commented May 22, 2025 •

edited

Loading

Uh oh!

rustbot commented May 22, 2025

Uh oh!

RalfJung May 22, 2025

Uh oh!

cgettys-microsoft May 22, 2025 •

edited

Loading

Uh oh!

ChrisDenton commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

RalfJung commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

RalfJung commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 22, 2025

Uh oh!

RalfJung May 22, 2025

Choose a reason for hiding this comment

Uh oh!

cgettys-microsoft May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChrisDenton commented May 22, 2025

Uh oh!

bors commented May 22, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

RalfJung commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RalfJung commented May 22, 2025 •

edited

Loading

cgettys-microsoft May 22, 2025 •

edited

Loading