Rename {GenericArg,Term}::unpack() to kind()#141495
Merged
bors merged 2 commits intorust-lang:masterfrom May 27, 2025
Merged
Conversation
rustbot
added
PG-exploit-mitigations
Collaborator
|
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred to constck cc @fee1-dead changes to the core type system Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to the CTFE machinery The Miri subtree was changed cc @rust-lang/miri changes to the core type system Some changes occurred in need_type_info.rs cc @lcnr Some changes occurred in match checking cc @Nadrieril Some changes occurred in compiler/rustc_sanitizers cc @rcvalle HIR ty lowering was modified cc @fmease changes to the core type system |
fmease
approved these changes
May 24, 2025
fmease
reviewed
May 24, 2025
fmease
reviewed
May 24, 2025
Member
fmease
left a comment
fmease
left a comment
There was a problem hiding this comment.
r=me with some of the preexisting bad names addressed (but it's a can of worms, so you don't need to fix everything if it's too much)
compiler/rustc_hir_typeck/src/fn_ctxt/adjust_fulfillment_errors.rs
Outdated
Show resolved
Hide resolved
Member
|
Should the corresponding method |
Contributor
Author
shrug. I personally don't think it should be renamed -- it's so rarely called compared to |
Member
|
For |
fmease
added
S-waiting-on-author
compiler-errors
force-pushed
the
rename-unpack
branch
from
1ae96b4 to
b3c0bde
Compare
compiler-errors
added
S-waiting-on-review
Contributor
Author
|
@bors r=fmease |
Collaborator
bors
added
S-waiting-on-bors
Member
|
gamer |
Collaborator
|
☔ The latest upstream changes (presumably #141605) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
rename-unpack
branch
from
b3c0bde to
5f3ae06
Compare
Contributor
|
@bors p=5 |
Member
|
Oops forgot to reapprove @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
|
@bors rollup |
bors
added a commit
that referenced
this pull request
May 27, 2025
Rollup of 8 pull requests Successful merges: - #141312 (Add From<TryLockError> for io::Error) - #141495 (Rename `{GenericArg,Term}::unpack()` to `kind()`) - #141602 (triagebot: label LLVM submodule changes with `A-LLVM`) - #141632 (remove `visit_mt` from `ast::mut_visit`) - #141640 (test: convert version_check ui test to run-make) - #141645 (bump fluent-* crates) - #141650 (coverage: Revert "unused local file IDs" due to empty function names) - #141654 (tests: mark option-niche-eq as fixed on LLVM 21) Failed merges: - #141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`) - #141636 (avoid some usages of `&mut P<T>` in AST visitors) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
rust-timer
added a commit
that referenced
this pull request
May 27, 2025
Rollup merge of #141495 - compiler-errors:rename-unpack, r=fmease Rename `{GenericArg,Term}::unpack()` to `kind()` A well-deserved rename IMO. r? `@oli-obk` or `@lcnr` (or anyone) cc `@rust-lang/types,` but I'd be surprised if this is controversial.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 28, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#141312 (Add From<TryLockError> for io::Error) - rust-lang/rust#141495 (Rename `{GenericArg,Term}::unpack()` to `kind()`) - rust-lang/rust#141602 (triagebot: label LLVM submodule changes with `A-LLVM`) - rust-lang/rust#141632 (remove `visit_mt` from `ast::mut_visit`) - rust-lang/rust#141640 (test: convert version_check ui test to run-make) - rust-lang/rust#141645 (bump fluent-* crates) - rust-lang/rust#141650 (coverage: Revert "unused local file IDs" due to empty function names) - rust-lang/rust#141654 (tests: mark option-niche-eq as fixed on LLVM 21) Failed merges: - rust-lang/rust#141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`) - rust-lang/rust#141636 (avoid some usages of `&mut P<T>` in AST visitors) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A well-deserved rename IMO.
r? @oli-obk or @lcnr (or anyone)
cc @rust-lang/types, but I'd be surprised if this is controversial.