Do not run PGO/BOLT in x64 Linux alt builds by Kobzol · Pull Request #141777 · rust-lang/rust

Kobzol · 2025-05-30T16:29:12Z

Should unblock #131077 and also reduce our CI costs. It seems to run ~1.5h on the x64 larger runner (free runner runs out of disk space, sadly).

Discussed here.

r? @marcoieni

try-job: dist-x86_64-linux*

Kobzol · 2025-05-30T16:29:51Z

@bors2 try

rust-bors · 2025-05-30T16:29:55Z

⌛ Trying commit e28d0c7 with merge 31b9ec6…

Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. I'll see if I can actually move this job to the free runner, or at least to CodeBuild, if this works. Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

rust-bors · 2025-05-30T16:33:57Z

💔 Test failed

CI ❌

Kobzol · 2025-05-30T16:34:28Z

@bors2 try

rust-bors · 2025-05-30T16:34:32Z

⌛ Trying commit 318d1e9 with merge 6df9b4f…

Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. I'll see if I can actually move this job to the free runner, or at least to CodeBuild, if this works. Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

rust-bors · 2025-05-30T17:34:44Z

💔 Test failed

CI ❌

Kobzol · 2025-05-30T17:38:37Z

@bors2 try

rust-bors · 2025-05-30T17:38:41Z

⌛ Trying commit 65bb0d4 with merge 841e227…

Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. I'll see if I can actually move this job to the free runner, or at least to CodeBuild, if this works. Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

rust-bors · 2025-05-30T18:08:52Z

💔 Test failed

CI ❌

Signed-off-by: Jakub Beránek <berykubik@gmail.com>

Kobzol · 2025-05-30T18:36:50Z

@bors2 try

Fucking submodules.

rust-bors · 2025-05-30T18:36:54Z

⌛ Trying commit 033ea63 with merge dce110a…

Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. I'll see if I can actually move this job to the free runner, or at least to CodeBuild, if this works. Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

Kobzol · 2025-05-30T20:13:34Z

@bors2 try cancel

rust-bors · 2025-05-30T20:13:36Z

Try build cancelled.
Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/15353389945

Kobzol · 2025-05-30T20:15:37Z

Nice, the alt job took only ~1.5h 🎉 Now let's see how long it takes on a free runner.

@bors2 try

rust-bors · 2025-05-30T20:15:42Z

⌛ Trying commit 6e64f8f with merge 713ede4…

Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. I'll see if I can actually move this job to the free runner, or at least to CodeBuild, if this works. Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

mati865 · 2025-05-30T22:02:33Z

IIRC results from this build are used for test jobs. So, they will likely slow down a bit but probably not by much.

rust-bors · 2025-05-30T23:00:11Z

💔 Test failed

CI ❌

Kobzol · 2025-05-31T08:03:54Z

Ok, looks like free runner is a no-go because of disk space, I guess that makes sense.

IIRC results from this build are used for test jobs. So, they will likely slow down a bit but probably not by much.

Thanks, I'll have to check that out.

rust-bors · 2025-06-02T10:04:05Z

⌛ Trying commit eaaa846 with merge 336a518…

rust-bors · 2025-06-02T13:04:26Z

☀️ Try build successful (CI)
Build commit: 336a518 (336a51809f5af5b476831469f189e6457aa71ef3)

Kobzol · 2025-06-02T13:14:05Z

~1h 45m on Codebuild, ideal.

src/ci/github-actions/jobs.yml

Kobzol · 2025-06-03T08:23:44Z

@bors2 try

rust-bors · 2025-06-03T08:23:49Z

⌛ Trying commit 8f22a50 with merge 6a184ec…

Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. It seems to run ~1.5h on the x64 larger runner (free runner runs out of disk space, sadly). Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

marcoieni · 2025-06-03T08:26:18Z

this is great, thanks ❤️
Feel free to r=me if the timing is good

rust-bors · 2025-06-03T11:29:10Z

☀️ Try build successful (CI)
Build commit: 6a184ec (6a184ec3874dd1909ca928da012736b935aedb3e)

Kobzol · 2025-06-03T13:01:10Z

2h 45m. A bit borderline, but we can always switch to the 8-core runner if it becomes too much. And at least it shouldn't be the bottleneck anymore.

@bors r=marcoieni

bors · 2025-06-03T13:01:13Z

📌 Commit 8f22a50 has been approved by marcoieni

It is now in the queue for this repository.

… r=marcoieni Do not run PGO/BOLT in x64 Linux alt builds Should unblock rust-lang#131077 and also reduce our CI costs. It seems to run ~1.5h on the x64 larger runner (free runner runs out of disk space, sadly). Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? `@marcoieni` try-job: `dist-x86_64-linux*`

Rollup of 8 pull requests Successful merges: - #140638 (UnsafePinned: also include the effects of UnsafeCell) - #141272 (modularize the config module bootstrap) - #141777 (Do not run PGO/BOLT in x64 Linux alt builds) - #141870 (Fix broken link to rustc_type_ir module in serialization docs) - #141938 (update rust offload bootstrap) - #141962 (rustc-dev-guide subtree update) - #141965 (`tests/ui`: A New Order [3/N]) - #141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 6 pull requests Successful merges: - #140638 (UnsafePinned: also include the effects of UnsafeCell) - #141777 (Do not run PGO/BOLT in x64 Linux alt builds) - #141938 (update rust offload bootstrap) - #141962 (rustc-dev-guide subtree update) - #141965 (`tests/ui`: A New Order [3/N]) - #141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141777 - Kobzol:dist-linux-alt-no-pgo-bolt, r=marcoieni Do not run PGO/BOLT in x64 Linux alt builds Should unblock #131077 and also reduce our CI costs. It seems to run ~1.5h on the x64 larger runner (free runner runs out of disk space, sadly). Discussed [here](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Utility.20of.20the.20.60dist-x86_64-linux-alt.60.20job/with/521324477). r? ``@marcoieni`` try-job: `dist-x86_64-linux*`

Rollup of 6 pull requests Successful merges: - rust-lang/rust#140638 (UnsafePinned: also include the effects of UnsafeCell) - rust-lang/rust#141777 (Do not run PGO/BOLT in x64 Linux alt builds) - rust-lang/rust#141938 (update rust offload bootstrap) - rust-lang/rust#141962 (rustc-dev-guide subtree update) - rust-lang/rust#141965 (`tests/ui`: A New Order [3/N]) - rust-lang/rust#141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#140638 (UnsafePinned: also include the effects of UnsafeCell) - rust-lang#141777 (Do not run PGO/BOLT in x64 Linux alt builds) - rust-lang#141938 (update rust offload bootstrap) - rust-lang#141962 (rustc-dev-guide subtree update) - rust-lang#141965 (`tests/ui`: A New Order [3/N]) - rust-lang#141970 (implement new `x` flag: `--skip-std-check-if-no-download-rustc`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned marcoieni May 30, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 30, 2025

Kobzol force-pushed the dist-linux-alt-no-pgo-bolt branch from e28d0c7 to 318d1e9 Compare May 30, 2025 16:34

Kobzol force-pushed the dist-linux-alt-no-pgo-bolt branch from 318d1e9 to 65bb0d4 Compare May 30, 2025 17:38

Do not run PGO/BOLT in x64 Linux alt builds

033ea63

Signed-off-by: Jakub Beránek <berykubik@gmail.com>

Kobzol force-pushed the dist-linux-alt-no-pgo-bolt branch from 65bb0d4 to 033ea63 Compare May 30, 2025 18:36

Kobzol marked this pull request as ready for review June 2, 2025 13:14

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2025

marcoieni reviewed Jun 3, 2025

View reviewed changes

src/ci/github-actions/jobs.yml Outdated Show resolved Hide resolved

marcoieni reviewed Jun 3, 2025

View reviewed changes

src/ci/github-actions/jobs.yml Outdated Show resolved Hide resolved

Use 4-core large disk runner for the alt job

8f22a50

Kobzol force-pushed the dist-linux-alt-no-pgo-bolt branch from eaaa846 to 8f22a50 Compare June 3, 2025 08:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025

matthiaskrgr mentioned this pull request Jun 5, 2025

Rollup of 8 pull requests #142059

Closed

matthiaskrgr mentioned this pull request Jun 5, 2025

Rollup of 6 pull requests #142070

Merged

bors merged commit 2c5a5fe into rust-lang:master Jun 5, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 5, 2025

Kobzol deleted the dist-linux-alt-no-pgo-bolt branch June 5, 2025 17:15

Uh oh!

Conversation

Kobzol commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

Kobzol commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

Kobzol commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

Kobzol commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

Kobzol commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

Kobzol commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

mati865 commented May 30, 2025

Uh oh!

rust-bors bot commented May 30, 2025

Uh oh!

Kobzol commented May 31, 2025

Uh oh!

rust-bors bot commented Jun 2, 2025

Uh oh!

rust-bors bot commented Jun 2, 2025

Uh oh!

Kobzol commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Jun 3, 2025

Uh oh!

rust-bors bot commented Jun 3, 2025

Uh oh!

marcoieni commented Jun 3, 2025

Uh oh!

rust-bors bot commented Jun 3, 2025

Uh oh!

Kobzol commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kobzol commented May 30, 2025 •

edited

Loading