coretests: move float tests from num to floats module and use a more flexible macro to generate them by RalfJung · Pull Request #141857 · rust-lang/rust

RalfJung · 2025-06-01T14:14:45Z

This makes some progress on #141726 by moving the float tests in num to floats and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough.

I didn't yet deduplicate any tests or port the existing floats::f* tests to the macro, that can happen in a future PR.

try-job: x86_64-gnu-aux

rustbot · 2025-06-01T14:14:49Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

RalfJung · 2025-06-01T14:16:31Z

r? @tgross35

tgross35

Thanks for putting this together, I really like the way it turned out. Just a nit suggesting an example in the docs and optionally removing cfg(bootstrap). r=me after that and green CI (assuming the failure is unrelated)

library/coretests/tests/floats/mod.rs

RalfJung · 2025-06-03T07:20:00Z

That test is kind of silly inside coretests...

library/coretests/tests/floats/mod.rs

RalfJung · 2025-06-03T08:36:38Z

@bors r=tgross35

bors · 2025-06-03T08:36:41Z

📌 Commit d296c12 has been approved by tgross35

It is now in the queue for this repository.

bors · 2025-06-04T03:34:54Z

☔ The latest upstream changes (presumably #141984) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2025-06-04T06:44:18Z

@bors r=tgross35

bors · 2025-06-04T06:44:21Z

📌 Commit ccf9a89 has been approved by tgross35

It is now in the queue for this repository.

coretests: move float tests from num to floats module and use a more flexible macro to generate them This makes some progress on rust-lang#141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough. I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR.

Rollup of 9 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142002 (redesign stage 0 std follow-ups part2) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-06-04T14:23:32Z

@bors r-
#142020 (comment)

…flexible macro to generate them

RalfJung · 2025-06-04T14:32:36Z

@bors2 try

rust-bors · 2025-06-04T14:32:41Z

⌛ Trying commit 7742d0e with merge 43707d4…

To cancel the try build, run the command @bors2 try cancel.

coretests: move float tests from num to floats module and use a more flexible macro to generate them This makes some progress on #141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough. I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR.    try-job: x86_64-gnu-aux

rust-bors · 2025-06-04T15:48:50Z

☀️ Try build successful (CI)
Build commit: 43707d4 (43707d4503c551e49a91fdfb3a72ea975022d948)

RalfJung · 2025-06-04T16:05:18Z

@bors r=tgross35

bors · 2025-06-04T16:05:20Z

📌 Commit 7742d0e has been approved by tgross35

It is now in the queue for this repository.

coretests: move float tests from num to floats module and use a more flexible macro to generate them This makes some progress on rust-lang#141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough. I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR. try-job: x86_64-gnu-aux

Rollup of 8 pull requests Successful merges: - #137992 (Stabilise `os_string_pathbuf_leak`) - #141558 (Limit the size of cgu names when using the `-Zhuman-readable-cgu-name…) - #141797 (compiler: set Apple frame pointers by architecture) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #142045 (Make obligation cause code suggestions verbose) - #142076 (Check documentation of bootstrap in PR CI) - #142110 (Add solaris targets to build-manifest) - #142131 (Make cast suggestions verbose) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141857 - RalfJung:coretests-floats, r=tgross35 coretests: move float tests from num to floats module and use a more flexible macro to generate them This makes some progress on #141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough. I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR. try-job: x86_64-gnu-aux

coretests: move float tests from num to floats module and use a more flexible macro to generate them This makes some progress on rust-lang#141726 by moving the float tests in `num` to `floats` and using a newer, more flexible macro to generate them. We also newly run these tests on f16 and f128 in const, and at runtime in Miri and for hosts where that works well enough. I didn't yet deduplicate any tests or port the existing `floats::f*` tests to the macro, that can happen in a future PR. try-job: x86_64-gnu-aux

rustbot assigned Mark-Simulacrum Jun 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 1, 2025

rustbot assigned tgross35 and unassigned Mark-Simulacrum Jun 1, 2025

This comment has been minimized.

Sign in to view

RalfJung force-pushed the coretests-floats branch from 77b3d3d to f3b4668 Compare June 1, 2025 14:49

This comment has been minimized.

Sign in to view

tgross35 reviewed Jun 3, 2025

View reviewed changes

library/coretests/tests/floats/mod.rs Show resolved Hide resolved

library/coretests/tests/floats/mod.rs Show resolved Hide resolved

library/coretests/tests/floats/mod.rs Outdated Show resolved Hide resolved

RalfJung force-pushed the coretests-floats branch 3 times, most recently from 0c707f9 to fdadc1c Compare June 3, 2025 07:04

This comment has been minimized.

Sign in to view

RalfJung force-pushed the coretests-floats branch from fdadc1c to bc0b999 Compare June 3, 2025 07:20

tgross35 reviewed Jun 3, 2025

View reviewed changes

library/coretests/tests/floats/mod.rs Outdated Show resolved Hide resolved

tgross35 approved these changes Jun 3, 2025

View reviewed changes

RalfJung force-pushed the coretests-floats branch from bc0b999 to d296c12 Compare June 3, 2025 07:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2025

RalfJung force-pushed the coretests-floats branch from d296c12 to ccf9a89 Compare June 4, 2025 06:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025

matthiaskrgr mentioned this pull request Jun 4, 2025

Rollup of 9 pull requests #142020

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2025

coretests: move float tests from num to floats module and use a more …

7742d0e

…flexible macro to generate them

RalfJung force-pushed the coretests-floats branch from ccf9a89 to 7742d0e Compare June 4, 2025 14:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025

This was referenced Jun 7, 2025

Rollup of 9 pull requests #142141

Closed

Rollup of 8 pull requests #142142

Merged

bors merged commit 0d2bf86 into rust-lang:master Jun 7, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 7, 2025

RalfJung deleted the coretests-floats branch June 7, 2025 10:13

Uh oh!

Conversation

RalfJung commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 1, 2025

Uh oh!

RalfJung commented Jun 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

RalfJung commented Jun 3, 2025

Uh oh!

Uh oh!

RalfJung commented Jun 3, 2025

Uh oh!

bors commented Jun 3, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

RalfJung commented Jun 4, 2025

Uh oh!

bors commented Jun 4, 2025

Uh oh!

matthiaskrgr commented Jun 4, 2025

Uh oh!

RalfJung commented Jun 4, 2025

Uh oh!

rust-bors bot commented Jun 4, 2025

Uh oh!

rust-bors bot commented Jun 4, 2025

Uh oh!

RalfJung commented Jun 4, 2025 via email

Uh oh!

bors commented Jun 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RalfJung commented Jun 1, 2025 •

edited

Loading