Merged
Conversation
New Windows Server 2025 images have been released (20250527).
…he order of declaration.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
It is only used within cg_llvm.
It is only used within cg_llvm.
…rcote fix(rust-lang#141141): When expanding `PartialEq`, check equality of scalar types first. Fixes rust-lang#141141. Now, `cs_eq` function of `partial_eq.rs` compares [scalar types](https://doc.rust-lang.org/rust-by-example/primitives.html#scalar-types) first. - Add `is_scalar` field to `FieldInfo`. - Add `is_scalar` method to `TyKind`. - Pass `FieldInfo` via `CsFold::Combine` and refactor code relying on it. - Implement `TryFrom<&str>` and `TryFrom<Symbol>` for FloatTy. - Implement `TryFrom<&str>` and `TryFrom<Symbol>` for IntTy. - Implement `TryFrom<&str>` and `TryFrom<Symbol>` for UintTy.
`tests/ui`: A New Order [2/N] part of rust-lang#133895 r? `@jieyouxu` let's try this kind of commits, one for each file, commit's name shows what i did, hope this is not harder to review than previous
…527, r=Kobzol
Switch `x86_64-msvc-{1,2}` back to Windows Server 2025 images
New Windows Server 2025 images have been released (**20250527.1.0**). New images appear to not exhibit the lack-of-disk-space problem as tracked by rust-lang#141022, and the new runner image's storage capacity appears to be configured correctly.
Windows Server 2025 image version **20250527.1.0** release notes: <https://github.com/actions/runner-images/releases/tag/win25%2F20250527.1>.
Resolves rust-lang#141022.
redesign stage 0 std follow-ups Various follow-ups pointed out on Zulip during post-merge discussions of [redesign stage 0 std rust-lang#119899](rust-lang#119899). r? `@jieyouxu` Fixes rust-lang#141902. Fixes rust-lang#141905. cc `@jyn514`
…thercote Deconstruct values in the THIR visitor Hi! I am a beginner rust developer. I'm trying to solve your problem rust-lang#141849 I see that 2 files need to be corrected, so I’m starting with a simpler step, `compiler/rustc_middle/src/thir/visit.rs` r? `@krikera`
Update books ## rust-lang/book 4 commits in 230c68bc1e08f5f3228384a28cc228c81dfbd10d..634724ea85ebb08a542970bf8871ac8b0f77fd15 2025-05-29 13:16:14 UTC to 2025-05-22 21:35:03 UTC - Chapter 10 from tech review (rust-lang/book#4379) - Chapter 9 from tech review (rust-lang/book#4377) - Chapter 8 from tech review (rust-lang/book#4378) - Chapter 7 from tech review (rust-lang/book#4374) ## rust-embedded/book 3 commits in 0b8219ac23a3e09464e4e0166c768cf1c4bba0d5..10fa1e084365f23f24ad0000df541923385b73b6 2025-05-27 18:37:30 UTC to 2025-05-27 18:26:36 UTC - portability: add reference to embedded-hal docs (rust-embedded/book#391) - remove the unused and deprecated `multilingual` field from `book.toml` (rust-embedded/book#388) - Ci upgrade 20250522 (rust-embedded/book#393) ## rust-lang/nomicon 4 commits in c76a20f0d987145dcedf05c5c073ce8d91f2e82a..8b61acfaea822e9ac926190bc8f15791c33336e8 2025-05-26 10:16:09 UTC to 2025-05-23 15:03:00 UTC - Use inline const expression in unchecked-uninit.md (rust-lang/nomicon#492) - Fix code sample output in unchecked-uninit.md (rust-lang/nomicon#491) - Use consistent type parameters in subtyping.md (rust-lang/nomicon#493) - Fix typo in atomics.md (rust-lang/nomicon#494) ## rust-lang/reference 1 commits in 118fd1f1f0854f50e3ae1fe4b64862aad23009ca..8e0f593a30f3b56ddb0908fb7ab9249974e08738 2025-05-31 20:12:39 UTC to 2025-05-31 20:12:39 UTC - Minor fixes to `$crate` behavior (rust-lang/reference#1816) ## rust-lang/rust-by-example 4 commits in c9d151f9147c4808c77f0375ba3fa5d54443cb9e..21f4e32b8b40d36453fae16ec07ad4b857c445b6 2025-05-29 12:45:08 UTC to 2025-05-29 12:44:23 UTC - Update book.toml rename `author` field to `authors` (rust-lang/rust-by-example#1917) - Add example to comment.md to teach how to toggle a whole code block using block comments (rust-lang/rust-by-example#1919) - The example is not meant to be compiled with out passing arguments. (rust-lang/rust-by-example#1930) - added a shorthand for the #[should_panic(expected = "msg") (rust-lang/rust-by-example#1931)
…nethercote Deconstruct values in the THIR visitor I continue to add deconstruction for task rust-lang#141849 The changes concern a more complex part of the task `compiler/rustc_hir/src/intravisit.rs` r? `@nnethercote`
…-obk Remove two trait methods from cg_ssa They are only called by cg_llvm.
rustbot
added
A-LLVM
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: aae43c4532 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing aae43c4 (parent) -> a124fb3 (this PR) Test differencesShow 189 test diffsStage 1
Stage 2
(and 87 additional test diffs) Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a124fb3cb7291d75872934f411d81fe298379ace --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (a124fb3): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.1%, secondary -0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 745.073s -> 745.424s (0.05%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
PartialEq, check equality of scalar types first. #141724 (fix(#[derive(PartialEq)] does not reorder field comparisons to improve performance #141141): When expandingPartialEq, check equality of scalar types first.)tests/ui: A New Order [2/N] #141833 (tests/ui: A New Order [2/N])x86_64-msvc-{1,2}back to Windows Server 2025 images #141861 (Switchx86_64-msvc-{1,2}back to Windows Server 2025 images)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup