Implement send_signal for unix child processes by Qelxiros · Pull Request #141990 · rust-lang/rust

Qelxiros · 2025-06-03T21:44:08Z

Tracking issue: #141975

There are two main differences between my implementation and the Public API section of the tracking issue. ~~First, send_signal requires a mutable reference, like Child::kill.~~ Second, ChildExt has Sealed as a supertrait, bringing it more in line with other extension traits like CommandExt.

try-job: dist-various*
try-job: test-various*

rustbot · 2025-06-03T21:44:13Z

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ChrisDenton · 2025-06-03T23:06:21Z

cc @tgross35 as this modifies the proposed API slightly

- fn send_signal(&self, signal: i32) -> Result<()>;
+ fn send_signal(&mut self, signal: i32) -> Result<()>;

tgross35 · 2025-06-03T23:17:50Z

I didn't put too much thought into what I wrote there, so it's fine if it needs to change. That being said, why does this need to be &mut? kill should be MT-Safe https://www.gnu.org/software/libc/manual/2.28/html_node/Signaling-Another-Process.html

@Qelxiros could you add documentation and examples here?

Qelxiros · 2025-06-04T00:03:55Z

You're right that it doesn't need to be mutable, so I changed it back. I do wonder why e.g. Child::kill takes a mutable reference. Is it required on windows? If so, is it worth adding a kill-specific method to the unix ChildExt?

ChrisDenton · 2025-06-04T08:10:36Z

No it's not to do with Windows. It seems to have been a deliberate decision in the early days of rust, though I can't find any record of the thinking behind it. It was implemented in #22119 and all the implementations use &self behind the scenes, only the public interface used &mut self.

library/std/src/os/unix/process.rs

Qelxiros · 2025-06-06T17:24:07Z

@tgross35 could you add an unresolved question to the tracking issue regarding & vs &mut? I want to make sure it doesn't get forgotten before stabilization.

tgross35 · 2025-06-06T17:35:03Z

@tgross35 could you add an unresolved question to the tracking issue regarding & vs &mut? I want to make sure it doesn't get forgotten before stabilization.

Added.

I think this implementation looks fine, just needs a squash (I'll let Chris do the final review)

Qelxiros · 2025-06-07T14:41:49Z

@rustbot ready

ChrisDenton · 2025-06-15T11:48:29Z

Thanks!

@bors r+

bors · 2025-06-15T11:48:32Z

📌 Commit 269ee72 has been approved by ChrisDenton

It is now in the queue for this repository.

…r=ChrisDenton Implement send_signal for unix child processes Tracking issue: rust-lang#141975 There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`.

Rollup of 7 pull requests Successful merges: - #138237 (Get rid of `EscapeDebugInner`.) - #140809 (Reduce special casing for the panic runtime) - #141990 (Implement send_signal for unix child processes) - #142082 (Refactor `rustc_attr_data_structures` documentation) - #142125 (Stabilize "file_lock" feature) - #142528 (clarify `rustc_do_not_const_check` comment) - #142530 (use `if let` guards where possible) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2025-06-16T07:49:24Z

@bors r-

Failed the rollup at #142558 (comment). You'll need to make sure that all OSs in https://github.com/rust-lang/rust/tree/269ee72c330c21a9e0526e69fc0f85d762043d2d/library/std/src/sys/process/unix / https://github.com/rust-lang/rust/tree/68ac5abb067806a88464ddbfbd3c7eec877b488d/library/std/src/sys/process/unix have an implementation.

tgross35 · 2025-06-17T21:39:08Z

library/std/src/sys/process/unix/fuchsia.rs


+    pub fn send_signal(&mut self) -> io::Result<()> {
+        // Fuchsia doesn't have a direct equivalent for signals
+        unimplemented!()


Cc target maintainers @erickt @Nashenas88 just to double check there isn't something that makes sense here (nonblocking for this PR)

Fuchsia and unsupported need a _signal: i32 argument to match the other signatures

Correct, fuchsia does not support signals. Thanks for checking!

tgross35 · 2025-06-18T06:40:35Z

Thanks!

@bors r=ChrisDenton,tgross35

bors · 2025-06-18T06:40:38Z

📌 Commit b391494 has been approved by ChrisDenton,tgross35

It is now in the queue for this repository.

…r=ChrisDenton,tgross35 Implement send_signal for unix child processes Tracking issue: rust-lang#141975 There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`. try-job: `dist-various*` try-job: `test-various*`

Rollup of 6 pull requests Successful merges: - #141990 (Implement send_signal for unix child processes) - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - #142502 (rustdoc_json: improve handling of generic args) - #142629 (Add config builder for bootstrap tests) - #142687 (Reduce uses of `hir_crate`.) - #142714 (add comment to `src/bootstrap/build.rs`) r? `@ghost` `@rustbot` modify labels: rollup

…r=ChrisDenton,tgross35 Implement send_signal for unix child processes Tracking issue: rust-lang#141975 There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`. try-job: `dist-various*` try-job: `test-various*`

Rollup of 10 pull requests Successful merges: - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure) - #141990 (Implement send_signal for unix child processes) - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.) - #142478 (install docs for each target in different directory) - #142571 (Reason about borrowed classes in CopyProp.) - #142668 (vec_deque/fmt/vec tests: remove static mut) - #142687 (Reduce uses of `hir_crate`.) - #142690 (expand: Remove some unnecessary generic parameters) - #142699 (Update books) - #142714 (add comment to `src/bootstrap/build.rs`) Failed merges: - #142502 (rustdoc_json: improve handling of generic args) r? `@ghost` `@rustbot` modify labels: rollup

…r=ChrisDenton,tgross35 Implement send_signal for unix child processes Tracking issue: rust-lang#141975 There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`. try-job: `dist-various*` try-job: `test-various*`

Rollup of 8 pull requests Successful merges: - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure) - #140920 (Extract some shared code from codegen backend target feature handling) - #141990 (Implement send_signal for unix child processes) - #142597 (error on calls to ABIs that cannot be called) - #142668 (vec_deque/fmt/vec tests: remove static mut) - #142687 (Reduce uses of `hir_crate`.) - #142699 (Update books) - #142714 (add comment to `src/bootstrap/build.rs`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure) - #140920 (Extract some shared code from codegen backend target feature handling) - #141990 (Implement send_signal for unix child processes) - #142668 (vec_deque/fmt/vec tests: remove static mut) - #142687 (Reduce uses of `hir_crate`.) - #142699 (Update books) - #142714 (add comment to `src/bootstrap/build.rs`) - #142753 (Update library dependencies) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141990 - Qelxiros:141975-unix_send_signal, r=ChrisDenton,tgross35 Implement send_signal for unix child processes Tracking issue: #141975 There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`. try-job: `dist-various*` try-job: `test-various*`

…t, r=Mark-Simulacrum update internal `send_signal` comment the vxwork did not have the old comment updated in rust-lang#141990 so update here; signaling -> sending signals to because the latter reads better to me.

Rollup merge of #143082 - fee1-dead-contrib:push-qvvppzukvkxt, r=Mark-Simulacrum update internal `send_signal` comment the vxwork did not have the old comment updated in #141990 so update here; signaling -> sending signals to because the latter reads better to me.

…-Simulacrum update internal `send_signal` comment the vxwork did not have the old comment updated in rust-lang/rust#141990 so update here; signaling -> sending signals to because the latter reads better to me.

…r=ChrisDenton,tgross35 Implement send_signal for unix child processes Tracking issue: rust-lang#141975 There are two main differences between my implementation and the Public API section of the tracking issue. ~First, `send_signal` requires a mutable reference, like `Child::kill`.~ Second, `ChildExt` has `Sealed` as a supertrait, bringing it more in line with other extension traits like `CommandExt`. try-job: `dist-various*` try-job: `test-various*`

…t, r=Mark-Simulacrum update internal `send_signal` comment the vxwork did not have the old comment updated in rust-lang#141990 so update here; signaling -> sending signals to because the latter reads better to me.

rustbot assigned ChrisDenton Jun 3, 2025

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 3, 2025

ChrisDenton reviewed Jun 4, 2025

View reviewed changes

library/std/src/os/unix/process.rs Outdated Show resolved Hide resolved

ChrisDenton added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025

tgross35 mentioned this pull request Jun 6, 2025

Tracking Issue for unix_send_signal #141975

Open

5 tasks

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2025

Qelxiros force-pushed the 141975-unix_send_signal branch from 149dd21 to 269ee72 Compare June 12, 2025 03:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2025

tgross35 mentioned this pull request Jun 16, 2025

Rollup of 7 pull requests #142558

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2025

tgross35 reviewed Jun 17, 2025

View reviewed changes

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025

Kobzol mentioned this pull request Jun 19, 2025

Rollup of 6 pull requests #142719

Closed

jhpratt mentioned this pull request Jun 19, 2025

Rollup of 10 pull requests #142750

Closed

tgross35 mentioned this pull request Jun 20, 2025

Rollup of 8 pull requests #142762

Closed

tgross35 mentioned this pull request Jun 20, 2025

Rollup of 8 pull requests #142770

Merged

bors merged commit e381a14 into rust-lang:master Jun 20, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 20, 2025

fee1-dead mentioned this pull request Jun 27, 2025

update internal send_signal comment #143082

Merged

Qelxiros deleted the 141975-unix_send_signal branch September 14, 2025 21:05

Uh oh!

Conversation

Qelxiros commented Jun 3, 2025 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 3, 2025

Uh oh!

ChrisDenton commented Jun 3, 2025

Uh oh!

tgross35 commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Qelxiros commented Jun 4, 2025

Uh oh!

ChrisDenton commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Qelxiros commented Jun 6, 2025

Uh oh!

tgross35 commented Jun 6, 2025

Uh oh!

Qelxiros commented Jun 7, 2025

Uh oh!

ChrisDenton commented Jun 15, 2025

Uh oh!

bors commented Jun 15, 2025

Uh oh!

tgross35 commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

erickt Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Jun 18, 2025

Uh oh!

bors commented Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Qelxiros commented Jun 3, 2025 •

edited by tgross35

Loading

tgross35 commented Jun 3, 2025 •

edited

Loading

ChrisDenton commented Jun 4, 2025 •

edited

Loading

tgross35 commented Jun 16, 2025 •

edited

Loading