don't panic for incompatible download-rustc options outside of CI env#142054
Closed
onur-ozkan wants to merge 1 commit intorust-lang:masterfrom
Closed
don't panic for incompatible download-rustc options outside of CI env#142054onur-ozkan wants to merge 1 commit intorust-lang:masterfrom
onur-ozkan wants to merge 1 commit intorust-lang:masterfrom
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Collaborator
|
rustbot has assigned @albertlarsan68. Use |
rustbot
added
S-waiting-on-review
Collaborator
|
This PR modifies If appropriate, please update |
Member
|
r? jieyouxu Waiting on discussions to settle on #t-infra/bootstrap > Settings are incompatible with download-rustc. @rustbot label -S-waiting-on-review +S-waiting-on-team |
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-team
and removed
S-waiting-on-review
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prints the error instead of panicking when doing the incompatibility check outside of CI environments.
See the alternative solution with config-based approach: #142055
Fixes #141953