Skip to content

Detect more cases of unused_parens around types#142237

Merged
bors merged 1 commit intorust-lang:masterfrom
benschulz:unused-parens-fn
Jul 3, 2025
Merged

Detect more cases of unused_parens around types#142237
bors merged 1 commit intorust-lang:masterfrom
benschulz:unused-parens-fn

Conversation

@benschulz
Copy link
Contributor

@benschulz benschulz commented Jun 9, 2025

With this change, more unused parentheses around bounds and types nested within bounds are detected.

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2025

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

benschulz
benschulz commented Jun 9, 2025
View reviewed changes
@fee1-dead
Copy link
Member

fee1-dead commented Jun 22, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

☔ The latest upstream changes (presumably #142878) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jun 27, 2025
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2025
@fee1-dead fee1-dead added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2025
fee1-dead
fee1-dead requested changes Jun 29, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2025
benschulz
benschulz commented Jun 29, 2025
View reviewed changes
Copy link
Contributor Author

@benschulz benschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
fee1-dead
fee1-dead requested changes Jun 30, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025
@benschulz
Copy link
Contributor Author

benschulz commented Jun 30, 2025 •
edited
Loading

Thank you for the detailed/reasoned review feedback.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2025
fee1-dead
fee1-dead requested changes Jul 1, 2025
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one last couple of nits, otherwise I think this is good to go :)

Please also squash your commits into one.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@benschulz
Copy link
Contributor Author

benschulz commented Jul 1, 2025

Done, thanks again for your feedback! 🙂

@fee1-dead
Copy link
Member

fee1-dead commented Jul 1, 2025

LGTM, Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

📌 Commit 7d6764a has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 2, 2025
Merged
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143338 - matthiaskrgr:rollup-ykaxh04, r=<try>
3207ab5 
Rollup of 11 pull requests

Successful merges:

 - #131923 (Derive `Copy` and `Hash` for `IntErrorKind`)
 - #138340 (Remove some unsized tuple impls now that we don't support unsizing tuples anymore)
 - #141219 (Change `{Box,Arc,Rc,Weak}::into_raw` to only work with `A = Global`)
 - #142212 (bootstrap: validate `rust.codegen-backends` & `target.<triple>.codegen-backends`)
 - #142237 (Detect more cases of unused_parens around types)
 - #142964 (Attribute rework: a parser for single attributes without arguments)
 - #143070 (Rewrite `macro_rules!` parser to not use the MBE engine itself)
 - #143235 (Assemble const bounds via normal item bounds in old solver too)
 - #143261 (Feed `explicit_predicates_of` instead of `predicates_of`)
 - #143276 (loop match: handle opaque patterns)
 - #143306 (Add `track_caller` attributes to trace origin of Clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
bors added a commit that referenced this pull request Jul 2, 2025
@bors
Auto merge of #143338 - matthiaskrgr:rollup-ykaxh04, r=matthiaskrgr
25face9 
Rollup of 11 pull requests

Successful merges:

 - #131923 (Derive `Copy` and `Hash` for `IntErrorKind`)
 - #138340 (Remove some unsized tuple impls now that we don't support unsizing tuples anymore)
 - #141219 (Change `{Box,Arc,Rc,Weak}::into_raw` to only work with `A = Global`)
 - #142212 (bootstrap: validate `rust.codegen-backends` & `target.<triple>.codegen-backends`)
 - #142237 (Detect more cases of unused_parens around types)
 - #142964 (Attribute rework: a parser for single attributes without arguments)
 - #143070 (Rewrite `macro_rules!` parser to not use the MBE engine itself)
 - #143235 (Assemble const bounds via normal item bounds in old solver too)
 - #143261 (Feed `explicit_predicates_of` instead of `predicates_of`)
 - #143276 (loop match: handle opaque patterns)
 - #143306 (Add `track_caller` attributes to trace origin of Clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@bors bors merged commit 6ebf642 into rust-lang:master Jul 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 3, 2025
rust-timer added a commit that referenced this pull request Jul 3, 2025
@rust-timer
Unrolled build for #142237
2d1c3a6 
Rollup merge of #142237 - benschulz:unused-parens-fn, r=fee1-dead

Detect more cases of unused_parens around types

With this change, more unused parentheses around bounds and types nested within bounds are detected.
@benschulz benschulz deleted the unused-parens-fn branch July 3, 2025 12:00
@alexcrichton alexcrichton mentioned this pull request Jul 8, 2025
Closed
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#142237 - benschulz:unused-parens-fn, r=fee1…
b94f16a 
…-dead

Detect more cases of unused_parens around types

With this change, more unused parentheses around bounds and types nested within bounds are detected.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
@bors
Auto merge of rust-lang#143338 - matthiaskrgr:rollup-ykaxh04, r=matth…
16b0f5e 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#131923 (Derive `Copy` and `Hash` for `IntErrorKind`)
 - rust-lang#138340 (Remove some unsized tuple impls now that we don't support unsizing tuples anymore)
 - rust-lang#141219 (Change `{Box,Arc,Rc,Weak}::into_raw` to only work with `A = Global`)
 - rust-lang#142212 (bootstrap: validate `rust.codegen-backends` & `target.<triple>.codegen-backends`)
 - rust-lang#142237 (Detect more cases of unused_parens around types)
 - rust-lang#142964 (Attribute rework: a parser for single attributes without arguments)
 - rust-lang#143070 (Rewrite `macro_rules!` parser to not use the MBE engine itself)
 - rust-lang#143235 (Assemble const bounds via normal item bounds in old solver too)
 - rust-lang#143261 (Feed `explicit_predicates_of` instead of `predicates_of`)
 - rust-lang#143276 (loop match: handle opaque patterns)
 - rust-lang#143306 (Add `track_caller` attributes to trace origin of Clippy lints)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@blyxyas blyxyas mentioned this pull request Jul 23, 2025
Open
@Skgland Skgland mentioned this pull request Nov 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

5 participants

@benschulz @rustbot @fee1-dead @bors @rust-log-analyzer