error on calls to ABIs that cannot be called by folkertdev · Pull Request #142597 · rust-lang/rust

folkertdev · 2025-06-16T20:10:01Z

We recently added extern "custom", which cannot be called using a rust call expression. But there are more ABIs that can't be called in that way, because the call does not semantically make sense.

More details are in #140566 (comment)

r? @workingjubilee

try-job: x86_64-gnu-llvm-19-3

rustbot · 2025-06-16T20:10:06Z

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

compiler/rustc_abi/src/extern_abi.rs

compiler/rustc_hir_typeck/src/callee.rs

compiler/rustc_abi/src/extern_abi.rs

workingjubilee

I think we would both like a slightly less annoying rebase, depending on which PR lands first (probably yours, tbh).

workingjubilee · 2025-06-17T22:56:09Z

tests/ui/abi/unsupported.rs

+extern "riscv-interrupt-s" fn riscv_s() {}
+//[x64,x64_win,i686,arm,aarch64]~^ ERROR is not a supported ABI
+fn riscv_s_ptr(f: extern "riscv-interrupt-s" fn()) {
+    //[x64,x64_win,i686,arm,aarch64]~^ WARN unsupported_fn_ptr_calling_conventions
+    //[x64,x64_win,i686,arm,aarch64]~^^ WARN this was previously accepted
+    f()
+    //[riscv32,riscv64]~^ ERROR functions with the `"riscv-interrupt-s"` ABI cannot be called
+}
+extern "riscv-interrupt-s" {}
+//[x64,x64_win,i686,arm,aarch64]~^ ERROR is not a supported ABI


this sure is getting to be an exciting test file

the alternative is to split it up per-target, which has upsides and downsides.

workingjubilee · 2025-06-17T23:02:10Z

tests/ui/abi/unsupported.rs

in the interest of minimizing (not eliminating, only minimizing) conflicts with a number of other in-flight PRs touching this file, can you duplicate (yes, duplicate as in add-a-new-file-with, not first-remove-here-and-then-add-a-new-file-with) the parts of the test for interrupt ABIs that you want to edit? then revert the change to this file that aren't going-to-happen-anyway?

include a FIXME that the duplication is intentional in the new file and that in the near future the duplication should be reduced (preferably by splitting up unsupported.rs a bit more but it really doesn't matter).

I split this out, and really there is less overlap than it seems: when using revisions, this is just kind of what you get. Any changes to the error messages will prompt to look at the duplication again.

compiler/rustc_hir_typeck/messages.ftl

folkertdev · 2025-06-18T11:02:16Z

@rustbot ready

workingjubilee · 2025-06-20T02:46:14Z

@bors r+

Only affects unstable API
@bors rollup

bors · 2025-06-20T02:46:16Z

📌 Commit 54970a8 has been approved by workingjubilee

It is now in the queue for this repository.

…=workingjubilee error on calls to ABIs that cannot be called We recently added `extern "custom"`, which cannot be called using a rust call expression. But there are more ABIs that can't be called in that way, because the call does not semantically make sense. More details are in rust-lang#140566 (comment) r? `@workingjubilee`

Rollup of 8 pull requests Successful merges: - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure) - #140920 (Extract some shared code from codegen backend target feature handling) - #141990 (Implement send_signal for unix child processes) - #142597 (error on calls to ABIs that cannot be called) - #142668 (vec_deque/fmt/vec tests: remove static mut) - #142687 (Reduce uses of `hir_crate`.) - #142699 (Update books) - #142714 (add comment to `src/bootstrap/build.rs`) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2025-06-20T06:48:25Z

Well, this is doing its job #142762 (comment)

@bors r-

folkertdev · 2025-06-20T08:17:57Z

A casualty of CI now running on aarch64. This test could just use minicore though I think? I'll fix that later today.

https://github.com/rust-lang/rust/blob/master/tests/codegen/naked-asan.rs

tgross35 · 2025-06-20T08:22:43Z

@bors2 delegate=try

rust-bors · 2025-06-20T08:22:46Z

@folkertdev can now perform try builds on this pull request

folkertdev · 2025-06-20T17:09:33Z

@bors2 try=x86_64-gnu-llvm-19-3

rust-bors · 2025-06-20T17:09:36Z

Unknown command "try".

folkertdev · 2025-06-20T17:10:11Z

@bors2 try

error on calls to ABIs that cannot be called We recently added `extern "custom"`, which cannot be called using a rust call expression. But there are more ABIs that can't be called in that way, because the call does not semantically make sense. More details are in #140566 (comment) r? `@workingjubilee` try-job: x86_64-gnu-llvm-19-3

rust-bors · 2025-06-20T17:10:16Z

⌛ Trying commit a32d085 with merge 8c73581…

To cancel the try build, run the command @bors2 try cancel.

tgross35 · 2025-06-20T17:16:08Z

@bors2 try=x86_64-gnu-llvm-19-3

For reference it’s bors2 try jobs=…

rust-bors · 2025-06-20T19:07:19Z

☀️ Try build successful (CI)
Build commit: 8c73581 (8c73581ec29d2c5dd590ad546ef66e0434b83c33, parent: 9c4ff566babe632af5e30281a822d1ae9972873b)

folkertdev · 2025-06-20T19:08:38Z

@rustbot ready

tgross35 · 2025-06-20T19:15:27Z

@bors r=workingjubilee rollup=maybe

bors · 2025-06-20T19:15:30Z

📌 Commit a32d085 has been approved by workingjubilee

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - #142502 (rustdoc_json: improve handling of generic args) - #142597 (error on calls to ABIs that cannot be called) - #142785 (fix(linkcheck): Build using the lockfile) - #142787 (Add diagnostic items for Clippy) - #142788 (add doc(alias("AsciiChar")) to core::ascii::Char) - #142801 (Use gen blocks in the compiler instead of `from_coroutine`) - #142804 (Rename `LayoutS` to `LayoutData` in comments) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142597 - folkertdev:abi-cannot-be-called, r=workingjubilee error on calls to ABIs that cannot be called We recently added `extern "custom"`, which cannot be called using a rust call expression. But there are more ABIs that can't be called in that way, because the call does not semantically make sense. More details are in #140566 (comment) r? `@workingjubilee` try-job: x86_64-gnu-llvm-19-3

Rollup of 7 pull requests Successful merges: - rust-lang/rust#142502 (rustdoc_json: improve handling of generic args) - rust-lang/rust#142597 (error on calls to ABIs that cannot be called) - rust-lang/rust#142785 (fix(linkcheck): Build using the lockfile) - rust-lang/rust#142787 (Add diagnostic items for Clippy) - rust-lang/rust#142788 (add doc(alias("AsciiChar")) to core::ascii::Char) - rust-lang/rust#142801 (Use gen blocks in the compiler instead of `from_coroutine`) - rust-lang/rust#142804 (Rename `LayoutS` to `LayoutData` in comments) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned workingjubilee Jun 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2025

workingjubilee reviewed Jun 16, 2025

View reviewed changes

compiler/rustc_abi/src/extern_abi.rs Outdated Show resolved Hide resolved

folkertdev force-pushed the abi-cannot-be-called branch from 8a2bc53 to e88e066 Compare June 16, 2025 20:33

workingjubilee reviewed Jun 16, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/callee.rs Outdated Show resolved Hide resolved

compiler/rustc_abi/src/extern_abi.rs Outdated Show resolved Hide resolved

folkertdev force-pushed the abi-cannot-be-called branch 2 times, most recently from 03b0436 to 70c0e58 Compare June 17, 2025 17:46

workingjubilee requested changes Jun 17, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025

folkertdev force-pushed the abi-cannot-be-called branch 3 times, most recently from 7ae8882 to 54970a8 Compare June 18, 2025 09:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2025

workingjubilee approved these changes Jun 20, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025

tgross35 mentioned this pull request Jun 20, 2025

Rollup of 8 pull requests #142762

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2025

error on calls to ABIs that cannot be called

a32d085

folkertdev force-pushed the abi-cannot-be-called branch from 54970a8 to a32d085 Compare June 20, 2025 17:09

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025

matthiaskrgr mentioned this pull request Jun 21, 2025

Rollup of 7 pull requests #142817

Merged

bors merged commit 504092f into rust-lang:master Jun 21, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 21, 2025

Uh oh!

Conversation

folkertdev commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

workingjubilee left a comment

Choose a reason for hiding this comment

Uh oh!

workingjubilee Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

folkertdev Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

workingjubilee Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

folkertdev Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

folkertdev commented Jun 18, 2025

Uh oh!

workingjubilee commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

tgross35 commented Jun 20, 2025

Uh oh!

folkertdev commented Jun 20, 2025

Uh oh!

tgross35 commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

folkertdev commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

folkertdev commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

tgross35 commented Jun 20, 2025

Uh oh!

rust-bors bot commented Jun 20, 2025

Uh oh!

folkertdev commented Jun 20, 2025

Uh oh!

tgross35 commented Jun 20, 2025

Uh oh!

bors commented Jun 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

folkertdev commented Jun 16, 2025 •

edited

Loading