compiler-builtins: Clean up features#142659
Draft
tgross35 wants to merge 1 commit intorust-lang:mainfrom
Draft
Conversation
rustbot
added
A-compiler-builtins
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
builtins-features
branch
from
89b4e61 to
802792b
Compare
bjorn3
reviewed
Jun 18, 2025
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
builtins-features
branch
from
802792b to
5a5d4b8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Remove the `compiler-builtins` from default because it prevents testing via the default `cargo test` command. It made more sense as a default when `compiler-builtins` was a dependency that some crates added via crates.io, but is no longer needed The `rustc-dep-of-std` feature is also removed since it doesn't do anything notable.
tgross35
force-pushed
the
builtins-features
branch
from
5a5d4b8 to
e74a507
Compare
Contributor
|
☔ The latest upstream changes (presumably #151794) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
compiler-builtinsfrom default because it prevents testing via the defaultcargo testcommand. It made more sense as a default whencompiler-builtinswas a dependency that some crates added via crates.io, but is no longer neededThe
rustc-dep-of-stdfeature is also removed since it doesn't do anything notable.r? @ghost