Port `#[rustc_skip_during_method_dispatch]` to the new attribute system by GrigorenkoPV · Pull Request #142695 · rust-lang/rust

GrigorenkoPV · 2025-06-18T21:36:21Z

Part of #131229

r? @jdonszelmann

rustbot · 2025-06-18T21:36:25Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-06-18T21:36:28Z

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

jdonszelmann · 2025-06-18T21:49:02Z

compiler/rustc_hir_analysis/src/collect.rs

    let rustc_coinductive = tcx.has_attr(def_id, sym::rustc_coinductive);
    let is_fundamental = tcx.has_attr(def_id, sym::fundamental);

-    // FIXME: We could probably do way better attribute validation here.


Hehe, fixed the fixme :)

compiler/rustc_attr_parsing/src/attributes/mod.rs

compiler/rustc_attr_parsing/src/attributes/resolution.rs

tests/ui/attributes/rustc_skip_during_method_dispatch.stderr

GrigorenkoPV · 2025-06-18T22:12:12Z

@rustbot ready

compiler/rustc_attr_parsing/src/attributes/resolution.rs

bors · 2025-06-19T07:29:11Z

☔ The latest upstream changes (presumably #142697) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-06-20T06:13:32Z

compiler/rustc_attr_parsing/src/context.rs

    }
+
+    pub(crate) fn expect_no_args(&self, args: &ArgParser<'_>) -> Result<(), ErrorGuaranteed> {
+        if let Some(span) = match args {


I think for #[cold] I implemented this exact method. Could you rebase on that branch? Unfortunately it's taking a bit for everything to merge in. #142491

bors · 2025-06-20T14:00:15Z

☔ The latest upstream changes (presumably #142770) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-06-21T18:47:51Z

☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-06-22T08:34:46Z

compiler/rustc_attr_parsing/src/context.rs

-            attribute: self.attr_path.clone(),
-            reason: AttributeParseErrorReason::ExpectedNoArgs,
-        })
+    pub(crate) fn expect_no_args(&self, args: &ArgParser<'_>) -> Result<(), ErrorGuaranteed> {


I don't really like this method, it's different from all the other ones on here, and other parsers already solve this issue just inline. I don't really want the context to do any parsing really. I just want the methods to emit the errors, parsing happens in the parser.

GrigorenkoPV · 2025-06-22T08:49:40Z

@rustbot author

rustbot · 2025-06-22T08:49:43Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

bors · 2025-06-22T21:07:44Z

☔ The latest upstream changes (presumably #142878) made this pull request unmergeable. Please resolve the merge conflicts.

GrigorenkoPV · 2025-06-22T21:38:58Z

@rustbot ready

jdonszelmann · 2025-06-22T21:52:11Z

compiler/rustc_attr_parsing/src/parser.rs

+    /// Assert that there were no args.
+    /// If there were, get a span to the arguments
+    /// (to pass to [`AcceptContext::expected_no_args`](crate::context::AcceptContext::expected_no_args)).
+    pub fn no_args(&self) -> Result<(), Span> {


jdonszelmann · 2025-06-23T22:46:02Z

@bors r+ rollup

bors · 2025-06-23T22:46:05Z

📌 Commit aa80a2b has been approved by jdonszelmann

It is now in the queue for this repository.

…_during_method_dispatch, r=jdonszelmann Port `#[rustc_skip_during_method_dispatch]` to the new attribute system Part of rust-lang#131229 r? `@jdonszelmann`

Rollup of 8 pull requests Successful merges: - #140622 (compiletest: Improve diagnostics for line annotation mismatches) - #142641 (Generate symbols.o for proc-macros too) - #142695 (Port `#[rustc_skip_during_method_dispatch]` to the new attribute system) - #142742 ([win][aarch64] Fix linking statics on Arm64EC, take 2) - #142894 (phantom_variance_markers: fix identifier usage in macro) - #142928 (Fix hang in --print=file-names in bootstrap) - #142930 (Account for beta revisions when normalizing versions) - #142932 (rustdoc-json: Keep empty generic args if parenthesized) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - #140005 (Set MSG_NOSIGNAL for UnixStream) - #140622 (compiletest: Improve diagnostics for line annotation mismatches) - #142354 (Fixes firefox copy paste issue) - #142695 (Port `#[rustc_skip_during_method_dispatch]` to the new attribute system) - #142779 (Add note about `str::split` handling of no matches.) - #142894 (phantom_variance_markers: fix identifier usage in macro) - #142928 (Fix hang in --print=file-names in bootstrap) - #142932 (rustdoc-json: Keep empty generic args if parenthesized) - #142933 (Simplify root goal API of solver a bit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142695 - GrigorenkoPV:attributes/rustc_skip_during_method_dispatch, r=jdonszelmann Port `#[rustc_skip_during_method_dispatch]` to the new attribute system Part of #131229 r? ``@jdonszelmann``

rustbot assigned jdonszelmann Jun 18, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2025

jdonszelmann requested changes Jun 18, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from 84a4a9a to e015bc7 Compare June 18, 2025 22:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2025

Bleachfuel reviewed Jun 18, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/resolution.rs Show resolved Hide resolved

Bleachfuel reviewed Jun 18, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/resolution.rs Outdated Show resolved Hide resolved

jdonszelmann mentioned this pull request Jun 19, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from e015bc7 to 961a2cd Compare June 19, 2025 15:29

jdonszelmann reviewed Jun 20, 2025

View reviewed changes

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from 961a2cd to 6e29774 Compare June 21, 2025 13:38

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from 6e29774 to 48290c7 Compare June 21, 2025 18:55

jdonszelmann reviewed Jun 22, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from 48290c7 to b830801 Compare June 22, 2025 21:25

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2025

jdonszelmann reviewed Jun 22, 2025

View reviewed changes

GrigorenkoPV requested a review from jdonszelmann June 23, 2025 15:40

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from b830801 to 0b69b02 Compare June 23, 2025 16:35

Port #[rustc_skip_during_method_dispatch] to the new attribute system

aa80a2b

GrigorenkoPV force-pushed the attributes/rustc_skip_during_method_dispatch branch from 0b69b02 to aa80a2b Compare June 23, 2025 19:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025

workingjubilee mentioned this pull request Jun 24, 2025

Rollup of 8 pull requests #142942

Closed

GuillaumeGomez mentioned this pull request Jun 24, 2025

Rollup of 9 pull requests #142956

Merged

bors merged commit 69cc875 into rust-lang:master Jun 24, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 24, 2025

GrigorenkoPV deleted the attributes/rustc_skip_during_method_dispatch branch June 24, 2025 13:57

Uh oh!

Conversation

GrigorenkoPV commented Jun 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 18, 2025

Uh oh!

rustbot commented Jun 18, 2025

Uh oh!

jdonszelmann Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GrigorenkoPV commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

bors commented Jun 19, 2025

Uh oh!

jdonszelmann Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Jun 20, 2025

Uh oh!

bors commented Jun 21, 2025

Uh oh!

jdonszelmann Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

GrigorenkoPV commented Jun 22, 2025

Uh oh!

rustbot commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

GrigorenkoPV commented Jun 22, 2025

Uh oh!

jdonszelmann Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Jun 23, 2025

Uh oh!

bors commented Jun 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

GrigorenkoPV commented Jun 18, 2025 •

edited by rustbot

Loading