Port `#[used]` to new attribute parsing infrastructure by JonathanBrouwer · Pull Request #142818 · rust-lang/rust

just to be clear @JonathanBrouwer, is the behavior right now exactly the same as before with regards to errors and which attribute applies in case of duplicates or not?

JonathanBrouwer · 2025-06-24T06:04:09Z

@jdonszelmann
The behaviour regarding errors and duplicates is exactly the same when multiple identical attributes are specified. This provides a warning "unused attribute" without stating it will be removed.

When multiple different attributes are applied the behaviour has changed. This is fine because [used(arg)] with an argument is unstable.

What has changed:

#[used]
#[used(linker)]

Before: Error, "compiler and linker can't be used together". This is a wrong error since #[used] should be equivalent to #[used(linker)]
After: Changed: now a warning, unused attribute

#[used]
#[used(compiler)]

Before: No error, ratcheting behaviour so "linker " is used
After: unchanged

#[used(linker)]
#[used(compiler)]

Before: Error
After: Changed: Now also does ratcheting to linker.

JonathanBrouwer · 2025-06-26T08:38:30Z

@jdonszelmann This one was not rebased on the encode-cross-crate PR yet, did that now ^

jdonszelmann · 2025-06-26T08:52:02Z

Ah I see

jdonszelmann · 2025-06-26T08:52:34Z

Whoops

jdonszelmann · 2025-06-26T09:03:01Z

@bors r+

bors · 2025-06-26T09:03:05Z

📌 Commit 9b3f729 has been approved by jdonszelmann

It is now in the queue for this repository.

…=jdonszelmann Port `#[used]` to new attribute parsing infrastructure Ports `used` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

jdonszelmann · 2025-06-26T21:13:15Z

@bors r-

bors · 2025-06-27T04:57:10Z

☔ The latest upstream changes (presumably #143074) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer · 2025-06-27T06:59:20Z

@jdonszelmann rebased ^

jdonszelmann · 2025-06-27T07:33:56Z

@bors r+

bors · 2025-06-27T07:33:59Z

📌 Commit 9e35684 has been approved by jdonszelmann

It is now in the queue for this repository.

…=jdonszelmann Port `#[used]` to new attribute parsing infrastructure Ports `used` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

Rollup of 6 pull requests Successful merges: - #142270 (Rustdoc js: even more typechecking improvements) - #142420 (Report infer ty errors during hir ty lowering) - #142818 (Port `#[used]` to new attribute parsing infrastructure) - #143020 (codegen_fn_attrs: make comment more precise) - #143036 (Remove support for `dyn*` from the compiler) - #143060 (Only args in main diag are saved and restored without removing the newly added ones) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - #142270 (Rustdoc js: even more typechecking improvements) - #142420 (Report infer ty errors during hir ty lowering) - #142671 (add #![rustc_no_implicit_bounds]) - #142721 (Add tracing to `InterpCx::layout_of()` ) - #142818 (Port `#[used]` to new attribute parsing infrastructure) - #143020 (codegen_fn_attrs: make comment more precise) - #143051 (Add tracing to `validate_operand`) - #143060 (Only args in main diag are saved and restored without removing the newly added ones) - #143065 (Improve recovery when users write `where:`) - #143084 (const-eval: error when initializing a static writes to that static) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142818 - JonathanBrouwer:used_new_parser, r=jdonszelmann Port `#[used]` to new attribute parsing infrastructure Ports `used` to the new attribute parsing infrastructure for #131229 (comment) r? ``@jdonszelmann``

Rollup of 10 pull requests Successful merges: - rust-lang/rust#142270 (Rustdoc js: even more typechecking improvements) - rust-lang/rust#142420 (Report infer ty errors during hir ty lowering) - rust-lang/rust#142671 (add #![rustc_no_implicit_bounds]) - rust-lang/rust#142721 (Add tracing to `InterpCx::layout_of()` ) - rust-lang/rust#142818 (Port `#[used]` to new attribute parsing infrastructure) - rust-lang/rust#143020 (codegen_fn_attrs: make comment more precise) - rust-lang/rust#143051 (Add tracing to `validate_operand`) - rust-lang/rust#143060 (Only args in main diag are saved and restored without removing the newly added ones) - rust-lang/rust#143065 (Improve recovery when users write `where:`) - rust-lang/rust#143084 (const-eval: error when initializing a static writes to that static) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jdonszelmann Jun 21, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025

JonathanBrouwer commented Jun 21, 2025

View reviewed changes

tests/ui/lint/unused/unused-attr-duplicate.stderr Outdated Show resolved Hide resolved

compiler/rustc_attr_parsing/src/attributes/used.rs Outdated Show resolved Hide resolved

jdonszelmann mentioned this pull request Jun 21, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann requested changes Jun 21, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/mod.rs Outdated Show resolved Hide resolved

compiler/rustc_attr_parsing/src/attributes/used.rs Outdated Show resolved Hide resolved

compiler/rustc_attr_parsing/src/attributes/used.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2025

JonathanBrouwer force-pushed the used_new_parser branch from 44fa5f0 to 073e2c6 Compare June 21, 2025 10:30

bjorn3 reviewed Jun 21, 2025

View reviewed changes

compiler/rustc_attr_data_structures/src/attributes.rs Outdated Show resolved Hide resolved

JonathanBrouwer force-pushed the used_new_parser branch from 073e2c6 to 468dd68 Compare June 21, 2025 11:41

jdonszelmann mentioned this pull request Jun 21, 2025

Warn or error on duplicate attributes #142836

Open

JonathanBrouwer force-pushed the used_new_parser branch from 468dd68 to 674be35 Compare June 22, 2025 10:46

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2025

JonathanBrouwer force-pushed the used_new_parser branch 2 times, most recently from e70cbef to 30d851d Compare June 22, 2025 13:02

JonathanBrouwer force-pushed the used_new_parser branch 2 times, most recently from be02b70 to 0031aab Compare June 23, 2025 16:10

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 26, 2025

JonathanBrouwer force-pushed the used_new_parser branch from 708f45f to 9b3f729 Compare June 26, 2025 08:38

compiler-errors mentioned this pull request Jun 26, 2025

Rollup of 19 pull requests #143061

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2025

Port #[used] to new attribute parsing infrastructure

9e35684

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer force-pushed the used_new_parser branch from 9b3f729 to 9e35684 Compare June 27, 2025 06:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2025

GuillaumeGomez mentioned this pull request Jun 27, 2025

Rollup of 6 pull requests #143081

Closed

GuillaumeGomez mentioned this pull request Jun 27, 2025

Rollup of 10 pull requests #143091

Merged

bors merged commit 3c3a174 into rust-lang:master Jun 27, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 27, 2025

dtolnay mentioned this pull request Oct 2, 2025

Regression in nightly-2025-06-28: rustdoc --test -Zcrate-attr=feature(used_with_arg) #147276

Closed

Uh oh!

Conversation

JonathanBrouwer commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

bors commented Jun 21, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

jdonszelmann commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 24, 2025

Uh oh!

JonathanBrouwer commented Jun 26, 2025

Uh oh!

jdonszelmann commented Jun 26, 2025

Uh oh!

jdonszelmann commented Jun 26, 2025

Uh oh!

jdonszelmann commented Jun 26, 2025

Uh oh!

bors commented Jun 26, 2025

Uh oh!

jdonszelmann commented Jun 26, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

JonathanBrouwer commented Jun 27, 2025

Uh oh!

jdonszelmann commented Jun 27, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jdonszelmann commented Jun 23, 2025 •

edited

Loading