Port `#[no_mangle]` to new attribute parsing infrastructure by JonathanBrouwer · Pull Request #142823 · rust-lang/rust

JonathanBrouwer · 2025-06-21T11:46:01Z

Ports no_mangle to the new attribute parsing infrastructure for #131229 (comment)

r? @jdonszelmann

rustbot · 2025-06-21T11:46:06Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-06-21T11:46:08Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

tests/ui/lint/unused/unused-attr-duplicate.stderr

JonathanBrouwer · 2025-06-21T12:12:41Z

Woops I accidentally rebased on the wrong commit and git did not like that, should be good now :P

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

jdonszelmann · 2025-06-21T13:07:47Z

r=me after that and ci

jdonszelmann · 2025-06-21T13:08:08Z

@rustbot author

rustbot · 2025-06-21T13:08:12Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2025-06-21T13:57:55Z

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

It's intentional.
The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

bors · 2025-06-21T18:51:19Z

☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts.

JonathanBrouwer · 2025-06-22T10:19:39Z

@rustbot ready
Rebased on latest master, reverted the change to the warning until #142836 is decided, and made rustdocs output no_mangle correctly in the json repr

jdonszelmann

@bors r+ rollup

JonathanBrouwer · 2025-06-22T12:57:03Z

Rebased to solve merge conflicts

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer · 2025-06-22T20:17:23Z

Rebased to solve merge conflicts

jdonszelmann · 2025-06-22T20:18:04Z

@bors r+ rollup

bors · 2025-06-22T20:18:06Z

📌 Commit 2084831 has been approved by jdonszelmann

It is now in the queue for this repository.

…r=jdonszelmann Port `#[no_mangle]` to new attribute parsing infrastructure Ports `no_mangle` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

Rollup of 6 pull requests Successful merges: - #140136 (Add an aarch64-msvc build running on ARM64 Windows) - #141597 (Document subdirectories of UI tests with README files) - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure) - #142828 (1.88.0 release notes) - #142854 (centralize `-Zmin-function-alignment` logic) - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 5 pull requests Successful merges: - #141597 (Document subdirectories of UI tests with README files) - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure) - #142828 (1.88.0 release notes) - #142854 (centralize `-Zmin-function-alignment` logic) - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142823 - JonathanBrouwer:no_mangle_parser, r=jdonszelmann Port `#[no_mangle]` to new attribute parsing infrastructure Ports `no_mangle` to the new attribute parsing infrastructure for #131229 (comment) r? ``@jdonszelmann``

src/rustdoc-json-types/lib.rs

src/librustdoc/clean/types.rs

…t, r=jdonszelmann Fix comment on NoMangle Fix comment on NoMangle. This was discussed in comments of rust-lang#142823 (comment) and rust-lang#142921

Rollup merge of #142922 - JonathanBrouwer:fix-rustdoc-comment, r=jdonszelmann Fix comment on NoMangle Fix comment on NoMangle. This was discussed in comments of #142823 (comment) and #142921

Rollup of 5 pull requests Successful merges: - rust-lang/rust#141597 (Document subdirectories of UI tests with README files) - rust-lang/rust#142823 (Port `#[no_mangle]` to new attribute parsing infrastructure) - rust-lang/rust#142828 (1.88.0 release notes) - rust-lang/rust#142854 (centralize `-Zmin-function-alignment` logic) - rust-lang/rust#142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jdonszelmann Jun 21, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025

JonathanBrouwer commented Jun 21, 2025

View reviewed changes

tests/ui/lint/unused/unused-attr-duplicate.stderr Outdated Show resolved Hide resolved

jdonszelmann mentioned this pull request Jun 21, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the no_mangle_parser branch from 1735b54 to db15940 Compare June 21, 2025 12:01

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2025

JonathanBrouwer closed this Jun 21, 2025

JonathanBrouwer force-pushed the no_mangle_parser branch from db15940 to df4ad9e Compare June 21, 2025 12:02

rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jun 21, 2025

JonathanBrouwer reopened this Jun 21, 2025

This comment has been minimized.

Sign in to view

jdonszelmann reviewed Jun 21, 2025

View reviewed changes

compiler/rustc_codegen_ssa/src/codegen_attrs.rs Outdated Show resolved Hide resolved

jdonszelmann reviewed Jun 21, 2025

View reviewed changes

compiler/rustc_codegen_ssa/src/codegen_attrs.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2025

JonathanBrouwer force-pushed the no_mangle_parser branch from ed3740a to ae3ece2 Compare June 21, 2025 13:57

rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Jun 21, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 21, 2025

JonathanBrouwer force-pushed the no_mangle_parser branch from 628e1ee to f54545e Compare June 22, 2025 10:15

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2025

jdonszelmann approved these changes Jun 22, 2025

View reviewed changes

JonathanBrouwer force-pushed the no_mangle_parser branch from f54545e to d7a5d0a Compare June 22, 2025 12:56

Port #[no_mangle] to new attribute parsing infrastructure

2084831

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer force-pushed the no_mangle_parser branch from d7a5d0a to 2084831 Compare June 22, 2025 20:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025

jhpratt mentioned this pull request Jun 22, 2025

Rollup of 6 pull requests #142895

Closed

matthiaskrgr mentioned this pull request Jun 23, 2025

Rollup of 5 pull requests #142901

Merged

bors merged commit 9b6665f into rust-lang:master Jun 23, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 23, 2025

aDotInTheVoid mentioned this pull request Jun 23, 2025

Missing format version 49 - 53 rust-lang/rustdoc-types#50

Closed

aDotInTheVoid reviewed Jun 23, 2025

View reviewed changes

src/rustdoc-json-types/lib.rs Show resolved Hide resolved

src/librustdoc/clean/types.rs Show resolved Hide resolved

JonathanBrouwer mentioned this pull request Jun 23, 2025

Fix comment on NoMangle #142922

Merged

Uh oh!

Conversation

JonathanBrouwer commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

JonathanBrouwer commented Jun 21, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

jdonszelmann commented Jun 21, 2025

Uh oh!

jdonszelmann commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

rustbot commented Jun 21, 2025

Uh oh!

bors commented Jun 21, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

jdonszelmann left a comment

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

JonathanBrouwer commented Jun 22, 2025

Uh oh!

jdonszelmann commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants