rustdoc-json: Add test for #[cold]#142919
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 24, 2025
Merged
Conversation
Collaborator
|
These commits modify Please ensure that if you've changed the output:
|
This comment has been minimized.
This comment has been minimized.
ea147eb to
98fce25
Compare
| @@ -0,0 +1,3 @@ | |||
| //@ is "$.index[?(@.name=='cold_fn')].attrs" '["#[attr = Cold]"]' | |||
Member
There was a problem hiding this comment.
Is it normal that Cold is capitalized?
Member
Author
There was a problem hiding this comment.
Yeah, because it's an enum variant. Same reason as #142916 (comment)
GuillaumeGomez
approved these changes
Jun 24, 2025
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added a commit
that referenced
this pull request
Jun 24, 2025
Rollup of 7 pull requests Successful merges: - #137268 (Allow comparisons between `CStr`, `CString`, and `Cow<CStr>`.) - #142704 (Remove the deprecated unstable `concat_idents!` macro) - #142742 ([win][aarch64] Fix linking statics on Arm64EC, take 2) - #142843 (Enable reproducible-build-2 for Windows MSVC) - #142916 (rustdoc-json: Add test for `#[optimize(..)]`) - #142919 (rustdoc-json: Add test for `#[cold]`) - #142944 (Stats output tweaks) Failed merges: - #142825 (Port `#[track_caller]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #142491
r? @GuillaumeGomez
CC @jdonszelmann