Port `#[rustc_layout_scalar_valid_range_start/end]` to the new attrib… by JonathanBrouwer · Pull Request #142921 · rust-lang/rust

JonathanBrouwer · 2025-06-23T18:01:15Z

Ports rustc_layout_scalar_valid_range_start and rustc_layout_scalar_valid_range_end to the new attribute parsing infrastructure for #131229 (comment)

r? @jdonszelmann

rustbot · 2025-06-23T18:01:20Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-06-23T18:01:22Z

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

tests/ui/stats/input-stats.stderr

tests/ui/parser/bad-lit-suffixes.rs

src/librustdoc/clean/types.rs

…t, r=jdonszelmann Fix comment on NoMangle Fix comment on NoMangle. This was discussed in comments of rust-lang#142823 (comment) and rust-lang#142921

aDotInTheVoid · 2025-06-23T21:35:26Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-23T21:35:29Z

⌛ Trying commit 49398cf with merge 600a41a…

To cancel the try build, run the command @bors2 try cancel.

Port `#[rustc_layout_scalar_valid_range_start/end]` to the new attrib… Ports `rustc_layout_scalar_valid_range_start` and `rustc_layout_scalar_valid_range_end` to the new attribute parsing infrastructure for #131229 (comment) r? `@jdonszelmann`

rust-bors · 2025-06-24T00:05:49Z

☀️ Try build successful (CI)
Build commit: 600a41a (600a41ac6ff1ea3a01ebd1fc0715b567826018f6, parent: 706f244db581212cabf2e619e0113d70999b2bbe)

Rollup merge of #142922 - JonathanBrouwer:fix-rustdoc-comment, r=jdonszelmann Fix comment on NoMangle Fix comment on NoMangle. This was discussed in comments of #142823 (comment) and #142921

rust-timer · 2025-06-24T07:56:51Z

Finished benchmarking commit (600a41a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.3%, 3.0%]	2
Regressions ❌ (secondary)	0.2%	[0.1%, 0.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	1.7%	[0.3%, 3.0%]	2

Max RSS (memory usage)

Results (primary 1.5%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.3%, 1.8%]	2
Regressions ❌ (secondary)	4.0%	[2.7%, 5.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.8%, -2.6%]	2
All ❌✅ (primary)	1.5%	[1.3%, 1.8%]	2

Cycles

Results (primary 0.7%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-2.4%	[-2.8%, -1.5%]	5
All ❌✅ (primary)	0.7%	[-1.4%, 2.7%]	2

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 688.989s -> 689.147s (0.02%)
Artifact size: 371.96 MiB -> 372.00 MiB (0.01%)

JonathanBrouwer · 2025-06-24T08:33:50Z

^ I've boxed the u128, since there seems to be a performance regression.
Let's see if I have permission to undo the changes made by rust-timer
@bors rollup=always (since it should no longer be perf-sensitive)
@rustbot label: -perf-regression

bors · 2025-06-24T08:33:54Z

@JonathanBrouwer: 🔑 Insufficient privileges: not in try users

jdonszelmann · 2025-06-24T12:00:38Z

No let's not rollup always, still want to see the final results

rustbot · 2025-06-24T22:28:00Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer · 2025-06-25T07:45:14Z

^ Rebased & replied to your comment
@rustbot ready

bors · 2025-06-27T04:59:29Z

☔ The latest upstream changes (presumably #143074) made this pull request unmergeable. Please resolve the merge conflicts.

…ute parsing infrastructure Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer · 2025-06-28T14:23:50Z

r? @oli-obk

oli-obk · 2025-06-30T13:18:59Z

@bors r+

bors · 2025-06-30T13:19:01Z

📌 Commit f98ea3d has been approved by oli-obk

It is now in the queue for this repository.

bors · 2025-07-01T08:33:05Z

⌛ Testing commit f98ea3d with merge 86e05cd...

bors · 2025-07-01T11:51:50Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 86e05cd to master...

github-actions · 2025-07-01T11:55:04Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f46ce66 (parent) -> 86e05cd (this PR)

Test differences

Show 221 test diffs

Stage 1

errors::verify_passes_abi_ne_123: [missing] -> pass (J0)
errors::verify_passes_abi_ne_124: pass -> [missing] (J0)
errors::verify_passes_align_should_be_repr_align_176: pass -> [missing] (J0)
errors::verify_passes_allow_internal_unstable_79: [missing] -> pass (J0)
errors::verify_passes_allow_internal_unstable_80: pass -> [missing] (J0)
errors::verify_passes_attr_application_enum_137: [missing] -> pass (J0)
errors::verify_passes_attr_application_enum_138: pass -> [missing] (J0)
errors::verify_passes_attr_application_struct_union_140: pass -> [missing] (J0)
errors::verify_passes_cannot_stabilize_deprecated_145: pass -> [missing] (J0)
errors::verify_passes_confusables_89: [missing] -> pass (J0)
errors::verify_passes_confusables_90: pass -> [missing] (J0)
errors::verify_passes_const_stable_not_stable_154: [missing] -> pass (J0)
errors::verify_passes_const_stable_not_stable_155: pass -> [missing] (J0)
errors::verify_passes_coroutine_on_non_closure_90: [missing] -> pass (J0)
errors::verify_passes_debug_visualizer_invalid_82: pass -> [missing] (J0)
errors::verify_passes_debug_visualizer_unreadable_82: [missing] -> pass (J0)
errors::verify_passes_debug_visualizer_unreadable_83: pass -> [missing] (J0)
errors::verify_passes_deprecated_93: [missing] -> pass (J0)
errors::verify_passes_deprecated_attribute_142: [missing] -> pass (J0)
errors::verify_passes_deprecated_attribute_143: pass -> [missing] (J0)
errors::verify_passes_duplicate_diagnostic_item_in_crate_116: pass -> [missing] (J0)
errors::verify_passes_duplicate_feature_err_153: pass -> [missing] (J0)
errors::verify_passes_extern_main_130: [missing] -> pass (J0)
errors::verify_passes_extern_main_131: pass -> [missing] (J0)
errors::verify_passes_inline_ignored_for_exported_135: [missing] -> pass (J0)
errors::verify_passes_invalid_macro_export_arguments_too_many_items_98: [missing] -> pass (J0)
errors::verify_passes_invalid_macro_export_arguments_too_many_items_99: pass -> [missing] (J0)
errors::verify_passes_lang_item_fn_with_track_caller_111: [missing] -> pass (J0)
errors::verify_passes_lang_item_fn_with_track_caller_112: pass -> [missing] (J0)
errors::verify_passes_lang_item_on_incorrect_target_113: [missing] -> pass (J0)
errors::verify_passes_layout_align_117: [missing] -> pass (J0)
errors::verify_passes_layout_align_118: pass -> [missing] (J0)
errors::verify_passes_layout_homogeneous_aggregate_119: [missing] -> pass (J0)
errors::verify_passes_layout_invalid_attribute_121: [missing] -> pass (J0)
errors::verify_passes_layout_invalid_attribute_122: pass -> [missing] (J0)
errors::verify_passes_layout_of_120: [missing] -> pass (J0)
errors::verify_passes_layout_of_121: pass -> [missing] (J0)
errors::verify_passes_link_ordinal_89: pass -> [missing] (J0)
errors::verify_passes_linkage_91: [missing] -> pass (J0)
errors::verify_passes_linkage_92: pass -> [missing] (J0)
errors::verify_passes_macro_export_95: [missing] -> pass (J0)
errors::verify_passes_macro_export_on_decl_macro_96: [missing] -> pass (J0)
errors::verify_passes_macro_use_94: [missing] -> pass (J0)
errors::verify_passes_macro_use_95: pass -> [missing] (J0)
errors::verify_passes_missing_const_err_153: [missing] -> pass (J0)
errors::verify_passes_missing_const_err_154: pass -> [missing] (J0)
errors::verify_passes_missing_const_stab_attr_147: [missing] -> pass (J0)
errors::verify_passes_missing_lang_item_110: [missing] -> pass (J0)
errors::verify_passes_missing_lang_item_111: pass -> [missing] (J0)
errors::verify_passes_missing_panic_handler_108: [missing] -> pass (J0)
errors::verify_passes_no_mangle_74: [missing] -> pass (J0)
errors::verify_passes_no_mangle_foreign_74: pass -> [missing] (J0)
errors::verify_passes_no_sanitize_164: [missing] -> pass (J0)
errors::verify_passes_object_lifetime_err_137: pass -> [missing] (J0)
errors::verify_passes_panic_unwind_without_std_109: [missing] -> pass (J0)
errors::verify_passes_proc_macro_bad_sig_155: [missing] -> pass (J0)
errors::verify_passes_repr_conflicting_76: pass -> [missing] (J0)
errors::verify_passes_rustc_allow_const_fn_unstable_84: pass -> [missing] (J0)
errors::verify_passes_rustc_const_stable_indirect_pairing_166: pass -> [missing] (J0)
errors::verify_passes_rustc_dirty_clean_71: [missing] -> pass (J0)
errors::verify_passes_rustc_dirty_clean_72: pass -> [missing] (J0)
errors::verify_passes_rustc_force_inline_87: pass -> [missing] (J0)
errors::verify_passes_rustc_force_inline_coro_88: pass -> [missing] (J0)
errors::verify_passes_rustc_layout_scalar_valid_range_arg_67: pass -> [missing] (J0)
errors::verify_passes_rustc_legacy_const_generics_index_exceed_69: [missing] -> pass (J0)
errors::verify_passes_rustc_legacy_const_generics_only_67: [missing] -> pass (J0)
errors::verify_passes_rustc_legacy_const_generics_only_68: pass -> [missing] (J0)
errors::verify_passes_rustc_lint_opt_deny_field_access_105: pass -> [missing] (J0)
errors::verify_passes_rustc_lint_opt_ty_103: [missing] -> pass (J0)
errors::verify_passes_rustc_pub_transparent_86: pass -> [missing] (J0)
errors::verify_passes_rustc_std_internal_symbol_84: [missing] -> pass (J0)
errors::verify_passes_stability_promotable_92: [missing] -> pass (J0)
errors::verify_passes_trait_impl_const_stable_149: pass -> [missing] (J0)
errors::verify_passes_transparent_incompatible_141: [missing] -> pass (J0)
errors::verify_passes_transparent_incompatible_142: pass -> [missing] (J0)
errors::verify_passes_unexportable_adt_with_private_fields_173: [missing] -> pass (J0)
errors::verify_passes_unexportable_fn_abi_169: [missing] -> pass (J0)
errors::verify_passes_unexportable_priv_item_172: [missing] -> pass (J0)
errors::verify_passes_unknown_feature_150: pass -> [missing] (J0)
errors::verify_passes_unknown_feature_alias_150: [missing] -> pass (J0)
errors::verify_passes_unknown_feature_alias_151: pass -> [missing] (J0)
errors::verify_passes_unknown_lang_item_115: pass -> [missing] (J0)
errors::verify_passes_unnecessary_partial_stable_feature_161: [missing] -> pass (J0)
errors::verify_passes_unnecessary_partial_stable_feature_162: pass -> [missing] (J0)
errors::verify_passes_unnecessary_stable_feature_161: pass -> [missing] (J0)
errors::verify_passes_unreachable_due_to_uninhabited_156: [missing] -> pass (J0)
errors::verify_passes_unreachable_due_to_uninhabited_157: pass -> [missing] (J0)
errors::verify_passes_unstable_attr_for_already_stable_feature_146: pass -> [missing] (J0)
errors::verify_passes_unsupported_attributes_in_where_166: [missing] -> pass (J0)
errors::verify_passes_unused_assign_passed_164: pass -> [missing] (J0)
errors::verify_passes_unused_capture_maybe_capture_ref_159: pass -> [missing] (J0)
errors::verify_passes_unused_duplicate_101: [missing] -> pass (J0)
errors::verify_passes_unused_duplicate_102: pass -> [missing] (J0)
errors::verify_passes_unused_multiple_103: pass -> [missing] (J0)
errors::verify_passes_unused_var_assigned_only_160: pass -> [missing] (J0)
errors::verify_passes_unused_var_maybe_capture_ref_157: [missing] -> pass (J0)
errors::verify_passes_unused_var_maybe_capture_ref_158: pass -> [missing] (J0)
errors::verify_passes_used_static_79: pass -> [missing] (J0)
errors::verify_passes_useless_assignment_133: [missing] -> pass (J0)
errors::verify_passes_useless_stability_144: pass -> [missing] (J0)

(and 119 additional test diffs)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 86e05cd300fac9e83e812c4d46582b48db780d8f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8076.2s -> 11094.0s (37.4%)
dist-aarch64-apple: 4811.9s -> 5785.4s (20.2%)
dist-x86_64-netbsd: 4537.3s -> 5153.8s (13.6%)
x86_64-gnu-aux: 6320.4s -> 6832.5s (8.1%)
x86_64-gnu-llvm-20-2: 5859.4s -> 5442.5s (-7.1%)
mingw-check-tidy: 81.5s -> 76.0s (-6.7%)
x86_64-apple-2: 4255.5s -> 4540.7s (6.7%)
x86_64-apple-1: 7582.6s -> 7082.3s (-6.6%)
aarch64-gnu: 6475.0s -> 6880.9s (6.3%)
dist-loongarch64-linux: 5917.3s -> 6286.7s (6.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-01T13:40:51Z

Finished benchmarking commit (86e05cd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.8%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.5%	[3.5%, 3.5%]	1
Regressions ❌ (secondary)	5.4%	[5.4%, 5.4%]	1
Improvements ✅ (primary)	-2.9%	[-3.4%, -2.3%]	2
Improvements ✅ (secondary)	-2.0%	[-3.0%, -0.8%]	3
All ❌✅ (primary)	-0.8%	[-3.4%, 3.5%]	3

Cycles

Results (primary 2.1%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[1.4%, 2.8%]	14
Regressions ❌ (secondary)	2.4%	[1.1%, 4.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-6.5%, -2.5%]	4
All ❌✅ (primary)	2.1%	[1.4%, 2.8%]	14

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 461.485s -> 460.931s (-0.12%)
Artifact size: 372.20 MiB -> 372.21 MiB (0.00%)

rustbot assigned jdonszelmann Jun 23, 2025

JonathanBrouwer force-pushed the rustc_attributes_parser branch from 46ea3f1 to 9102b14 Compare June 23, 2025 18:02

JonathanBrouwer commented Jun 23, 2025

View reviewed changes

tests/ui/stats/input-stats.stderr Outdated Show resolved Hide resolved

tests/ui/parser/bad-lit-suffixes.rs Show resolved Hide resolved

aDotInTheVoid reviewed Jun 23, 2025

View reviewed changes

src/librustdoc/clean/types.rs Outdated Show resolved Hide resolved

JonathanBrouwer force-pushed the rustc_attributes_parser branch from 9102b14 to 49398cf Compare June 23, 2025 18:23

JonathanBrouwer mentioned this pull request Jun 23, 2025

Fix comment on NoMangle #142922

Merged

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 23, 2025

jdonszelmann mentioned this pull request Jun 23, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 24, 2025

JonathanBrouwer force-pushed the rustc_attributes_parser branch from 49398cf to 37abd08 Compare June 24, 2025 08:33

rustbot removed the perf-regression Performance regression. label Jun 24, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 24, 2025

JonathanBrouwer force-pushed the rustc_attributes_parser branch from e6396e3 to d5586dc Compare June 25, 2025 07:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2025

workingjubilee added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 25, 2025

JonathanBrouwer force-pushed the rustc_attributes_parser branch from d5586dc to 498aa7b Compare June 26, 2025 08:48

Port #[rustc_layout_scalar_valid_range_start/end] to the new attrib…

f98ea3d

…ute parsing infrastructure Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer force-pushed the rustc_attributes_parser branch from 498aa7b to f98ea3d Compare June 27, 2025 07:08

rustbot assigned oli-obk and unassigned jdonszelmann Jun 28, 2025

oli-obk approved these changes Jun 30, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2025

bors merged commit 86e05cd into rust-lang:master Jul 1, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 1, 2025

This was referenced Jul 1, 2025

Implement RFC 3631: add rustdoc doc_cfg features #138907

Merged

Improve testing and error messages for malformed attributes #143181

Merged

Port #[rustc_object_lifetime_default] to the new attribute parsing … #143240

Merged

Uh oh!

Conversation

JonathanBrouwer commented Jun 23, 2025

Uh oh!

rustbot commented Jun 23, 2025

Uh oh!

rustbot commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aDotInTheVoid commented Jun 23, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 23, 2025

Uh oh!

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 24, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

JonathanBrouwer commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jun 24, 2025

Uh oh!

jdonszelmann commented Jun 24, 2025

Uh oh!

rustbot commented Jun 24, 2025

Uh oh!

JonathanBrouwer commented Jun 25, 2025

Uh oh!

bors commented Jun 27, 2025

Uh oh!

JonathanBrouwer commented Jun 28, 2025

Uh oh!

oli-obk commented Jun 30, 2025

Uh oh!

bors commented Jun 30, 2025

Uh oh!

bors commented Jul 1, 2025

Uh oh!

bors commented Jul 1, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Test differences

Stage 1

Job duration changes

Uh oh!

rust-timer commented Jul 1, 2025

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

JonathanBrouwer commented Jun 24, 2025 •

edited

Loading