Rewrite .gitattributes CRLF ui tests into run-make tests#142925
Rewrite .gitattributes CRLF ui tests into run-make tests#142925Oneirical wants to merge 1 commit intorust-lang:masterfrom
.gitattributes CRLF ui tests into run-make tests#142925Conversation
|
|
4b34c01 to
1475a51
Compare
This comment has been minimized.
This comment has been minimized.
1475a51 to
580b27c
Compare
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
580b27c to
12e1f3d
Compare
|
@rustbot ready |
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks, I do find having the BOM and \r\n immediately visible and possible to edit to be an important property.
|
@bors r+ rollup |
…r=jieyouxu Rewrite `.gitattributes` CRLF ui tests into run-make tests These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be `\r\n`. (Except for `trailing-carriage-return-in-string`, which only has SOME CRLF) In the run-make suite, the test is instead automatically generated with `\r\n` clearly visible, making fixes easier. Closes rust-lang#140033 Closes rust-lang#139968 r? `@jieyouxu`
Rollup of 17 pull requests Successful merges: - #124595 (Suggest cloning `Arc` moved into closure) - #139594 (Simplify `ObligationCauseCode::IfExpression`) - #141311 (make `tidy-alphabetical` use a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion) - #142255 (Add edition checks for some tests that had divergent output) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142884 (StableMIR: Add method to retrieve body of coroutine) - #142925 (Rewrite `.gitattributes` CRLF ui tests into run-make tests) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143020 (codegen_fn_attrs: make comment more precise) - #143033 (Expand const-stabilized API links in relnotes) r? `@ghost` `@rustbot` modify labels: rollup
|
guess who needs to run this on dist-various-1 and probably a few windows platforms @bors r- |
Rewrite `.gitattributes` CRLF ui tests into run-make tests These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be `\r\n`. (Except for `trailing-carriage-return-in-string`, which only has SOME CRLF) In the run-make suite, the test is instead automatically generated with `\r\n` clearly visible, making fixes easier. Closes #140033 Closes #139968 r? `@jieyouxu` try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1
|
💔 Test failed
|
d699e0e to
bea3e83
Compare
|
@bors2 try |
Rewrite `.gitattributes` CRLF ui tests into run-make tests These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be `\r\n`. (Except for `trailing-carriage-return-in-string`, which only has SOME CRLF) In the run-make suite, the test is instead automatically generated with `\r\n` clearly visible, making fixes easier. Closes #140033 Closes #139968 r? `@jieyouxu` try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1
|
💔 Test failed
|
bea3e83 to
8d1937b
Compare
|
@bors2 try |
Rewrite `.gitattributes` CRLF ui tests into run-make tests These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be `\r\n`. (Except for `trailing-carriage-return-in-string`, which only has SOME CRLF) In the run-make suite, the test is instead automatically generated with `\r\n` clearly visible, making fixes easier. Closes #140033 Closes #139968 r? `@jieyouxu` try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed
|
8d1937b to
fcb37ee
Compare
This comment has been minimized.
This comment has been minimized.
fcb37ee to
08b07cc
Compare
|
The run-make-support library was changed cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
08b07cc to
593e780
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Okay, I looked at these tests a bit more. It seems like because of how much normalizations are needed, the proposed "cure" (that I thought of) of using Thanks for taking a stab -- knowing what doesn't work is very valuable implementation experience. |
These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be
\r\n. (Except fortrailing-carriage-return-in-string, which only has SOME CRLF)In the run-make suite, the test is instead automatically generated with
\r\nclearly visible, making fixes easier.Closes #140033
Closes #139968
r? @jieyouxu
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1