Port `#[export_name]` to the new attribute parsing infrastructure by JonathanBrouwer · Pull Request #142986 · rust-lang/rust

JonathanBrouwer · 2025-06-24T21:08:10Z

This PR contains two changes, in separate commits for reviewability:

Ports export_name to the new attribute parsing infrastructure for Tracking issue: Attribute refactor #131229 (comment)
Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax

r? @jdonszelmann

rustbot · 2025-06-24T21:08:14Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-06-24T21:08:17Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

jdonszelmann

I'll sequence this after #142825 which likely needs a rebase anyway. I like the impl, just some minor things.

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

JonathanBrouwer · 2025-06-25T08:01:18Z

^ Rebased & fixed feedback
@rustbot ready

jdonszelmann · 2025-06-25T10:47:51Z

@bors r+ rollup

bors · 2025-06-25T10:47:54Z

📌 Commit 85108ca has been approved by jdonszelmann

It is now in the queue for this repository.

…, r=jdonszelmann Port `#[export_name]` to the new attribute parsing infrastructure This PR contains two changes, in separate commits for reviewability: - Ports `export_name` to the new attribute parsing infrastructure for rust-lang#131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax r? `@jdonszelmann`

compiler/rustc_passes/src/check_attr.rs

jdonszelmann · 2025-06-25T21:47:51Z

@bors r-

JonathanBrouwer · 2025-06-26T06:41:00Z

^ Fixed the comment above
@rustbot ready

jdonszelmann · 2025-06-26T06:46:29Z

Will likely fail ci after the merges from yesterday fyi

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

…he error Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer · 2025-06-26T06:56:12Z

Well predicted :P
^ I think that should fix it? Haven't ran the test suite locally because my laptop is a bit underpowered, really miss my desktop at home when I'm in the train

I'll fix the other PRs in a bit

jdonszelmann · 2025-06-26T08:18:49Z

@bors r+

bors · 2025-06-26T08:18:53Z

📌 Commit 3d1cee5 has been approved by jdonszelmann

It is now in the queue for this repository.

…rors Rollup of 18 pull requests Successful merges: - #137843 (make RefCell unstably const) - #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142927 (Add note to `find_const_ty_from_env`) - #142967 (Fix RwLock::try_write documentation for WouldBlock condition) - #142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143033 (Expand const-stabilized API links in relnotes) - #143041 (Remove cache for citool) - #143056 (Move an ACE test out of the GCI directory) - #143059 (Fix 1.88 relnotes) - #143067 (Tracking issue number for `iter_macro`) - #143073 (Fix some fixmes that were waiting for let chains) Failed merges: - #143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142986 - JonathanBrouwer:export_name_parser, r=jdonszelmann Port `#[export_name]` to the new attribute parsing infrastructure This PR contains two changes, in separate commits for reviewability: - Ports `export_name` to the new attribute parsing infrastructure for #131229 (comment) - Moves the check for mixing export_name/no_mangle to check_attr.rs and improve the error message, which previously had a mix of 2021/2024 edition syntax r? ``@jdonszelmann``

…mpiler-errors Rollup of 18 pull requests Successful merges: - rust-lang#137843 (make RefCell unstably const) - rust-lang#140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - rust-lang#142549 (small iter.intersperse.fold() optimization) - rust-lang#142637 (Remove some glob imports from the type system) - rust-lang#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - rust-lang#142700 (Remove incorrect comments in `Weak`) - rust-lang#142927 (Add note to `find_const_ty_from_env`) - rust-lang#142967 (Fix RwLock::try_write documentation for WouldBlock condition) - rust-lang#142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - rust-lang#143001 (Rename run always ) - rust-lang#143010 (Update `browser-ui-test` version to `0.20.7`) - rust-lang#143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - rust-lang#143033 (Expand const-stabilized API links in relnotes) - rust-lang#143041 (Remove cache for citool) - rust-lang#143056 (Move an ACE test out of the GCI directory) - rust-lang#143059 (Fix 1.88 relnotes) - rust-lang#143067 (Tracking issue number for `iter_macro`) - rust-lang#143073 (Fix some fixmes that were waiting for let chains) Failed merges: - rust-lang#143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jdonszelmann Jun 24, 2025

jdonszelmann mentioned this pull request Jun 24, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann requested changes Jun 24, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs Show resolved Hide resolved

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs Show resolved Hide resolved

compiler/rustc_codegen_ssa/src/codegen_attrs.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2025

JonathanBrouwer force-pushed the export_name_parser branch from 83731a6 to 85108ca Compare June 25, 2025 08:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 25, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025

matthiaskrgr mentioned this pull request Jun 25, 2025

Rollup of 8 pull requests #143012

Closed

Urgau reviewed Jun 25, 2025

View reviewed changes

compiler/rustc_passes/src/check_attr.rs Outdated Show resolved Hide resolved

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 25, 2025

JonathanBrouwer force-pushed the export_name_parser branch from 85108ca to 8d80099 Compare June 26, 2025 06:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2025

This comment has been minimized.

Sign in to view

JonathanBrouwer added 2 commits June 26, 2025 08:50

Port #[export_name] to the new attribute parsing infrastructure

287d9af

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Move mixed export_name/no_mangle check to check_attr.rs and improve t…

3d1cee5

…he error Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer force-pushed the export_name_parser branch from 8d80099 to 3d1cee5 Compare June 26, 2025 06:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2025

This was referenced Jun 26, 2025

Rollup of 19 pull requests #143061

Closed

Rollup of 18 pull requests #143074

Merged

bors merged commit d386600 into rust-lang:master Jun 27, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 27, 2025

Uh oh!

Conversation

JonathanBrouwer commented Jun 24, 2025

Uh oh!

rustbot commented Jun 24, 2025

Uh oh!

rustbot commented Jun 24, 2025

Uh oh!

jdonszelmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 25, 2025

Uh oh!

jdonszelmann commented Jun 25, 2025

Uh oh!

bors commented Jun 25, 2025

Uh oh!

Uh oh!

jdonszelmann commented Jun 25, 2025

Uh oh!

JonathanBrouwer commented Jun 26, 2025

Uh oh!

jdonszelmann commented Jun 26, 2025

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Jun 26, 2025

Uh oh!

bors commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JonathanBrouwer commented Jun 26, 2025 •

edited

Loading