Improve diagnostic for link.exe special case exit code 0xc0000409 (STATUS_STACK_BUFFER_OVERRUN)

[vangata-ve]

Fixes #141757.

Adds note for when link.exe exits with code 0xc0000409

[rustbot]

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

[jieyouxu]

This might be challenging, but, is it possible to have a ui test for this diagnostic?

[vangata-ve]

I'll see what I can do

[vangata-ve]

Holy! I accidentally misclicked. I should've commited the ui tests not this. I'll fix it when I get home

[vangata-ve]

So, I had the idea to build a dummy linker (via aux-bin) that always simulates a __fastfail termination, and pass it to -Clinker using the compiler-flags directive. The problem is that the relevant note only gets emitted when is_msvc_link_exe is true (link to source), which the dummy linker doesn't satisfy.

One option is to move the note outside the is_msvc_link_exe check, so it shows up regardless of whether the toolchain is MSVC or not. That way the testcase works and passes correctly.

[compiler-errors]

Please squash this into one commit.

Also, maybe worth to get the review of someone who knows a bit more about windows...

r? @ChrisDenton

[compiler-errors]

@rustbot author

for squashing into one commit

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[ChrisDenton]

LGTM but it seems we have two PRs for the same issue. See also #141828.

[rustbot]

⚠️ Warning ⚠️

• This PR is based on an upstream commit that is 19 days old.

  It's recommended to update your branch according to the rustc-dev-guide.

[vangata-ve]

Yep. It turns out theres a second issue report with a fix PR that duplicates the one I addressed in my PR. Also I squashed the commits.

[vangata-ve]

@rustbot ready

[vangata-ve]

Closing since #141828 got merged.