Rollup of 11 pull requests by matthiaskrgr · Pull Request #143173 · rust-lang/rust

matthiaskrgr · 2025-06-29T04:59:33Z

Successful merges:

Doc: clarify priority of lint level sources #142021 (Doc: clarify priority of lint level sources)
Add regression test for #137857 to ensure that we generate intra doc links for extern crate items. #142367 (Add regression test for Rust docs: Crate root link points to "folder" and not index page #137857 to ensure that we generate intra doc links for extern crate items.)
Generate symbols.o for proc-macros too #142641 (Generate symbols.o for proc-macros too)
Clarify doc comment on unix OpenOptions #142889 (Clarify doc comment on unix OpenOptions)
explain ImportData::imported_module #143063 (explain ImportData::imported_module)
Improve documentation of TagEncoding #143088 (Improve documentation of TagEncoding)
fix typos on some doc comments #143135 (fix typos on some doc comments)
Port #[link_name] to the new attribute parsing infrastructure #143138 (Port #[link_name] to the new attribute parsing infrastructure)
librustdoc house-keeping 🧹 #143155 (librustdoc house-keeping 🧹)
Remove unused feature gates #143169 (Remove unused feature gates)
Fix the span of trait bound modifier [const] #143171 (Fix the span of trait bound modifier [const])

r? @ghost
@rustbot modify labels: rollup

This updates the rustc book to clearly document how conflicting lint configurations are resolved across different sources, including command-line flags, crate-level attributes, in-line attributes, and `--cap-lints`. It also explains the special behavior of `forbid` and `force_warn`.

To ensure used statics are functioning correctly for proc-macros too.

…ntra doc links for extern crate items.

Co-authored-by: Anne Stijns <anstijns@gmail.com> Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

…Drop #![feature(rustc_private)]

…c, r=ehuss Doc: clarify priority of lint level sources This updates the rustc book to clearly document how conflicting lint configurations are resolved across different sources, including command-line flags, crate-level attributes, in-line attributes, and `--cap-lints`. It also explains the special behavior of `forbid` and `force_warn`. Fixes rust-lang#124088

…intra-doc, r=lolbinarycat Add regression test for rust-lang#137857 to ensure that we generate intra doc links for extern crate items. Fixes rust-lang#137857. I checked that linking to extern crates was generating valid links (with the `/index.html` part) and since it's already working, just adding a regression test. r? `@notriddle`

…youxu Generate symbols.o for proc-macros too To ensure used statics are functioning correctly for proc-macros too.

…acrum Clarify doc comment on unix OpenOptions

explain `ImportData::imported_module` r? `@petrochenkov`

…tag, r=RalfJung Improve documentation of `TagEncoding` This PR is follow-up from the [discussion here](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/.E2.9C.94.20VariantId.3DDiscriminant.20when.20tag.20is.20niche.20encoded.3F/with/524384295). It aims at making the `TagEncoding` documentation less ambiguous and more detailed with references to relevant implementation sides. It especially clears up the ambiguous use of discriminant/variant index, which sparked the discussion referenced above. PS: While working with layout data, I somehow ended up looking at the docs for `FakeBorrowKind` and noticed that the one example was not in a doc comment. I hope that this is minor enough of a fix for it to be okay in this otherwise unrelated PR.

fix typos on some doc comments

…r=jdonszelmann Port `#[link_name]` to the new attribute parsing infrastructure Ports `link_name` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

… r=GuillaumeGomez `librustdoc` house-keeping 🧹 This PR mostly removes a bunch of crate-level attributes that were added at some point, but then later on became unnecessary: - some `#[feature]` gates - some `#[allow]`s - a `#[recursion_limit]` Then I went ahead and sprinkled some tidy sorting on the remaining attrs, and `Cargo.toml`. Trying to give my anal retentiveness some peace of mind 😅

…compiler-errors Remove unused feature gates After finding some unused feature gates in rust-lang#143155 , I wrote a small script to see if I can find any others. And I did. Not a lot, but still a small win 😁 Contains a few instances of `iter_from_coroutine` that can be removed due to rust-lang#142801 (I guess).

…, r=compiler-errors Fix the span of trait bound modifier `[const]` r? project-const-traits or anyone

matthiaskrgr · 2025-06-29T05:00:33Z

@bors r+ rollup=never p=5

bors · 2025-06-29T05:00:36Z

📌 Commit a262c00 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-06-29T07:22:42Z

⌛ Testing commit a262c00 with merge 5ca574e...

bors · 2025-06-29T10:23:15Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 5ca574e to master...

rust-timer · 2025-06-29T10:26:22Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142021	Doc: clarify priority of lint level sources	`adcd17f92d8340bc53ede4e9b7576c1efaceaa70` (link)
#142367	Add regression test for #137857 to ensure that we generate …	`434805f2965fa4d259c890d0a43e6f1d8ce4a005` (link)
#142641	Generate symbols.o for proc-macros too	`291d09f374f4ac159422c4d96cc642a1eb338f39` (link)
#142889	Clarify doc comment on unix OpenOptions	`b548d114eb1d33a97b6d4dd2c469990444c62084` (link)
#143063	explain `ImportData::imported_module`	`d82e5e6b319839ce4f214db2cafc6c1498f7a1e2` (link)
#143088	Improve documentation of `TagEncoding`	`4806f921ae5a119beeb1e0522814dc46ceab92f2` (link)
#143135	fix typos on some doc comments	`740f607069e41ffe6a80ae391b5566065f029a60` (link)
#143138	Port `#[link_name]` to the new attribute parsing infrastruc…	`ebfadf2b9383c86d0ce5e3dcc7522ca19f5fbeb1` (link)
#143155	`librustdoc` house-keeping 🧹	`aedaa7f7af513671c7dfb557d162ce57dd0f0743` (link)
#143169	Remove unused feature gates	`039a981d6459f4b7ff90374f46a6f729d9536d2c` (link)
#143171	Fix the span of trait bound modifier `[const]`	`8dddde42417f73446585ba27a5f4edba75ae0e22` (link)

previous master: dddd7ab962

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-29T10:26:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing dddd7ab (parent) -> 5ca574e (this PR)

Test differences

Show 71 test diffs

Stage 1

[run-make] tests/run-make/used-proc-macro: [missing] -> pass (J0)
[rustdoc] tests/rustdoc/intra-doc/deps.rs: [missing] -> pass (J0)

Stage 2

[run-make] tests/run-make/used-proc-macro: [missing] -> ignore (ignored when cross-compiling) (J1)
[run-make] tests/run-make/used-proc-macro: [missing] -> pass (J2)
[run-make] tests/run-make/used-proc-macro: [missing] -> ignore (skipping test as target does not support all of the crate types ["proc-macro"]) (J3)
[run-make] tests/run-make/used-proc-macro: [missing] -> ignore (ignored when the operating system is windows (llvm-readobj --all doesn't show local symbols on Windows)) (J4)
[rustdoc] tests/rustdoc/intra-doc/deps.rs: [missing] -> pass (J5)
[run-make] tests/run-make/used-proc-macro: [missing] -> ignore (ignored when the target environment is musl ((FIXME: can't find -lunwind))) (J6)

Additionally, 63 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
J1: arm-android, armhf-gnu
J2: aarch64-apple, aarch64-gnu, aarch64-gnu-debug, i686-gnu-1, i686-gnu-nopt-1, x86_64-apple-1, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable
J3: dist-various-1
J4: i686-msvc-1, x86_64-mingw-1, x86_64-msvc-1
J5: aarch64-apple, aarch64-gnu, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J6: dist-i586-gnu-i586-i686-musl, test-various

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5ca574e85b67cec0a6fc3fddfe398cbe676c9c69 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 6112.5s -> 8427.5s (37.9%)
mingw-check-1: 1539.1s -> 1833.9s (19.2%)
dist-apple-various: 6955.3s -> 5639.8s (-18.9%)
x86_64-rust-for-linux: 2545.2s -> 2978.0s (17.0%)
mingw-check-2: 1827.2s -> 2120.7s (16.1%)
x86_64-apple-2: 4627.2s -> 5362.2s (15.9%)
dist-x86_64-apple: 8626.6s -> 9840.5s (14.1%)
i686-gnu-2: 5412.1s -> 6133.2s (13.3%)
i686-gnu-nopt-1: 7012.4s -> 7891.5s (12.5%)
x86_64-gnu-tools: 3248.4s -> 3628.3s (11.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-29T11:50:12Z

Finished benchmarking commit (5ca574e): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.3%, 0.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.3%, 0.7%]	2

Max RSS (memory usage)

Results (primary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[1.6%, 3.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.4%	[-2.5%, 3.7%]	4

Cycles

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-3.5%, -1.8%]	11
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 696.482s -> 695.013s (-0.21%)
Artifact size: 371.74 MiB -> 371.77 MiB (0.01%)

matthiaskrgr · 2025-06-29T15:26:10Z

probably due to #142641 we are doing a little more work now ?

Mark-Simulacrum · 2025-07-01T00:03:03Z

@rust-timer build 291d09f

@bjorn3 if that comes back negative maybe there's an opportunity to cache the symbols in incremental? Looks like the regressed benchmarks are incr-unchanged...

rust-timer · 2025-07-01T04:20:44Z

Finished benchmarking commit (291d09f): comparison URL.

Overall result: ❌ regressions - please read the text below

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.4%, 0.7%]	2

Max RSS (memory usage)

Results (primary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-2.8%, 2.9%]	2

Cycles

Results (primary -0.9%, secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-2.7%	[-3.3%, -1.9%]	7
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 696.482s -> 693.992s (-0.36%)
Artifact size: 371.74 MiB -> 371.71 MiB (-0.01%)

HamidrezaSK and others added 27 commits June 19, 2025 09:26

Generate symbols.o for proc-macros too

2bb98e2

To ensure used statics are functioning correctly for proc-macros too.

Add regression test for rust-lang#137857 to ensure that we generate i…

1052ddd

…ntra doc links for extern crate items.

fix typos on some doc comments

bc00a63

Port #[link_name] to the new attribute parsing infrastructure

1249c14

Co-authored-by: Anne Stijns <anstijns@gmail.com> Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

improve TagEncoding docs

ac6cfde

fix docs of FakeBorrowKind

3d96897

move discr=varid check to layout_sanity_check

1c25bfb

"set by Rusts options". Remove misleading always-true if cfg!(unix). …

45204ef

…Drop #![feature(rustc_private)]

explain ImportData::imported_module

f99cdf8

librustdoc: remove unneeded #[allow]s

09e4ee5

librustdoc: remove unneeded #[recursion_limit]

bcb287d

librustdoc: remove unused feature gates

96fcd06

librustdoc: use tidy for sorting attrs and deps

581cb11

Remove unused feature gates

8429c99

Fix the span of trait bound modifier [const]

f77fead

Rollup merge of rust-lang#142641 - bjorn3:proc_macro_symbols_o, r=jie…

e68f13c

…youxu Generate symbols.o for proc-macros too To ensure used statics are functioning correctly for proc-macros too.

Rollup merge of rust-lang#142889 - nabijaczleweli:rusts, r=Mark-Simul…

eef87fd

…acrum Clarify doc comment on unix OpenOptions

Rollup merge of rust-lang#143063 - bvanjoi:docs-resolve, r=petrochenkov

fd0062c

explain `ImportData::imported_module` r? `@petrochenkov`

Rollup merge of rust-lang#143135 - tshepang:typos, r=compiler-errors

170fd43

fix typos on some doc comments

Rollup merge of rust-lang#143138 - JonathanBrouwer:link_name_parser, …

5fc48ff

…r=jdonszelmann Port `#[link_name]` to the new attribute parsing infrastructure Ports `link_name` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`

Rollup merge of rust-lang#143171 - fmease:fix-span-of-maybe-const-mod…

a262c00

…, r=compiler-errors Fix the span of trait bound modifier `[const]` r? project-const-traits or anyone

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Jun 29, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2025

bors merged commit 5ca574e into rust-lang:master Jun 29, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jun 29, 2025

rustbot added the perf-regression Performance regression. label Jun 29, 2025

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 11 pull requests#143173

Rollup of 11 pull requests#143173
bors merged 27 commits intorust-lang:masterfrom
matthiaskrgr:rollup-ieu5k05

matthiaskrgr commented Jun 29, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

matthiaskrgr commented Jun 29, 2025

Uh oh!

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Conversation

matthiaskrgr commented Jun 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 29, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

matthiaskrgr commented Jun 29, 2025

Uh oh!

Mark-Simulacrum commented Jul 1, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 1, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

matthiaskrgr commented Jun 29, 2025 •

edited by rustbot

Loading