Rewrite empty attribute lint for new attribute parser by JonathanBrouwer · Pull Request #143252 · rust-lang/rust

JonathanBrouwer · 2025-06-30T17:20:18Z

bors · 2025-07-03T03:34:25Z

☔ The latest upstream changes (presumably #143338) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_attr_data_structures/src/attributes.rs

compiler/rustc_attr_data_structures/src/lints.rs

compiler/rustc_passes/src/check_attr.rs

rustbot · 2025-07-04T10:42:48Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-04T10:42:49Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

JonathanBrouwer · 2025-07-04T10:43:00Z

^ Rebased on master and fixed the review comments, changed quite a bit so would recommend to rereview
@rustbot ready
r? @jdonszelmann

rustbot · 2025-07-04T10:43:04Z

jdonszelmann is not on the review rotation at the moment.
They may take a while to respond.

bors · 2025-07-04T19:01:06Z

☔ The latest upstream changes (presumably #143434) made this pull request unmergeable. Please resolve the merge conflicts.

JonathanBrouwer · 2025-07-05T06:49:08Z

^ @jdonszelmann rebased on master

tests/ui/unpretty/exhaustive.hir.stdout

JonathanBrouwer · 2025-07-05T20:24:42Z

@rustbot ready
@jdonszelmann You can r+ this if you want but it's definitely gonna conflict with #143238, I'll ping you after that one goes through and I rebased this on it

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer · 2025-07-06T07:52:00Z

^ @jdonszelmann rebased

jdonszelmann · 2025-07-06T09:59:55Z

@bors r+ rollup

bors · 2025-07-06T09:59:58Z

📌 Commit 33f2cc7 has been approved by jdonszelmann

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - #143252 (Rewrite empty attribute lint for new attribute parser) - #143492 (Use `object` crate from crates.io to fix windows build error) - #143514 (Organize macro tests a bit more) - #143518 (rustc_builtin_macros: Make sure registered attributes stay sorted) r? `@ghost` `@rustbot` modify labels: rollup

compiler-errors · 2025-07-06T18:29:40Z

This fixes #143522 so it would be nice to add a test either here or a follow-up.

JonathanBrouwer · 2025-07-06T18:33:45Z

@compiler-errors
This PR is already being merged right now so it will be a followup. I was already gonna make a followup for #143479 which is in the same situation (fixed by this PR, no tests) as #143522

Rollup merge of #143252 - JonathanBrouwer:rewrite_empty_attribute, r=jdonszelmann Rewrite empty attribute lint for new attribute parser cc `@jdonszelmann`

…ts, r=oli-obk Regression tests for repr ICEs Closes rust-lang#143522 Closes rust-lang#143479 Both issues were already (accidentally) fixed in this PR, but having the tests is nice rust-lang#143252 r? `@jdonszelmann`

Rollup merge of #143539 - JonathanBrouwer:ice-regression-tests, r=oli-obk Regression tests for repr ICEs Closes #143522 Closes #143479 Both issues were already (accidentally) fixed in this PR, but having the tests is nice #143252 r? `@jdonszelmann`

…-obk Regression tests for repr ICEs Closes rust-lang/rust#143522 Closes rust-lang/rust#143479 Both issues were already (accidentally) fixed in this PR, but having the tests is nice rust-lang/rust#143252 r? `@jdonszelmann`

Rollup of 4 pull requests Successful merges: - rust-lang/rust#143252 (Rewrite empty attribute lint for new attribute parser) - rust-lang/rust#143492 (Use `object` crate from crates.io to fix windows build error) - rust-lang/rust#143514 (Organize macro tests a bit more) - rust-lang/rust#143518 (rustc_builtin_macros: Make sure registered attributes stay sorted) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025

JonathanBrouwer mentioned this pull request Jul 1, 2025

Port #[target_feature] to new attribute parsing infrastructure #142876

Merged

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 3, 2025

jdonszelmann reviewed Jul 3, 2025

View reviewed changes

compiler/rustc_attr_data_structures/src/attributes.rs Outdated Show resolved Hide resolved

compiler/rustc_attr_data_structures/src/lints.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/check_attr.rs Show resolved Hide resolved

JonathanBrouwer force-pushed the rewrite_empty_attribute branch from bdb57ed to b896b59 Compare July 4, 2025 10:42

JonathanBrouwer marked this pull request as ready for review July 4, 2025 10:42

rustbot assigned fee1-dead Jul 4, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2025

rustbot assigned jdonszelmann and unassigned fee1-dead Jul 4, 2025

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the rewrite_empty_attribute branch from b896b59 to a577ea0 Compare July 4, 2025 11:40

JonathanBrouwer force-pushed the rewrite_empty_attribute branch 2 times, most recently from 6cdec3b to fd443fc Compare July 5, 2025 06:48

jdonszelmann requested changes Jul 5, 2025

View reviewed changes

tests/ui/unpretty/exhaustive.hir.stdout Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2025

JonathanBrouwer mentioned this pull request Jul 5, 2025

ICE with repr(align(0)) #143479

Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2025

JonathanBrouwer added 2 commits July 6, 2025 09:51

Rewrite empty attribute lint

3fa0ec9

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Fix line break after ":" in unpretty attribute print

33f2cc7

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

JonathanBrouwer force-pushed the rewrite_empty_attribute branch from 3bab1c5 to 33f2cc7 Compare July 6, 2025 07:51

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025

matthiaskrgr mentioned this pull request Jul 6, 2025

Rollup of 4 pull requests #143526

Merged

jdonszelmann mentioned this pull request Jul 6, 2025

Recover non-list repr attr with a span for later attr validation #143533

Closed

JonathanBrouwer mentioned this pull request Jul 6, 2025

ICE: #![repr] #143522

Closed

bors merged commit 017fe2f into rust-lang:master Jul 6, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 6, 2025

rust-timer added a commit that referenced this pull request Jul 6, 2025

Unrolled build for #143252

6c1641c

Rollup merge of #143252 - JonathanBrouwer:rewrite_empty_attribute, r=jdonszelmann Rewrite empty attribute lint for new attribute parser cc `@jdonszelmann`

JonathanBrouwer mentioned this pull request Jul 6, 2025

Regression tests for repr ICEs #143539

Merged

Uh oh!

Conversation

JonathanBrouwer commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

JonathanBrouwer commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 4, 2025

Uh oh!

JonathanBrouwer commented Jul 5, 2025

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 5, 2025

Uh oh!

JonathanBrouwer commented Jul 6, 2025

Uh oh!

jdonszelmann commented Jul 6, 2025

Uh oh!

bors commented Jul 6, 2025

Uh oh!

compiler-errors commented Jul 6, 2025

Uh oh!

JonathanBrouwer commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JonathanBrouwer commented Jun 30, 2025 •

edited

Loading

JonathanBrouwer commented Jul 6, 2025 •

edited

Loading