`tests/ui`: A New Order [23/N] by Kivooeo · Pull Request #143298 · rust-lang/rust

Kivooeo · 2025-07-01T19:43:08Z

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

tgross35 · 2025-07-04T04:09:25Z

tests/ui/codegen/shift-right-operand-mutation.rs

+//! This test checks that expressions like `0 << b` don't accidentally
+//! modify the variable `b` due to codegen issues with virtual registers.
+//!
+//! Regression test for <https://github.com/rust-lang/rust/issues/152>.


Wow, old issue! That's only two months after https://www.github.com/rust-lang/rust/issues/1

tgross35

LGTM, please squash

tgross35 · 2025-07-04T19:53:23Z

@bors r+ rollup

bors · 2025-07-04T19:53:25Z

📌 Commit 626521d has been approved by tgross35

It is now in the queue for this repository.

`tests/ui`: A New Order [23/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@tgross35`

Rollup of 9 pull requests Successful merges: - #141532 (std: sys: net: uefi: tcp4: Implement write) - #143085 (Port `#[non_exhaustive]` to the new attribute parsing infrastructure) - #143298 (`tests/ui`: A New Order [23/N]) - #143372 (Remove names_imported_by_glob_use query.) - #143386 (Assign dependency bump PRs to me) - #143406 (Remove some unnecessary `unsafe` in VecCache) - #143408 (mbe: Gracefully handle macro rules that end after `=>`) - #143414 (remove special-casing of boxes from match exhaustiveness/usefulness analysis) - #143444 (clean up GVN TypeId test) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-07-04T22:11:42Z

@bors r-
#143454 (comment)

tgross35 · 2025-07-04T22:15:29Z

tests/ui/codegen/shift-right-operand-mutation.rs

+        let _ = 0_usize << b;
+        b <<= 1;
    }
+    assert_eq!(8, b);


Check size_of::<usize>() rather than a constant, this failed on 32bit.

Also you can update the above std::mem::size_of -> size_of since it's now in the prelude.

uhm, do you mean like this?

pub fn main() { let mut b: usize = 1; while b < size_of::<usize>() { // This shift operation should not mutate `b` let _ = 0_usize << b; b <<= 1; } assert_eq!(size_of::<usize>(), b); }

You can test 32-bit behavior on the playground by replacing usize with u32 :)

yeah i know that usize's size is different on different platforms, but I wonder about test above, is that correct now? the reason im asking and not just run ./x test is because it will took 10 minutes and all resoures of my machince which im not ready to give it rn

All I was planning to do to validate is put it in the playground anyway, it indeed looks correct https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=3aaf2f28b9cb4e4e60d14ae7624df83c

Noticing one other thing though; I think it might important that we observe the intermediate value so it can't get optimized out. println was doing this before but got deleted here, could you add std::hint::black_box(b); at the end of the while loop?

i dont think that compiler can optimize this loop out, also i could miss understood you, i've added black_box to end of each iteration, and not after the while itself, not sure which one you exactly meant, but both should work fine i guess

Kivooeo · 2025-07-04T22:15:41Z

hm, could this test be platform dependent? im not sure exactly what could cause this but when i was write this assert ive checked it and it was worked fine (its still do work fine in playground tho and CI passed, this is weird)

https://play.rust-lang.org/?version=stable&mode=release&edition=2024&gist=d5c825b667ddbdcfd48c031dcdd0798a

Ah, ok, now i see the answer above

tgross35 · 2025-07-04T22:34:23Z

Might as well
@bors2 try jobs=dist-i586-gnu-i586-i686-musl

rust-bors · 2025-07-04T22:34:26Z

⌛ Trying commit 4d4c3e2 with merge 71ca6be…

To cancel the try build, run the command @bors2 try cancel.

`tests/ui`: A New Order [23/N]    > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895. r? `@tgross35` try-job: dist-i586-gnu-i586-i686-musl

Kivooeo · 2025-07-04T22:36:49Z

not sure if this needed becuase we made it dependable and not hardcoded 8, but let's see

also not sure if i should force push tidy fix now or later, because im not sure what will happen with bors try

Kivooeo · 2025-07-04T22:46:42Z

fixed tidy, maybe need bors try once again

rust-bors · 2025-07-05T00:14:15Z

☀️ Try build successful (CI)
Build commit: 71ca6be (71ca6be428c123c513694880a2b3b612510b964d, parent: e3843659e9f65f589d184d1221ac6149d5fa07b5)

Kivooeo · 2025-07-05T00:15:49Z

yeah, safe to r+

tgross35 · 2025-07-09T21:27:00Z

@bors r+

not sure if this needed becuase we made it dependable and not hardcoded 8, but let's see

It's pretty common to run a try job when adding a fix for something that failed, even if it's reasonably trivial like this

bors · 2025-07-09T21:27:03Z

📌 Commit 7c2cc2c has been approved by tgross35

It is now in the queue for this repository.

`tests/ui`: A New Order [23/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@tgross35`

Rollup of 9 pull requests Successful merges: - #141996 (Fix `proc_macro::Ident`'s handling of `$crate`) - #142911 (Remove support for dynamic allocas) - #142950 (mbe: Rework diagnostics for metavariable expressions) - #143270 (tests/codegen/enum/enum-match.rs: accept negative range attribute) - #143298 (`tests/ui`: A New Order [23/N]) - #143398 (tidy: add support for `--extra-checks=auto:` feature) - #143632 (fix: correct parameter names in LLVMRustBuildMinNum and LLVMRustBuildMaxNum FFI declarations) - #143644 (Add triagebot stdarch mention ping) - #143651 (Win: Use exceptions with empty data for SEH panic exception copies instead of a new panic) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - #141996 (Fix `proc_macro::Ident`'s handling of `$crate`) - #142950 (mbe: Rework diagnostics for metavariable expressions) - #143011 (Make lint `ambiguous_glob_imports` deny-by-default and report-in-deps) - #143265 (Mention as_chunks in the docs for chunks) - #143270 (tests/codegen/enum/enum-match.rs: accept negative range attribute) - #143298 (`tests/ui`: A New Order [23/N]) - #143396 (Move NaN tests to floats/mod.rs) - #143398 (tidy: add support for `--extra-checks=auto:` feature) - #143644 (Add triagebot stdarch mention ping) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143298 - Kivooeo:tf23, r=tgross35 `tests/ui`: A New Order [23/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895. r? ``@tgross35``

Rollup of 9 pull requests Successful merges: - rust-lang#141996 (Fix `proc_macro::Ident`'s handling of `$crate`) - rust-lang#142950 (mbe: Rework diagnostics for metavariable expressions) - rust-lang#143011 (Make lint `ambiguous_glob_imports` deny-by-default and report-in-deps) - rust-lang#143265 (Mention as_chunks in the docs for chunks) - rust-lang#143270 (tests/codegen/enum/enum-match.rs: accept negative range attribute) - rust-lang#143298 (`tests/ui`: A New Order [23/N]) - rust-lang#143396 (Move NaN tests to floats/mod.rs) - rust-lang#143398 (tidy: add support for `--extra-checks=auto:` feature) - rust-lang#143644 (Add triagebot stdarch mention ping) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - rust-lang/rust#141996 (Fix `proc_macro::Ident`'s handling of `$crate`) - rust-lang/rust#142950 (mbe: Rework diagnostics for metavariable expressions) - rust-lang/rust#143011 (Make lint `ambiguous_glob_imports` deny-by-default and report-in-deps) - rust-lang/rust#143265 (Mention as_chunks in the docs for chunks) - rust-lang/rust#143270 (tests/codegen/enum/enum-match.rs: accept negative range attribute) - rust-lang/rust#143298 (`tests/ui`: A New Order [23/N]) - rust-lang/rust#143396 (Move NaN tests to floats/mod.rs) - rust-lang/rust#143398 (tidy: add support for `--extra-checks=auto:` feature) - rust-lang/rust#143644 (Add triagebot stdarch mention ping) r? `@ghost` `@rustbot` modify labels: rollup

moved tests

9a7db56

rustbot assigned tgross35 Jul 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2025

This comment has been minimized.

Sign in to view

tgross35 reviewed Jul 4, 2025

View reviewed changes

tgross35 approved these changes Jul 4, 2025

View reviewed changes

Kivooeo force-pushed the tf23 branch from cb6db1c to 626521d Compare July 4, 2025 18:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025

matthiaskrgr mentioned this pull request Jul 4, 2025

Rollup of 9 pull requests #143454

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 4, 2025

tgross35 requested changes Jul 4, 2025

View reviewed changes

Kivooeo force-pushed the tf23 branch from 626521d to 4d4c3e2 Compare July 4, 2025 22:32

cleaned up some tests

7c2cc2c

Kivooeo force-pushed the tf23 branch from 4d4c3e2 to 7c2cc2c Compare July 4, 2025 22:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2025

tgross35 approved these changes Jul 9, 2025

View reviewed changes

tgross35 mentioned this pull request Jul 10, 2025

Rollup of 9 pull requests #143715

Closed

tgross35 mentioned this pull request Jul 10, 2025

Rollup of 9 pull requests #143721

Merged

bors merged commit 7ad9096 into rust-lang:master Jul 10, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 10, 2025

Uh oh!

Conversation

Kivooeo commented Jul 1, 2025

Uh oh!

This comment has been minimized.

tgross35 Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

matthiaskrgr commented Jul 4, 2025

Uh oh!

tgross35 Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Jul 4, 2025

Uh oh!

rust-bors bot commented Jul 4, 2025

Uh oh!

Kivooeo commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Jul 4, 2025

Uh oh!

rust-bors bot commented Jul 5, 2025

Uh oh!

Kivooeo commented Jul 5, 2025

Uh oh!

tgross35 commented Jul 9, 2025

Uh oh!

bors commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kivooeo Jul 4, 2025 •

edited

Loading

Kivooeo commented Jul 4, 2025 •

edited

Loading

Kivooeo commented Jul 4, 2025 •

edited

Loading