`tests/ui`: A New Order [26/N] by Kivooeo · Pull Request #143301 · rust-lang/rust

Kivooeo · 2025-07-01T19:43:18Z

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

r? @tgross35

Kivooeo · 2025-07-04T21:19:40Z

If it'll help, I can squash commits in advance

tgross35 · 2025-07-04T21:27:41Z

Would you mind doing that? GH seems to be struggling with this diff again for some reason

Kivooeo · 2025-07-04T21:31:06Z

Squashed this and last part

tests/ui/borrowck/super-let-lifetime-and-drop.borrowck.stderr

tests/ui/auxiliary/svh-b.rs

tests/ui/cast/cast-enum-to-primitive-error.rs

tests/ui/generics/generic-enum-errors.rs

tests/ui/modules/module-super-access.rs

tests/ui/typeck/tail-return-type-mismatch.rs

tests/ui/transmute/transmute-same-associated-type.rs

tests/ui/transmute/transmute-array-to-scalar.rs

tests/ui/recursion/recursion-tail-cps.rs

Kivooeo · 2025-07-10T17:05:52Z

@rustbot ready

tgross35

Just a few small spelling nits.

Also, could you update the second commit message to say "Additionally, remove unused tests/ui/auxiliary/svh-* crates that are duplicates of tests/ui/svh/auxiliary/svh-*." or otherwise mention the exact paths? So nobody has to dig to find that out, it was a bit tricky to get that info

tests/ui/cast/cast-enum-to-primitive-error.rs

tests/ui/generics/generic-enum-errors.rs

tests/ui/modules/module-super-access.rs

tgross35 · 2025-07-10T22:38:55Z

Thanks!
@bors r+ rollup

bors · 2025-07-10T22:38:58Z

📌 Commit cd2a50e has been approved by tgross35

It is now in the queue for this repository.

`tests/ui`: A New Order [26/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@tgross35`

Rollup of 7 pull requests Successful merges: - #142391 (rust: library: Add `setsid` method to `CommandExt` trait) - #143301 (`tests/ui`: A New Order [26/N]) - #143302 (`tests/ui`: A New Order [27/N]) - #143303 (`tests/ui`: A New Order [28/28] FINAL PART) - #143568 (std: sys: net: uefi: tcp4: Add timeout support) - #143708 (fix: Include frontmatter in -Zunpretty output ) - #143718 (Make UB transmutes really UB in LLVM) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-11T05:12:32Z

☔ The latest upstream changes (presumably #143762) made this pull request unmergeable. Please resolve the merge conflicts.

Additionally, remove unused `tests/ui/auxiliary/svh-*` crates that are duplicates of `tests/ui/svh/auxiliary/svh-*`.

tgross35 · 2025-07-12T19:56:15Z

@bors r+ rollup

bors · 2025-07-12T19:56:17Z

📌 Commit 9893470 has been approved by tgross35

It is now in the queue for this repository.

`tests/ui`: A New Order [26/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@tgross35`

Rollup of 14 pull requests Successful merges: - #143301 (`tests/ui`: A New Order [26/N]) - #143461 (make `cfg_select` a builtin macro) - #143519 (Check assoc consts and tys later like assoc fns) - #143554 (slice: Mark `rotate_left`, `rotate_right` unstably const) - #143634 (interpret/allocation: expose init + write_wildcards on a range) - #143679 (Preserve the .debug_gdb_scripts section) - #143685 (Resolve: merge `source_bindings` and `target_bindings` into `bindings`) - #143704 (Be a bit more careful around exotic cycles in in the inliner) - #143734 (Refactor resolve resolution bindings) - #143774 (constify `From` and `Into`) - #143785 (Add --compile-time-deps argument for x check) - #143786 (Fix fallback for CI_JOB_NAME) - #143825 (clippy: fix test filtering when TESTNAME is empty) - #143826 (Fix command trace) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui`: A New Order [26/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? ``@tgross35``

Rollup of 13 pull requests Successful merges: - #143301 (`tests/ui`: A New Order [26/N]) - #143461 (make `cfg_select` a builtin macro) - #143519 (Check assoc consts and tys later like assoc fns) - #143554 (slice: Mark `rotate_left`, `rotate_right` unstably const) - #143634 (interpret/allocation: expose init + write_wildcards on a range) - #143679 (Preserve the .debug_gdb_scripts section) - #143685 (Resolve: merge `source_bindings` and `target_bindings` into `bindings`) - #143734 (Refactor resolve resolution bindings) - #143774 (constify `From` and `Into`) - #143785 (Add --compile-time-deps argument for x check) - #143786 (Fix fallback for CI_JOB_NAME) - #143825 (clippy: fix test filtering when TESTNAME is empty) - #143826 (Fix command trace) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui`: A New Order [26/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? ```@tgross35```

Rollup of 11 pull requests Successful merges: - #143301 (`tests/ui`: A New Order [26/N]) - #143519 (Check assoc consts and tys later like assoc fns) - #143554 (slice: Mark `rotate_left`, `rotate_right` unstably const) - #143634 (interpret/allocation: expose init + write_wildcards on a range) - #143685 (Resolve: merge `source_bindings` and `target_bindings` into `bindings`) - #143734 (Refactor resolve resolution bindings) - #143774 (constify `From` and `Into`) - #143785 (Add --compile-time-deps argument for x check) - #143786 (Fix fallback for CI_JOB_NAME) - #143825 (clippy: fix test filtering when TESTNAME is empty) - #143826 (Fix command trace) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143301 - Kivooeo:tf26, r=tgross35 `tests/ui`: A New Order [26/N] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895. r? ````@tgross35````

Rollup of 11 pull requests Successful merges: - rust-lang/rust#143301 (`tests/ui`: A New Order [26/N]) - rust-lang/rust#143519 (Check assoc consts and tys later like assoc fns) - rust-lang/rust#143554 (slice: Mark `rotate_left`, `rotate_right` unstably const) - rust-lang/rust#143634 (interpret/allocation: expose init + write_wildcards on a range) - rust-lang/rust#143685 (Resolve: merge `source_bindings` and `target_bindings` into `bindings`) - rust-lang/rust#143734 (Refactor resolve resolution bindings) - rust-lang/rust#143774 (constify `From` and `Into`) - rust-lang/rust#143785 (Add --compile-time-deps argument for x check) - rust-lang/rust#143786 (Fix fallback for CI_JOB_NAME) - rust-lang/rust#143825 (clippy: fix test filtering when TESTNAME is empty) - rust-lang/rust#143826 (Fix command trace) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned tgross35 Jul 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2025

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf26 branch from 0fe2ecd to fae463d Compare July 4, 2025 21:29

tgross35 requested changes Jul 9, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2025

Kivooeo force-pushed the tf26 branch from fae463d to 48f93b3 Compare July 10, 2025 13:44

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf26 branch from 48f93b3 to abcb5c8 Compare July 10, 2025 14:21

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf26 branch from abcb5c8 to c70ad13 Compare July 10, 2025 15:09

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2025

tgross35 reviewed Jul 10, 2025

View reviewed changes

tests/ui/cast/cast-enum-to-primitive-error.rs Outdated Show resolved Hide resolved

tests/ui/generics/generic-enum-errors.rs Outdated Show resolved Hide resolved

tests/ui/modules/module-super-access.rs Outdated Show resolved Hide resolved

Kivooeo force-pushed the tf26 branch from c70ad13 to cd2a50e Compare July 10, 2025 21:51

tgross35 approved these changes Jul 10, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2025

tgross35 mentioned this pull request Jul 10, 2025

Rollup of 7 pull requests #143760

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 11, 2025

Kivooeo added 2 commits July 13, 2025 00:03

moved tests

47b8a32

cleaned up some tests

9893470

Additionally, remove unused `tests/ui/auxiliary/svh-*` crates that are duplicates of `tests/ui/svh/auxiliary/svh-*`.

Kivooeo force-pushed the tf26 branch from cd2a50e to 9893470 Compare July 12, 2025 19:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2025

fmease mentioned this pull request Jul 13, 2025

Rollup of 14 pull requests #143866

Closed

matthiaskrgr mentioned this pull request Jul 13, 2025

Rollup of 13 pull requests #143876

Closed

This was referenced Jul 13, 2025

Rollup of 12 pull requests #143886

Closed

Rollup of 11 pull requests #143888

Merged

bors merged commit b56880c into rust-lang:master Jul 13, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 13, 2025

Uh oh!

Conversation

Kivooeo commented Jul 1, 2025

Uh oh!

This comment has been minimized.

Kivooeo commented Jul 4, 2025

Uh oh!

tgross35 commented Jul 4, 2025

Uh oh!

Kivooeo commented Jul 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kivooeo commented Jul 10, 2025

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Jul 10, 2025

Uh oh!

bors commented Jul 10, 2025

Uh oh!

bors commented Jul 11, 2025

Uh oh!

tgross35 commented Jul 12, 2025

Uh oh!

bors commented Jul 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants