Port several trait/coherence-related attributes the new attribute system

[GrigorenkoPV]

Part of #131229

This ports:

• #[const_trait]
• #[rustc_deny_explicit_impl]
• #[rustc_do_not_implement_via_object]
• #[rustc_coinductive]
• #[type_const]
• #[rustc_specialization_trait]
• #[rustc_unsafe_specialization_marker]
• #[marker]
• #[fundamental]
• #[rustc_paren_sugar]
• #[rustc_allow_incoherent_impl]
• #[rustc_coherence_is_core]

This also changes #[marker] to error on duplicates instead of warning.
cc #142838, but I don't think it matters too much, since it's unstable.

r? @oli-obk

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

[jdonszelmann]

@rustbot blocked

[bors]

☔ The latest upstream changes (presumably #143434) made this pull request unmergeable. Please resolve the merge conflicts.

[GrigorenkoPV]

@rustbot ready

[bors]

☔ The latest upstream changes (presumably #143459) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #143507) made this pull request unmergeable. Please resolve the merge conflicts.

[jdonszelmann]

@bors r+ rollup

[bors]

📌 Commit da5ea0a has been approved by jdonszelmann

It is now in the queue for this repository.

[bors]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: Use join_with_double_colon in write_shared.rs. #142869

[bors]

📌 Commit da5ea0a has been approved by jdonszelmann

It is now in the queue for this repository.

[GrigorenkoPV]

@rustbot ready

[jdonszelmann]

@bors r+

[bors]

📌 Commit e584ed0 has been approved by jdonszelmann

It is now in the queue for this repository.

[Kobzol]

@rust-timer build 4967043

Checking for #143810. The bootstrap regression is quite likely caused by this PR.

[rust-timer]

Finished benchmarking commit (4967043): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	39
Regressions ❌ (secondary)	0.4%	[0.1%, 1.0%]	33
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.3%]	4
All ❌✅ (primary)	0.2%	[0.1%, 0.3%]	39

Max RSS (memory usage)

Results (primary -1.4%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.1%	[6.1%, 6.1%]	1
Improvements ✅ (primary)	-1.4%	[-1.6%, -1.2%]	2
Improvements ✅ (secondary)	-6.3%	[-6.3%, -6.3%]	1
All ❌✅ (primary)	-1.4%	[-1.6%, -1.2%]	2

Cycles

Results (primary -2.6%, secondary -6.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-2.6%	[-3.1%, -2.3%]	4
Improvements ✅ (secondary)	-7.9%	[-11.7%, -2.3%]	7
All ❌✅ (primary)	-2.6%	[-3.1%, -2.3%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 462.356s -> 465.002s (0.57%)
Artifact size: 374.66 MiB -> 374.78 MiB (0.03%)

[Kobzol]

Yeah this is definitely the cause of the regression from the rollup. The bootstrap regression is interesting, I wonder if the trait consts or the big enums somehow stress rustc a lot.. or maybe it's the complex nested parser types.