Get rid of build-powerpc64le-toolchain.sh by Gelbpunkt · Pull Request #143415 · rust-lang/rust

Gelbpunkt · 2025-07-04T08:50:15Z

The dist-powerpc64le-linux-musl runner never actually used the toolchain that the script produced, it instead used the one from crosstool-ng.

The dist-powerpc64le-linux-gnu runner did use it, from what I can tell mainly to get a glibc 2.17 version with ppc64le support backported. Since crosstool-ng has the necessary patches, we can just use crosstool-ng to get an appropriate toolchain. While at it, use kernel 3.10 headers since that's the version documented in platform support for this target.

try-job: dist-powerpc64le-linux-gnu
try-job: dist-powerpc64le-linux-musl

The dist-powerpc64le-linux-musl runner never actually used the toolchain that the script produced, it instead used the one from crosstool-ng. The dist-powerpc64le-linux-gnu runner did use it, from what I can tell mainly to get a glibc 2.17 version with ppc64le support backported. Since crosstool-ng has the necessary patches, we can just use crosstool-ng to get an appropriate toolchain. While at it, use kernel 3.10 headers since that's the version documented in platform support for this target. Signed-off-by: Jens Reidel <adrian@travitia.xyz>

rustbot · 2025-07-04T08:50:18Z

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-07-04T10:02:57Z

@bors2 try

rust-bors · 2025-07-04T10:03:01Z

⌛ Trying commit 12bc409 with merge 3956ef4…

To cancel the try build, run the command @bors2 try cancel.

…try> Get rid of build-powerpc64le-toolchain.sh The dist-powerpc64le-linux-musl runner never actually used the toolchain that the script produced, it instead used the one from crosstool-ng. The dist-powerpc64le-linux-gnu runner did use it, from what I can tell mainly to get a glibc 2.17 version with ppc64le support backported. Since crosstool-ng has the necessary patches, we can just use crosstool-ng to get an appropriate toolchain. While at it, use kernel 3.10 headers since that's the version documented in platform support for this target. try-job: dist-powerpc64le-linux-gnu try-job: dist-powerpc64le-linux-musl

rust-bors · 2025-07-04T13:45:57Z

☀️ Try build successful (CI)
Build commit: 3956ef4 (3956ef4a164e4d59f20f15356a748e6d9adb6af6, parent: c96a69059ecc618b519da385a6ccd03155aa0237)

marcoieni · 2025-07-04T15:10:05Z

Hi, thanks for this PR! It looks like a great cleanup. I'll ask for some help to review it.

The dist-powerpc64le-linux-musl runner never actually used the toolchain that the script produced, it instead used the one from crosstool-ng.

Did you get this from the script? If yes, where?

from what I can tell mainly to get a glibc 2.17 version

How can I double check this?

Gelbpunkt · 2025-07-04T16:28:14Z

Did you get this from the script? If yes, where?

The PATH variable points to the crosstool-ng output. I also confirmed it manually by entering the build container and running powerpc64le-unknown-linux-musl-gcc --version and it includes "crosstool-ng". Also, the script's GCC targets glibc, not musl.

How can I double check this?

Not sure what your question is, I got this from reading the script. Glibc 2.17 is the documented baseline of the target.

cuviper · 2025-07-04T17:21:20Z

FWIW, I use a pipeline like this to check the resulting symbol versions:

$ readelf -V librustc_driver-*.so | grep -o 'Name: \S*' | sort -uV
Name: GCC_3.0
Name: GCC_3.3
Name: GCC_3.4.4
Name: GCC_4.2.0
Name: GLIBC_2.17

(and repeat for all binaries, though librustc_driver is big enough that it usually represents everything)

In the CI artifacts from your try build, everything looks good to me except for one:

./rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/bin/rust-objcopy
Name: GCC_3.0
Name: GCC_3.3
Name: GCC_3.4
Name: GCC_4.2.0
Name: GLIBC_2.2.5
Name: GLIBC_2.3
Name: GLIBC_2.3.4
Name: GLIBC_2.4
Name: GLIBC_2.6
Name: GLIBC_2.14
Name: GLIBC_2.15
Name: GLIBC_2.16
Name: GLIBC_2.17
Name: GLIBC_2.32
Name: GLIBC_2.33
Name: GLIBC_2.34

... but that appears to be from the x86-64 build host, not for PPC! (probably not a new problem)

$ file ./rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/bin/rust-objcopy
./rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/bin/rust-objcopy: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=6507171c1208cad17b064ffbff3b348c18680367, for GNU/Linux 3.2.0, not stripped

Gelbpunkt · 2025-07-04T17:28:43Z

... but that appears to be from the x86-64 build host, not for PPC! (probably not a new problem)

Yep! Can confirm this on a powerpc64le-unknown-linux-gnu host that installed the toolchain via rustup:

adrian@theta:~$ find ~/.rustup/ -name *objcopy*
/home/adrian/.rustup/toolchains/nightly-powerpc64le-unknown-linux-gnu/lib/rustlib/powerpc64le-unknown-linux-gnu/bin/rust-objcopy
adrian@theta:~$ file /home/adrian/.rustup/toolchains/nightly-powerpc64le-unknown-linux-gnu/lib/rustlib/powerpc64le-unknown-linux-gnu/bin/rust-objcopy
/home/adrian/.rustup/toolchains/nightly-powerpc64le-unknown-linux-gnu/lib/rustlib/powerpc64le-unknown-linux-gnu/bin/rust-objcopy: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=6507171c1208cad17b064ffbff3b348c18680367, for GNU/Linux 3.2.0, not stripped

This happens on all cross builds, actually. E.g. aarch64-unknown-linux-musl has the same issue.

marcoieni · 2025-07-07T10:07:42Z

@bors r+

bors · 2025-07-07T10:07:45Z

📌 Commit 12bc409 has been approved by marcoieni

It is now in the queue for this repository.

Rollup of 11 pull requests Successful merges: - #143130 (doc(std): clarify `NonZero<T>` usage limitation in doc comment) - #143415 (Get rid of build-powerpc64le-toolchain.sh) - #143464 (Make tests/ui/abi/debug.rs cross-compile) - #143482 (Fix short linker error output) - #143524 (Move `stable_mir` back to its own crate) - #143528 (interpret: rename StackPopCleanup) - #143551 (Dont resolve instance of root in `mir_callgraph_cyclic`) - #143558 (mbe: Refactors and function extractions in `compile_declarative_macro`) - #143563 (std: fix typo in `std::path`) - #143564 (compiler: Deduplicate `must_emit_unwind_tables()` comments) - #143577 (Disable download-rustc for library profile) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143415 - Gelbpunkt:cleanup-dist-ppc64le-toolchain, r=marcoieni Get rid of build-powerpc64le-toolchain.sh The dist-powerpc64le-linux-musl runner never actually used the toolchain that the script produced, it instead used the one from crosstool-ng. The dist-powerpc64le-linux-gnu runner did use it, from what I can tell mainly to get a glibc 2.17 version with ppc64le support backported. Since crosstool-ng has the necessary patches, we can just use crosstool-ng to get an appropriate toolchain. While at it, use kernel 3.10 headers since that's the version documented in platform support for this target. try-job: dist-powerpc64le-linux-gnu try-job: dist-powerpc64le-linux-musl

Rollup of 11 pull requests Successful merges: - rust-lang/rust#143130 (doc(std): clarify `NonZero<T>` usage limitation in doc comment) - rust-lang/rust#143415 (Get rid of build-powerpc64le-toolchain.sh) - rust-lang/rust#143464 (Make tests/ui/abi/debug.rs cross-compile) - rust-lang/rust#143482 (Fix short linker error output) - rust-lang/rust#143524 (Move `stable_mir` back to its own crate) - rust-lang/rust#143528 (interpret: rename StackPopCleanup) - rust-lang/rust#143551 (Dont resolve instance of root in `mir_callgraph_cyclic`) - rust-lang/rust#143558 (mbe: Refactors and function extractions in `compile_declarative_macro`) - rust-lang/rust#143563 (std: fix typo in `std::path`) - rust-lang/rust#143564 (compiler: Deduplicate `must_emit_unwind_tables()` comments) - rust-lang/rust#143577 (Disable download-rustc for library profile) r? `@ghost` `@rustbot` modify labels: rollup

shepmaster · 2025-08-22T23:55:18Z

but that appears to be from the x86-64 build host, not for PPC! (probably not a new problem)

Should be fixed in #145763

rustbot assigned marcoieni Jul 4, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025

jieyouxu mentioned this pull request Jul 7, 2025

Rollup of 11 pull requests #143582

Merged

bors merged commit 9c6ef43 into rust-lang:master Jul 7, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 7, 2025

Gelbpunkt mentioned this pull request Aug 21, 2025

error: unable to run rust-objcopy: Bad CPU type in executable (os error 86) #145699

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Get rid of build-powerpc64le-toolchain.sh#143415

Get rid of build-powerpc64le-toolchain.sh#143415
bors merged 1 commit intorust-lang:masterfrom
Gelbpunkt:cleanup-dist-ppc64le-toolchain

Gelbpunkt commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

jieyouxu commented Jul 4, 2025

Uh oh!

rust-bors bot commented Jul 4, 2025

Uh oh!

rust-bors bot commented Jul 4, 2025

Uh oh!

marcoieni commented Jul 4, 2025

Uh oh!

Gelbpunkt commented Jul 4, 2025 •

edited

Loading

Uh oh!

cuviper commented Jul 4, 2025

Uh oh!

Gelbpunkt commented Jul 4, 2025 •

edited

Loading

Uh oh!

marcoieni commented Jul 7, 2025

Uh oh!

bors commented Jul 7, 2025

Uh oh!

Uh oh!

shepmaster commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Gelbpunkt commented Jul 4, 2025

Uh oh!

rustbot commented Jul 4, 2025

Uh oh!

jieyouxu commented Jul 4, 2025

Uh oh!

rust-bors bot commented Jul 4, 2025

Uh oh!

rust-bors bot commented Jul 4, 2025

Uh oh!

marcoieni commented Jul 4, 2025

Uh oh!

Gelbpunkt commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cuviper commented Jul 4, 2025

Uh oh!

Gelbpunkt commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcoieni commented Jul 7, 2025

Uh oh!

bors commented Jul 7, 2025

Uh oh!

Uh oh!

shepmaster commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Gelbpunkt commented Jul 4, 2025 •

edited

Loading

Gelbpunkt commented Jul 4, 2025 •

edited

Loading