[WIP] Lint self-overlapping or-patterns under guard

[Nadrieril]

This adds an error on or-patterns under match guard that may cause the guard to be run more than once, such as true | true if f(). This is for crater purposes.

r? ghost

[Nadrieril]

@bors try

[bors]

⌛ Trying commit c0fda28 with merge 3ce2ac6...

[bors]

💔 Test failed - checks-actions

[Nadrieril]

does the try job have to succeed for crater?

@craterbot check

[craterbot]

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[bors]

☔ The latest upstream changes (presumably #143472) made this pull request unmergeable. Please resolve the merge conflicts.

[Nadrieril]

I might revisit this later but I don't have time to continue that rn.

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_transmute v0.0.0 (/checkout/compiler/rustc_transmute)
error: pattern overlaps with or-alternative under a guard
   --> compiler/rustc_transmute/src/layout/tree.rs:216:13
    |
216 |             (Self::Seq(elts), other) | (other, Self::Seq(elts)) if elts.len() == 0 => other,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^   ------------------------ overlaps with

error: pattern overlaps with or-alternative under a guard
   --> compiler/rustc_transmute/src/layout/tree.rs:236:13
    |
236 |             (Self::Alt(alts), other) | (other, Self::Alt(alts)) if alts.len() == 0 => other,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^   ------------------------ overlaps with

[RUSTC-TIMING] rustc_transmute test:false 0.736
error: could not compile `rustc_transmute` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: pattern overlaps with or-alternative under a guard
   --> compiler/rustc_infer/src/infer/relate/lattice.rs:154:13
    |
154 |             (&ty::Alias(ty::Opaque, ty::AliasTy { def_id, .. }), _)
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
155 |             | (_, &ty::Alias(ty::Opaque, ty::AliasTy { def_id, .. }))
    |               ------------------------------------------------------- overlaps with

error: pattern overlaps with or-alternative under a guard
   --> compiler/rustc_infer/src/infer/relate/type_relating.rs:191:13
    |
191 |             (&ty::Alias(ty::Opaque, ty::AliasTy { def_id, .. }), _)
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
192 |             | (_, &ty::Alias(ty::Opaque, ty::AliasTy { def_id, .. }))
    |               ------------------------------------------------------- overlaps with

[RUSTC-TIMING] rustc_infer test:false 3.930
error: could not compile `rustc_infer` (lib) due to 2 previous errors
[RUSTC-TIMING] rustc_parse test:false 51.890
[RUSTC-TIMING] rustc_middle test:false 69.924