Rollup of 7 pull requests by matthiaskrgr · Pull Request #143621 · rust-lang/rust

matthiaskrgr · 2025-07-08T01:10:00Z

Successful merges:

Implement int_format_into feature #142098 (Implement int_format_into feature)
Point to correct argument in Func Call when Self type fails trait bound #143567 (Point to correct argument in Func Call when Self type fails trait bound)
consider nested cases for duplicate RPITIT #143570 (consider nested cases for duplicate RPITIT)
remove has_nested from builtin candidates #143571 (remove has_nested from builtin candidates)
Fix wrong cache event query key #143586 (Fix wrong cache event query key)
const-block-as-pattern: do not refer to no-longer-existing nightly feature #143589 (const-block-as-pattern: do not refer to no-longer-existing nightly feature)
Fix in std::String docs #143608 (Fix in std::String docs)

r? @ghost
@rustbot modify labels: rollup

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

When a trait bound fails due to the Self type parameter, adjust_fulfillment_errors now correctly points to the corresponding function argument instead of incorrectly pointing to other arguments. Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

…ature

…Amanieu Implement `int_format_into` feature I took over rust-lang#138338 with `@madhav-madhusoodanan's` approval. Since rust-lang#136264, a lot of changes happened so I made use of them to reduce the number of changes. ACP approval: rust-lang/libs-team#546 (comment) ## Associated Issue - rust-lang#138215 r? `@hanna-kruppe`

Point to correct argument in Func Call when Self type fails trait bound Fixes rust-lang#143336 When a trait bound fails due to the `Self` type parameter, `adjust_fulfillment_errors` now correctly points to the corresponding function argument instead of incorrectly pointing to other arguments. This is because `Call` may also need to handle the `self` parameter, and not just `MethodCall` needs to be handled, as rust-lang#143336. r? compiler

…rrors consider nested cases for duplicate RPITIT Fixes rust-lang#143560 r? `@compiler-errors` cc `@Zoxc`

remove `has_nested` from builtin candidates it's no longer necessary r? types

Fix wrong cache event query key I messed this up in rust-lang#142978. It is only an issue if someone enables the event manually, which almost no-one does, so it could take a while before we found it :D Luckily I noticed it while re-reading the PR. r? `@oli-obk`

const-block-as-pattern: do not refer to no-longer-existing nightly feature Surely everyone who used this nightly feature has fixed their code by now. So let's not confused people on stable that try to use a const block as a pattern by referring to some dead nightly feature.

…trieb Fix in std::String docs This PR removes the word “else” from the sentence ('something else similar') in the String documentation to improve clarity. Fixes rust-lang#143579.

matthiaskrgr · 2025-07-08T01:10:14Z

@bors r+ rollup=never p=5

bors · 2025-07-08T01:10:17Z

📌 Commit fd05071 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-07-08T03:31:02Z

⌛ Testing commit fd05071 with merge 2783fc4...

bors · 2025-07-08T06:31:29Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2783fc4 to master...

rust-timer · 2025-07-08T06:33:30Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142098	Implement `int_format_into` feature	`f539aecad787881135cb37ab27cafb00945a0efe` (link)
#143567	Point to correct argument in Func Call when Self type fails…	`e4bc4db0aee1298c5f7b0de8a94a09b4b7a391ef` (link)
#143570	consider nested cases for duplicate RPITIT	`b3b5168c48c89e76203eb6e096ecdf23e316f10d` (link)
#143571	remove `has_nested` from builtin candidates	`2b2329d2fa68bbe12fd7c87c82021dfb72462bbb` (link)
#143586	Fix wrong cache event query key	`8973205f0bdf4b67899c4f52bf72d796b0faacfb` (link)
#143589	const-block-as-pattern: do not refer to no-longer-existing …	`e368f8912ab25c8451aba5118142eca4fd4b7456` (link)
#143608	Fix in std::String docs	`bb96509a2bf53d776ccd38f1105921d8798c1d65` (link)

previous master: 688ea65df6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-08T06:34:33Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 688ea65 (parent) -> 2783fc4 (this PR)

Test differences

Show 144 test diffs

Stage 1

[ui] tests/ui/impl-trait/in-trait/rpitit-duplicate-associated-fn-with-nested.rs: [missing] -> pass (J1)
[ui] tests/ui/trait-bounds/false-span-in-trait-bound-label.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/impl-trait/in-trait/rpitit-duplicate-associated-fn-with-nested.rs: [missing] -> pass (J0)
[ui] tests/ui/trait-bounds/false-span-in-trait-bound-label.rs: [missing] -> pass (J0)

Additionally, 140 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2783fc43fd13a669f314742890acd64200ad0bbf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 4229.6s -> 6068.2s (43.5%)
dist-x86_64-apple: 11205.1s -> 9384.1s (-16.3%)
x86_64-apple-1: 8284.3s -> 7126.2s (-14.0%)
aarch64-apple: 4727.3s -> 5344.5s (13.1%)
dist-apple-various: 7465.0s -> 6602.1s (-11.6%)
dist-aarch64-apple: 5434.2s -> 5923.0s (9.0%)
dist-x86_64-windows-gnullvm: 5186.0s -> 5532.3s (6.7%)
i686-gnu-1: 8034.5s -> 8562.6s (6.6%)
x86_64-gnu-llvm-20-3: 6641.4s -> 7065.0s (6.4%)
tidy: 69.8s -> 74.0s (5.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-08T07:43:20Z

Finished benchmarking commit (2783fc4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary 0.3%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-2.8%, 3.4%]	2

Cycles

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.817s -> 466.317s (0.11%)
Artifact size: 372.34 MiB -> 372.29 MiB (-0.01%)

GuillaumeGomez and others added 17 commits July 3, 2025 18:57

Implement int_format_into feature

82c6037

Add test for int_format_into feature

7e23144

Use slice_buffer_to_str in GenericRadix::fmt_int

9943c19

Add test tests/ui/trait-bounds/false-span-in-trait-bound-label.rs

cf7e896

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

consider nested cases for duplicate RPITIT

e1720d7

remove has_nested

3ddcf8b

Fix wrong cache event query key

37115f1

const-block-as-pattern: do not refer to no-longer-existing nightly fe…

1a6eff7

…ature

Fix in String docs: remove 'else' from 'something else similar'

2bff99c

Rollup merge of rust-lang#143570 - bvanjoi:issue-143560, r=compiler-e…

a4e05e1

…rrors consider nested cases for duplicate RPITIT Fixes rust-lang#143560 r? `@compiler-errors` cc `@Zoxc`

Rollup merge of rust-lang#143571 - lcnr:has_nested-bb, r=compiler-errors

b29f039

remove `has_nested` from builtin candidates it's no longer necessary r? types

Rollup merge of rust-lang#143608 - codexarafat:fix-string-doc, r=Nora…

fd05071

…trieb Fix in std::String docs This PR removes the word “else” from the sentence ('something else similar') in the String documentation to improve clarity. Fixes rust-lang#143579.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2025

bors merged commit 2783fc4 into rust-lang:master Jul 8, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 8, 2025

bors mentioned this pull request Jul 8, 2025

Instantiate auto trait/Copy/Clone/Sized before computing constituent types binder #143538

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#143621

Rollup of 7 pull requests#143621
bors merged 17 commits intorust-lang:masterfrom
matthiaskrgr:rollup-p1ce8l7

matthiaskrgr commented Jul 8, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 8, 2025

Uh oh!

github-actions bot commented Jul 8, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

matthiaskrgr commented Jul 8, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 8, 2025

Uh oh!

github-actions bot commented Jul 8, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 8, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

matthiaskrgr commented Jul 8, 2025 •

edited by rustbot

Loading