Ports #[macro_use] and #[macro_escape] to the new attribute parsing infrastructure

[JonathanBrouwer]

Ports #[macro_use] and #[macro_escape] to the new attribute parsing infrastructure for #131229 (comment)

r? @jdonszelmann @oli-obk

[rustbot]

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

[JonathanBrouwer]

^ Rebased on #143796
@rustbot ready

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[JonathanBrouwer]

@rustbot ready

[bors]

☔ The latest upstream changes (presumably #143779) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #143460) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #144109) made this pull request unmergeable. Please resolve the merge conflicts.

[JonathanBrouwer]

^ Rebased

[JonathanBrouwer]

r? @oli-obk

[JonathanBrouwer]

@oli-obk I think I handled all your feedback

[oli-obk]

@bors r+ rollup=never (these tend to have some minor perf effect somewhere)

[bors]

📌 Commit 3303534 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3303534 with merge 4ff3fa0...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 4ff3fa0 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5a30e43 (parent) -> 4ff3fa0 (this PR)

Test differences

Show 63 test diffs

Stage 1

• errors::verify_resolve_anonymous_lifetime_non_gat_report_error_44: [missing] -> pass (J0)
• errors::verify_resolve_anonymous_lifetime_non_gat_report_error_45: pass -> [missing] (J0)
• errors::verify_resolve_arguments_macro_use_not_allowed_40: [missing] -> pass (J0)
• errors::verify_resolve_arguments_macro_use_not_allowed_41: pass -> [missing] (J0)
• errors::verify_resolve_attributes_starting_with_rustc_are_reserved_51: [missing] -> pass (J0)
• errors::verify_resolve_attributes_starting_with_rustc_are_reserved_52: pass -> [missing] (J0)
• errors::verify_resolve_bad_macro_import_36: pass -> [missing] (J0)
• errors::verify_resolve_cannot_find_builtin_macro_with_name_54: [missing] -> pass (J0)
• errors::verify_resolve_cannot_find_builtin_macro_with_name_55: pass -> [missing] (J0)
• errors::verify_resolve_cannot_use_through_an_import_52: [missing] -> pass (J0)
• errors::verify_resolve_cannot_use_through_an_import_53: pass -> [missing] (J0)
• errors::verify_resolve_explicit_anonymous_lifetime_report_error_45: [missing] -> pass (J0)
• errors::verify_resolve_explicit_anonymous_lifetime_report_error_46: pass -> [missing] (J0)
• errors::verify_resolve_extern_crate_self_requires_renaming_36: [missing] -> pass (J0)
• errors::verify_resolve_extern_crate_self_requires_renaming_37: pass -> [missing] (J0)
• errors::verify_resolve_generic_arguments_in_macro_path_50: [missing] -> pass (J0)
• errors::verify_resolve_generic_arguments_in_macro_path_51: pass -> [missing] (J0)
• errors::verify_resolve_imported_macro_not_found_38: [missing] -> pass (J0)
• errors::verify_resolve_imported_macro_not_found_39: pass -> [missing] (J0)
• errors::verify_resolve_is_private_49: [missing] -> pass (J0)
• errors::verify_resolve_is_private_50: pass -> [missing] (J0)
• errors::verify_resolve_lending_iterator_report_error_43: [missing] -> pass (J0)
• errors::verify_resolve_lending_iterator_report_error_44: pass -> [missing] (J0)
• errors::verify_resolve_macro_expanded_extern_crate_cannot_shadow_extern_arguments_42: [missing] -> pass (J0)
• errors::verify_resolve_macro_expanded_extern_crate_cannot_shadow_extern_arguments_43: pass -> [missing] (J0)
• errors::verify_resolve_macro_extern_deprecated_39: [missing] -> pass (J0)
• errors::verify_resolve_macro_extern_deprecated_40: pass -> [missing] (J0)
• errors::verify_resolve_macro_use_name_already_in_use_37: [missing] -> pass (J0)
• errors::verify_resolve_macro_use_name_already_in_use_38: pass -> [missing] (J0)
• errors::verify_resolve_name_reserved_in_attribute_namespace_53: [missing] -> pass (J0)
• errors::verify_resolve_name_reserved_in_attribute_namespace_54: pass -> [missing] (J0)
• errors::verify_resolve_static_lifetime_is_reserved_47: [missing] -> pass (J0)
• errors::verify_resolve_static_lifetime_is_reserved_48: pass -> [missing] (J0)
• errors::verify_resolve_tool_only_accepts_identifiers_56: [missing] -> pass (J0)
• errors::verify_resolve_tool_only_accepts_identifiers_57: pass -> [missing] (J0)
• errors::verify_resolve_tool_was_already_registered_55: [missing] -> pass (J0)
• errors::verify_resolve_tool_was_already_registered_56: pass -> [missing] (J0)
• errors::verify_resolve_trait_impl_mismatch_57: [missing] -> pass (J0)
• errors::verify_resolve_trait_impl_mismatch_58: pass -> [missing] (J0)
• errors::verify_resolve_underscore_lifetime_is_reserved_46: [missing] -> pass (J0)
• errors::verify_resolve_underscore_lifetime_is_reserved_47: pass -> [missing] (J0)
• errors::verify_resolve_unnamed_crate_root_import_41: [missing] -> pass (J0)
• errors::verify_resolve_unnamed_crate_root_import_42: pass -> [missing] (J0)
• errors::verify_resolve_variable_is_not_bound_in_all_patterns_48: [missing] -> pass (J0)
• errors::verify_resolve_variable_is_not_bound_in_all_patterns_49: pass -> [missing] (J0)
• [ui] tests/ui/attributes/invalid-macro-use.rs: [missing] -> pass (J1)

Stage 2

• [ui] tests/ui/attributes/invalid-macro-use.rs: [missing] -> pass (J2)

Additionally, 16 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, aarch64-gnu, aarch64-msvc-2, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2
• J1: x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-3
• J2: aarch64-apple, aarch64-gnu, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-2, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-20-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4ff3fa01cbdd468851b1b859541ee1c648cde7de --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. pr-check-2: 2210.3s -> 2671.3s (20.9%)
2. aarch64-apple: 6035.4s -> 4780.5s (-20.8%)
3. dist-apple-various: 6456.6s -> 7529.7s (16.6%)
4. x86_64-rust-for-linux: 2562.7s -> 2988.1s (16.6%)
5. aarch64-gnu-debug: 3804.3s -> 4403.1s (15.7%)
6. dist-x86_64-apple: 8998.5s -> 10207.3s (13.4%)
7. i686-gnu-2: 5403.0s -> 6071.3s (12.4%)
8. x86_64-gnu-tools: 3322.7s -> 3722.1s (12.0%)
9. i686-gnu-1: 7380.5s -> 8224.0s (11.4%)
10. dist-aarch64-apple: 6557.4s -> 7287.8s (11.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (4ff3fa0): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.9%, -0.0%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 2.1%, secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.1%	[5.1%, 5.1%]	1
Regressions ❌ (secondary)	2.4%	[1.3%, 4.3%]	7
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	2.1%	[-1.0%, 5.1%]	2

Cycles

Results (secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-5.1%, -2.7%]	7
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.483s -> 468.179s (0.15%)
Artifact size: 374.67 MiB -> 374.69 MiB (0.01%)

[Mark-Simulacrum]

Not particularly worried about the regressions here, they affect unused-warnings and deep-vector only (and not too high in magnitude) and this is part of larger changes throughout the compiler. Marking as triaged.