pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests by usamoi · Pull Request #143846 · rust-lang/rust

usamoi · 2025-07-12T16:40:42Z

Exported symbols are added as GC roots in linking, so --gc-sections won't hurt -Zexport-executable-symbols.

Fixes the run-make test to work on Linux. Enable the ui test on more targets.

usamoi · 2025-07-12T16:42:30Z

compiler/rustc_codegen_ssa/src/back/link.rs

-        }
+        cmd.gc_sections(keep_metadata);
+    } else {
+        cmd.no_gc_sections();


The removed line is the only place in rustc where no_gc_sections is called, so I had to call it here to suppress the unused warning.

Removing the no_gc_sections method entirely would also work, right? Your current change would change the behavior of -Clink-dead-code=yes, not just the behavior of -Zexport-executable-symbols.

no_gc_sections is removed now.

rustbot · 2025-07-12T17:53:58Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-12T17:54:00Z

This PR modifies run-make tests.

cc @jieyouxu

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

jieyouxu · 2025-07-13T03:32:37Z

Maybe r? @bjorn3 (or reroll)

jieyouxu · 2025-07-13T03:34:47Z

tests/run-make/export-executable-symbols/rmake.rs

+            .invalid_stdout_utf8();
+        assert_contains(&output, "exported_symbol");
+    } else {
+        let output = llvm_readobj().symbols().input(bin_name("main")).run().invalid_stdout_utf8();


Discussion: Hm, this might not be quite right for windows msvc, cc @ChrisDenton ?

llvm-readobj indeed cannot read symbols from MSVC-generated artifacts. I just switched to using the object crate to read the exports.

…ove tests

bjorn3 · 2025-07-14T08:49:03Z

@bors r+

bors · 2025-07-14T08:49:06Z

📌 Commit 5e1c387 has been approved by bjorn3

It is now in the queue for this repository.

pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests Exported symbols are added as GC roots in linking, so `--gc-sections` won't hurt `-Zexport-executable-symbols`. Fixes the run-make test to work on Linux. Enable the ui test on more targets. cc rust-lang#84161

Rollup of 15 pull requests Successful merges: - #142304 (tests: Add `RUST_BACKTRACE` and `-Cpanic` revisions to `panic-main.rs` test) - #143388 (Various refactors to the LTO handling code) - #143409 (Enable xgot feature for mips64 musl targets) - #143592 (UWP: link ntdll functions using raw-dylib) - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143851 (ci cleanup: rustdoc-gui-test now installs browser-ui-test) - #143856 (Linting public reexport of private dependencies) - #143895 (Dont collect assoc ty item bounds from trait where clause for host effect predicates) - #143922 (Improve path segment joining) - #143964 (Fix handling of SCRIPT_ARG in docker images) - #144016 (trait_sel: `MetaSized` always holds temporarily) r? `@ghost` `@rustbot` modify labels: rollup

fmease · 2025-07-17T01:56:42Z

#144041 (comment)
@bors r-

jieyouxu · 2025-07-17T03:02:33Z

You may need something like //@ needs-target-std or //@ ignore-cross-compile if test is host-only.

usamoi · 2025-07-17T08:19:15Z

//@ ignore-cross-compile is added to two tests now.

@rustbot ready

bjorn3 · 2025-07-17T09:02:52Z

@bors r+

bors · 2025-07-17T09:02:54Z

📌 Commit 5bb6b9d has been approved by bjorn3

It is now in the queue for this repository.

pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests Exported symbols are added as GC roots in linking, so `--gc-sections` won't hurt `-Zexport-executable-symbols`. Fixes the run-make test to work on Linux. Enable the ui test on more targets. cc rust-lang#84161

Rollup of 15 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - #143719 (Emit warning when there is no space between `-o` and arg) - #143833 (Ban projecting into SIMD types [MCP838]) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143879 (parse `const trait Trait`) - #143891 (Port `#[coverage]` to the new attribute system) - #143967 (constify `Option` methods) - #143985 (rustc_public: de-StableMIR-ize) - #144008 (Fix false positive double negations with macro invocation) - #144010 (Boostrap: add warning on `optimize = false`) - #144034 (tests: Test line number in debuginfo for diverging function calls) - #144049 (rustc-dev-guide subtree update) - #144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup

pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests Exported symbols are added as GC roots in linking, so `--gc-sections` won't hurt `-Zexport-executable-symbols`. Fixes the run-make test to work on Linux. Enable the ui test on more targets. cc rust-lang#84161

Rollup of 12 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - #143719 (Emit warning when there is no space between `-o` and arg) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143891 (Port `#[coverage]` to the new attribute system) - #143967 (constify `Option` methods) - #144008 (Fix false positive double negations with macro invocation) - #144010 (Boostrap: add warning on `optimize = false`) - #144034 (tests: Test line number in debuginfo for diverging function calls) - #144049 (rustc-dev-guide subtree update) - #144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - #143719 (Emit warning when there is no space between `-o` and arg) - #143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - #143891 (Port `#[coverage]` to the new attribute system) - #143967 (constify `Option` methods) - #144008 (Fix false positive double negations with macro invocation) - #144010 (Boostrap: add warning on `optimize = false`) - #144049 (rustc-dev-guide subtree update) - #144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143846 - usamoi:gc, r=bjorn3 pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests Exported symbols are added as GC roots in linking, so `--gc-sections` won't hurt `-Zexport-executable-symbols`. Fixes the run-make test to work on Linux. Enable the ui test on more targets. cc #84161

Rollup of 11 pull requests Successful merges: - rust-lang/rust#142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - rust-lang/rust#143271 (Store the type of each GVN value) - rust-lang/rust#143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - rust-lang/rust#143719 (Emit warning when there is no space between `-o` and arg) - rust-lang/rust#143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - rust-lang/rust#143891 (Port `#[coverage]` to the new attribute system) - rust-lang/rust#143967 (constify `Option` methods) - rust-lang/rust#144008 (Fix false positive double negations with macro invocation) - rust-lang/rust#144010 (Boostrap: add warning on `optimize = false`) - rust-lang/rust#144049 (rustc-dev-guide subtree update) - rust-lang/rust#144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup

pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests Exported symbols are added as GC roots in linking, so `--gc-sections` won't hurt `-Zexport-executable-symbols`. Fixes the run-make test to work on Linux. Enable the ui test on more targets. cc rust-lang#84161

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - rust-lang#143271 (Store the type of each GVN value) - rust-lang#143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - rust-lang#143719 (Emit warning when there is no space between `-o` and arg) - rust-lang#143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - rust-lang#143891 (Port `#[coverage]` to the new attribute system) - rust-lang#143967 (constify `Option` methods) - rust-lang#144008 (Fix false positive double negations with macro invocation) - rust-lang#144010 (Boostrap: add warning on `optimize = false`) - rust-lang#144049 (rustc-dev-guide subtree update) - rust-lang#144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - rust-lang/rust#142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - rust-lang/rust#143271 (Store the type of each GVN value) - rust-lang/rust#143293 (fix `-Zsanitizer=kcfi` on `#[naked]` functions) - rust-lang/rust#143719 (Emit warning when there is no space between `-o` and arg) - rust-lang/rust#143846 (pass --gc-sections if -Zexport-executable-symbols is enabled and improve tests) - rust-lang/rust#143891 (Port `#[coverage]` to the new attribute system) - rust-lang/rust#143967 (constify `Option` methods) - rust-lang/rust#144008 (Fix false positive double negations with macro invocation) - rust-lang/rust#144010 (Boostrap: add warning on `optimize = false`) - rust-lang/rust#144049 (rustc-dev-guide subtree update) - rust-lang/rust#144056 (Copy GCC sources into the build directory even outside CI) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 12, 2025

usamoi commented Jul 12, 2025

View reviewed changes

usamoi marked this pull request as ready for review July 12, 2025 17:53

rustbot assigned jieyouxu Jul 12, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 12, 2025

rustbot assigned bjorn3 and unassigned jieyouxu Jul 13, 2025

jieyouxu reviewed Jul 13, 2025

View reviewed changes

pass --gc-sections if -Zexport-executable-symbols is enabled and impr…

f58accb

…ove tests

usamoi force-pushed the gc branch from 46616f3 to f58accb Compare July 13, 2025 08:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025

fmease mentioned this pull request Jul 16, 2025

Rollup of 15 pull requests #144041

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2025

remove no_gc_sections

5bb6b9d

usamoi force-pushed the gc branch from 5e1c387 to 5bb6b9d Compare July 17, 2025 06:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025

fmease mentioned this pull request Jul 17, 2025

Rollup of 16 pull requests #144067

Closed

fmease mentioned this pull request Jul 17, 2025

Rollup of 15 pull requests #144071

Closed

matthiaskrgr mentioned this pull request Jul 17, 2025

Rollup of 12 pull requests #144075

Closed

matthiaskrgr mentioned this pull request Jul 18, 2025

Rollup of 11 pull requests #144109

Merged

bors merged commit 79c8f90 into rust-lang:master Jul 18, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 18, 2025

Uh oh!

Conversation

usamoi commented Jul 12, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

usamoi Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjorn3 Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

usamoi Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

jieyouxu commented Jul 13, 2025

Uh oh!

jieyouxu Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

usamoi Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

fmease commented Jul 17, 2025

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

usamoi commented Jul 17, 2025

Uh oh!

bjorn3 commented Jul 17, 2025

Uh oh!

bors commented Jul 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

usamoi commented Jul 12, 2025 •

edited by rustbot

Loading

usamoi Jul 12, 2025 •

edited

Loading

bjorn3 Jul 14, 2025 •

edited

Loading