Skip to content

Don't require eh_personality lang item on targets that have a personality#143893

Open
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
ChrisDenton:eh_personality_optional
Open

Don't require eh_personality lang item on targets that have a personality#143893
ChrisDenton wants to merge 1 commit intorust-lang:mainfrom
ChrisDenton:eh_personality_optional

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jul 13, 2025

MSVC and wasm have personalities of their own so Rust's personality function is never called. The removed library comment has some more details.

@ChrisDenton
Don't unnecessarily require eh_personality
98eadb3 
Some targets already have personality
@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 13, 2025
@ChrisDenton
Copy link
Member Author

ChrisDenton commented Jul 13, 2025

This is a bit of both compiler and libs but I think it's more compiler (as the libs changes trivially follow from the compiler ones) so...

r? compiler

@rustbot rustbot assigned jieyouxu and unassigned jhpratt Jul 13, 2025
@compiler-errors
Copy link
Contributor

compiler-errors commented Jul 13, 2025

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

📌 Commit 98eadb3 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned jieyouxu Jul 13, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 14, 2025
@fmease
Rollup merge of rust-lang#143893 - ChrisDenton:eh_personality_optiona…
62d6214 
…l, r=compiler-errors

Don't require `eh_personality` lang item on targets that have a personality

MSVC and wasm have personalities of their own so Rust's personality function is never called. The removed library  comment has some more details.
@fmease fmease mentioned this pull request Jul 14, 2025
Closed
bors added a commit that referenced this pull request Jul 14, 2025
@bors
Auto merge of #143912 - fmease:rollup-vlt5sn8, r=fmease
4f0c949 
Rollup of 16 pull requests

Successful merges:

 - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`)
 - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure)
 - #143355 (wrapping shift: remove first bitmask and table)
 - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`)
 - #143592 (UWP: link ntdll functions using raw-dylib)
 - #143681 (bootstrap/miri: avoid rebuilds for test builds)
 - #143710 (Updates to random number generation APIs)
 - #143724 (Tidy cleanup)
 - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling)
 - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing)
 - #143868 (warn on align on fields to avoid breaking changes)
 - #143875 (update issue number for `const_trait_impl`)
 - #143881 (Use zero for initialized Once state)
 - #143887 (Run bootstrap tests sooner in the `x test` pipeline)
 - #143893 (Don't require `eh_personality` lang item on targets that have a personality)

Failed merges:

 - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure)
 - #143891 (Port `#[coverage]` to the new attribute system)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 14, 2025
@jhpratt
Rollup merge of rust-lang#143893 - ChrisDenton:eh_personality_optiona…
ff20a84 
…l, r=compiler-errors

Don't require `eh_personality` lang item on targets that have a personality

MSVC and wasm have personalities of their own so Rust's personality function is never called. The removed library  comment has some more details.
@jhpratt jhpratt mentioned this pull request Jul 14, 2025
Closed
bors added a commit that referenced this pull request Jul 14, 2025
@bors
Auto merge of #143916 - jhpratt:rollup-oykjepf, r=jhpratt
c722941 
Rollup of 17 pull requests

Successful merges:

 - #142885 (core: Add `BorrowedCursor::with_unfilled_buf`)
 - #143217 (Port #[link_ordinal] to the new attribute parsing infrastructure)
 - #143355 (wrapping shift: remove first bitmask and table)
 - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`)
 - #143681 (bootstrap/miri: avoid rebuilds for test builds)
 - #143710 (Updates to random number generation APIs)
 - #143724 (Tidy cleanup)
 - #143738 (Move several float tests to floats/mod.rs)
 - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets)
 - #143850 (Compiletest: Simplify {Html,Json}DocCk directive handling)
 - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing)
 - #143868 (warn on align on fields to avoid breaking changes)
 - #143875 (update issue number for `const_trait_impl`)
 - #143881 (Use zero for initialized Once state)
 - #143887 (Run bootstrap tests sooner in the `x test` pipeline)
 - #143893 (Don't require `eh_personality` lang item on targets that have a personality)
 - #143901 (Region constraint nits)

Failed merges:

 - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure)
 - #143891 (Port `#[coverage]` to the new attribute system)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu
Copy link
Member

jieyouxu commented Jul 14, 2025 •
edited
Loading

Could this have caused the rollup failure (#143916) on aaarch64-pc-windows-msvc?

------------------------------------------
error: `#[panic_handler]` function required, but not found

error: aborting due to 1 previous error
------------------------------------------

failures:
    [ui] tests\ui\extern-flag\empty-extern-arg.rs
    [ui] tests\ui\extern-flag\no-force-extern.rs
    [ui] tests\ui\no_std\no-std-unwind-binary.rs
    [ui] tests\ui\panic-handler\weak-lang-item.rs
    [ui] tests\ui\proc-macro\issue-59191-replace-root-with-fn.rs

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2025
@jhpratt
Copy link
Member

jhpratt commented Jul 14, 2025

I wasn't 100% certain either, but this is the only one that seems even remotely related to the error output changing.

@bors
Copy link
Collaborator

bors commented Aug 19, 2025

☔ The latest upstream changes (presumably #145489) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrisDenton @rustbot @compiler-errors @bors @jieyouxu @jhpratt