Skip to content

Rehome ~150 tests/ui/issues/ tests to other subdirectories under tests/ui/#143902

Closed
Oneirical wants to merge 7 commits intorust-lang:masterfrom
Oneirical:uncountable-integer
Closed

Rehome ~150 tests/ui/issues/ tests to other subdirectories under tests/ui/#143902
Oneirical wants to merge 7 commits intorust-lang:masterfrom
Oneirical:uncountable-integer

Conversation

@Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jul 13, 2025 •
edited
Loading

Best reviewed commit-by-commit. I am pushing commits from my local branch as I am personally reviewing them for a first pass.

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

The URL addition at the end, as well as moving around the auxiliary files and editing the stderr files with the new filename, were done using a Python script.

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer branch from 03a9549 to 2441737 Compare July 13, 2025 20:58
@Oneirical Oneirical changed the title Rehome tests/ui/issues/ tests to other subdirectories under tests/ui/ Rehome ~150 tests/ui/issues/ tests to other subdirectories under tests/ui/ Jul 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer branch from 93e148e to 4c6ea67 Compare July 13, 2025 21:35
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer branch from 4c6ea67 to 567002d Compare July 13, 2025 21:46
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer branch from 567002d to 9b5900f Compare July 14, 2025 20:08
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical Oneirical force-pushed the uncountable-integer branch from 9b5900f to 0e9469d Compare July 15, 2025 02:52
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@Oneirical Oneirical marked this pull request as ready for review July 15, 2025 02:53
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2025

There are changes to the tidy tool.

cc @jieyouxu

@bors
Copy link
Collaborator

bors commented Jul 15, 2025

☔ The latest upstream changes (presumably #143958) made this pull request unmergeable. Please resolve the merge conflicts.

@jieyouxu
Copy link
Member

jieyouxu commented Jul 17, 2025 •
edited
Loading

(We discussed to split this into smaller more reviewable chunks.)

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 17, 2025
@Oneirical Oneirical mentioned this pull request Jul 17, 2025
Merged
@Oneirical
Copy link
Contributor Author

Oneirical commented Jul 17, 2025

Closed to divide into smaller fragments.

@Oneirical Oneirical closed this Jul 17, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 17, 2025
tgross35 added a commit to tgross35/rust that referenced this pull request Jul 26, 2025
@tgross35
Rollup merge of rust-lang#144089 - Oneirical:uncountable-integer-1, r…
9c13f4f 
…=jieyouxu

Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang#143902 divided into smaller, easier to review chunks.

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script.

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
rust-timer added a commit that referenced this pull request Jul 26, 2025
@rust-timer
Unrolled build for #144089
cb172db 
Rollup merge of #144089 - Oneirical:uncountable-integer-1, r=jieyouxu

Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

The URL addition at the end, as well as moving around the auxiliary files and editing the `stderr` files with the new filename, were done using a Python script.

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
This was referenced Jul 27, 2025
Merged
Merged
Merged
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 4, 2025
@samueltardieu
Rollup merge of rust-lang#144548 - Oneirical:uncountable-integer-2, r…
fbe91ed 
…=jieyouxu

Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang#143902 divided into smaller, easier to review chunks.

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 5, 2025
@samueltardieu
Rollup merge of rust-lang#144548 - Oneirical:uncountable-integer-2, r…
58b00b0 
…=jieyouxu

Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang#143902 divided into smaller, easier to review chunks.

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
rust-timer added a commit that referenced this pull request Aug 5, 2025
@rust-timer
Unrolled build for #144548
f6c4cc1 
Rollup merge of #144548 - Oneirical:uncountable-integer-2, r=jieyouxu

Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 6, 2025
@Zalathar
Rollup merge of rust-lang#144552 - Oneirical:uncountable-integer-3, r…
216c285 
…=jieyouxu

Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang#143902 divided into smaller, easier to review chunks.

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
Kobzol added a commit to Kobzol/rust that referenced this pull request Aug 6, 2025
@Kobzol
Rollup merge of rust-lang#144552 - Oneirical:uncountable-integer-3, r…
e89ae47 
…=jieyouxu

Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang#143902 divided into smaller, easier to review chunks.

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
rust-timer added a commit that referenced this pull request Aug 6, 2025
@rust-timer
Unrolled build for #144552
94071e2 
Rollup merge of #144552 - Oneirical:uncountable-integer-3, r=jieyouxu

Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 7, 2025
@samueltardieu
Rollup merge of #144548 - Oneirical:uncountable-integer-2, r=jieyouxu
f73c825 
Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang/rust#143902 divided into smaller, easier to review chunks.

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 7, 2025
@Kobzol
Rollup merge of #144552 - Oneirical:uncountable-integer-3, r=jieyouxu
efb1682 
Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang/rust#143902 divided into smaller, easier to review chunks.

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 10, 2025
@jhpratt
Rollup merge of rust-lang#144553 - Oneirical:uncountable-integer-4, r…
5bd4e83 
…=jieyouxu

Rehome 32 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang#143902 divided into smaller, easier to review chunks.

Part of rust-lang#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
rust-timer added a commit that referenced this pull request Aug 10, 2025
@rust-timer
Unrolled build for #144553
a0c0b14 
Rollup merge of #144553 - Oneirical:uncountable-integer-4, r=jieyouxu

Rehome 32 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that `@Kivooeo` was using.

r? `@jieyouxu`
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Aug 11, 2025
@samueltardieu
Rollup merge of #144548 - Oneirical:uncountable-integer-2, r=jieyouxu
6fbc490 
Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang/rust#143902 divided into smaller, easier to review chunks.

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
Kobzol added a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@Kobzol
Rollup merge of #144552 - Oneirical:uncountable-integer-3, r=jieyouxu
f94a555 
Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`

rust-lang/rust#143902 divided into smaller, easier to review chunks.

Part of rust-lang/rust#133895

Methodology:

1. Refer to the previously written `tests/ui/SUMMARY.md`
2. Find an appropriate category for the test, using the original issue thread and the test contents.
3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
4. Rename the tests to make their purpose clearer

Inspired by the methodology that ``@Kivooeo`` was using.

r? ``@jieyouxu``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Oneirical @rust-log-analyzer @rustbot @bors @jieyouxu