Make more of codegen_llvm safe by oli-obk · Pull Request #143920 · rust-lang/rust

oli-obk · 2025-07-14T09:09:46Z

Best reviewed commit-by-commit.

rustbot · 2025-07-14T09:09:51Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-14T09:09:54Z

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

jieyouxu

Thanks

jieyouxu · 2025-07-14T11:23:13Z

@bors r+

bors · 2025-07-14T11:23:15Z

📌 Commit 7f95f04 has been approved by jieyouxu

It is now in the queue for this repository.

Make more of codegen_llvm safe Best reviewed commit-by-commit.

samueltardieu · 2025-07-15T15:50:41Z

@bors rollup=iffy
It might make simultaneously merged PR fail as in #143974 (comment).

Make more of codegen_llvm safe Best reviewed commit-by-commit.

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143891 (Port `#[coverage]` to the new attribute system) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) r? `@ghost` `@rustbot` modify labels: rollup

Make more of codegen_llvm safe Best reviewed commit-by-commit.

bors · 2025-07-15T17:55:33Z

⌛ Testing commit 7f95f04 with merge 26d4616...

samueltardieu · 2025-07-15T18:01:08Z

@bors r=jieyouxu

bors · 2025-07-15T18:01:11Z

📌 Commit 7f95f04 has been approved by jieyouxu

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143891 (Port `#[coverage]` to the new attribute system) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-07-15T18:20:35Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143891 (Port `#[coverage]` to the new attribute system) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) r? `@ghost` `@rustbot` modify labels: rollup

oli-obk · 2025-07-15T19:15:54Z

@bors retry error: could not lock config file C:/msys64/home/runneradmin/.gitconfig: No such file or directory

samueltardieu · 2025-07-15T19:17:29Z

could not lock config file C:/msys64/home/runneradmin/.gitconfig: No such file or directory

Related: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/with/528921444

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143891 (Port `#[coverage]` to the new attribute system) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) r? `@ghost` `@rustbot` modify labels: rollup

Make more of codegen_llvm safe Best reviewed commit-by-commit.

Rollup of 13 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143957 (tidy: check for invalid file names) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - #143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143738 (Move several float tests to floats/mod.rs) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143957 (tidy: check for invalid file names) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - #143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143920 - oli-obk:cg-llvm-safety, r=jieyouxu Make more of codegen_llvm safe Best reviewed commit-by-commit.

Rollup of 12 pull requests Successful merges: - rust-lang/rust#142936 (rustdoc-json: Structured attributes) - rust-lang/rust#143355 (wrapping shift: remove first bitmask and table) - rust-lang/rust#143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - rust-lang/rust#143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - rust-lang/rust#143738 (Move several float tests to floats/mod.rs) - rust-lang/rust#143920 (Make more of codegen_llvm safe) - rust-lang/rust#143921 (Constify `Index` traits) - rust-lang/rust#143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - rust-lang/rust#143948 (Update mdbook to 0.4.52) - rust-lang/rust#143957 (tidy: check for invalid file names) - rust-lang/rust#143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - rust-lang/rust#143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Make more of codegen_llvm safe Best reviewed commit-by-commit.

…eltardieu Rollup of 12 pull requests Successful merges: - rust-lang#142936 (rustdoc-json: Structured attributes) - rust-lang#143355 (wrapping shift: remove first bitmask and table) - rust-lang#143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - rust-lang#143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - rust-lang#143738 (Move several float tests to floats/mod.rs) - rust-lang#143920 (Make more of codegen_llvm safe) - rust-lang#143921 (Constify `Index` traits) - rust-lang#143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - rust-lang#143948 (Update mdbook to 0.4.52) - rust-lang#143957 (tidy: check for invalid file names) - rust-lang#143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - rust-lang#143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

oli-obk added 5 commits July 14, 2025 08:27

Avoid a bunch of unnecessary unsafe blocks in cg_llvm

d3d51b4

Shrink some unsafe blocks in cg_llvm

e574fef

Merge typeid_metadata and create_metadata

b9baf63

Use context methods instead of directly calling FFI

56d22cd

Eliminate all direct uses of LLVMMDStringInContext2

7f95f04

rustbot assigned jieyouxu Jul 14, 2025

jieyouxu approved these changes Jul 14, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jul 15, 2025

Rollup merge of rust-lang#143920 - oli-obk:cg-llvm-safety, r=jieyouxu

71c8419

Make more of codegen_llvm safe Best reviewed commit-by-commit.

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 12 pull requests #143974

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 11 pull requests #143976

Closed

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jul 15, 2025

Rollup merge of rust-lang#143920 - oli-obk:cg-llvm-safety, r=jieyouxu

4a3608a

Make more of codegen_llvm safe Best reviewed commit-by-commit.

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 11 pull requests #143978

Closed

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jul 15, 2025

Rollup merge of rust-lang#143920 - oli-obk:cg-llvm-safety, r=jieyouxu

98cbbd0

Make more of codegen_llvm safe Best reviewed commit-by-commit.

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 10 pull requests #143982

Closed

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jul 15, 2025

Rollup merge of rust-lang#143920 - oli-obk:cg-llvm-safety, r=jieyouxu

89f63b3

Make more of codegen_llvm safe Best reviewed commit-by-commit.

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 12 pull requests #143983

Closed

bors added a commit that referenced this pull request Jul 15, 2025

Auto merge of #143920 - oli-obk:cg-llvm-safety, r=jieyouxu

26d4616

Make more of codegen_llvm safe Best reviewed commit-by-commit.

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jul 16, 2025

Rollup merge of rust-lang#143920 - oli-obk:cg-llvm-safety, r=jieyouxu

cc3d3c9

Make more of codegen_llvm safe Best reviewed commit-by-commit.

samueltardieu mentioned this pull request Jul 16, 2025

Rollup of 13 pull requests #144017

Closed

samueltardieu mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144028

Merged

bors merged commit b564ecf into rust-lang:master Jul 16, 2025
11 of 12 checks passed

rustbot added this to the 1.90.0 milestone Jul 16, 2025

rust-timer added a commit that referenced this pull request Jul 16, 2025

Unrolled build for #143920

09bbc4f

Rollup merge of #143920 - oli-obk:cg-llvm-safety, r=jieyouxu Make more of codegen_llvm safe Best reviewed commit-by-commit.

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025

Rollup merge of rust-lang#143920 - oli-obk:cg-llvm-safety, r=jieyouxu

5418385

Make more of codegen_llvm safe Best reviewed commit-by-commit.

ZuseZ4 mentioned this pull request Oct 28, 2025

Build from source with autodiff fails on Mac OS #147985

Closed

Uh oh!

Conversation

oli-obk commented Jul 14, 2025

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

rust-log-analyzer commented Jul 15, 2025

Uh oh!

oli-obk commented Jul 15, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants