Remove deprecated fields in bootstrap by Shourya742 · Pull Request #143926 · rust-lang/rust

Shourya742 · 2025-07-14T11:56:02Z

This PR removes deprecated fields:

description - part of rust toml
ccache - part of llvm toml

rustbot · 2025-07-14T11:56:06Z

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-14T11:56:08Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

jieyouxu

Can you add a warn-level change tracker entry?

Shourya742 · 2025-07-14T12:48:07Z

Can you add a warn-level change tracker entry?

Added here: 648f7c0

jieyouxu

Thanks

jieyouxu · 2025-07-14T12:54:41Z

r=me after PR CI is green.
r? jieyouxu
@bors delegate+ rollup

bors · 2025-07-14T12:54:45Z

✌️ @Shourya742, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Shourya742 · 2025-07-14T14:13:34Z

@bors r=@jieyouxu

bors · 2025-07-14T14:13:37Z

📌 Commit 648f7c0 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2025-07-14T15:41:57Z

I think you'll need to re-approve when you force push after approval, or else it might be the old approved commit that gets merged.
@bors r+

bors · 2025-07-14T15:42:00Z

📌 Commit c599760 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2025-07-14T15:45:19Z

@bors r-

jieyouxu · 2025-07-14T15:46:48Z

Can you please also squash the commits? r=me after PR CI is green.

Shourya742 · 2025-07-14T17:16:13Z

@bors r=@jieyouxu

Rollup of 16 pull requests Successful merges: - #142301 (tests: Fix duplicated-path-in-error fail with musl) - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143630 (Drop `./x suggest`) - #143738 (Move several float tests to floats/mod.rs) - #143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143837 (Adjust `run_make_support::symbols` helpers) - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143907 (core: make `str::split_at_unchecked()` inline) - #143910 (Add experimental `backtrace-trace-only` std feature) - #143927 (Preserve constness in trait objects up to hir ty lowering) - #143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - #143938 (Update books) - #143941 (update `cfg_select!` documentation) - #143948 (Update mdbook to 0.4.52) Failed merges: - #143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 13 pull requests Successful merges: - #142301 (tests: Fix duplicated-path-in-error fail with musl) - #143630 (Drop `./x suggest`) - #143736 (Give all bytes of TypeId provenance) - #143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - #143837 (Adjust `run_make_support::symbols` helpers) - #143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - #143905 (Recover and suggest to use `;` to construct array type) - #143907 (core: make `str::split_at_unchecked()` inline) - #143910 (Add experimental `backtrace-trace-only` std feature) - #143927 (Preserve constness in trait objects up to hir ty lowering) - #143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - #143938 (Update books) - #143941 (update `cfg_select!` documentation) Failed merges: - #143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-15T14:47:07Z

☔ The latest upstream changes (presumably #143958) made this pull request unmergeable. Please resolve the merge conflicts.

Shourya742 · 2025-07-15T17:53:52Z

@bors r=@jieyouxu

bors · 2025-07-15T17:53:54Z

📌 Commit 306928f has been approved by jieyouxu

It is now in the queue for this repository.

…cated-fields, r=jieyouxu Remove deprecated fields in bootstrap This PR removes deprecated fields: 1. `description` - part of rust toml 2. `ccache` - part of llvm toml

Rollup of 11 pull requests Successful merges: - #143595 (add `const_make_global`; err for `const_allocate` ptrs if didn't call) - #143678 (Added error for invalid char cast) - #143793 (Opaque type collection: Guard against endlessly recursing free alias types) - #143820 (Fixed a core crate compilation failure when enabling the `optimize_for_size` feature on some targets) - #143829 (Trim `BorrowedCursor` API) - #143856 (Linting public reexport of private dependencies) - #143891 (Port `#[coverage]` to the new attribute system) - #143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - #143922 (Improve path segment joining) - #143926 (Remove deprecated fields in bootstrap) - #143975 (type_id_eq: check that the hash fully matches the type) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 13 pull requests Successful merges: - rust-lang/rust#142301 (tests: Fix duplicated-path-in-error fail with musl) - rust-lang/rust#143630 (Drop `./x suggest`) - rust-lang/rust#143736 (Give all bytes of TypeId provenance) - rust-lang/rust#143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - rust-lang/rust#143837 (Adjust `run_make_support::symbols` helpers) - rust-lang/rust#143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - rust-lang/rust#143905 (Recover and suggest to use `;` to construct array type) - rust-lang/rust#143907 (core: make `str::split_at_unchecked()` inline) - rust-lang/rust#143910 (Add experimental `backtrace-trace-only` std feature) - rust-lang/rust#143927 (Preserve constness in trait objects up to hir ty lowering) - rust-lang/rust#143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - rust-lang/rust#143938 (Update books) - rust-lang/rust#143941 (update `cfg_select!` documentation) Failed merges: - rust-lang/rust#143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - #143326 (Remove deprecated `Error::description` impl from `c_str::FromBytesWithNulError`) - #143431 (Use relative visibility when noting sealed trait to reduce false positive) - #143550 (resolve: Use interior mutability for extern module map) - #143631 (update to literal-escaper-0.0.5) - #143793 (Opaque type collection: Guard against endlessly recursing free alias types) - #143880 (tests: Test line debuginfo for linebreaked function parameters) - #143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - #143926 (Remove deprecated fields in bootstrap) - #143955 (Make frame spans appear on a separate trace line) - #143975 (type_id_eq: check that the hash fully matches the type) - #143984 (Fix ice for feature-gated `cfg` attributes applied to the crate) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143926 - Shourya742:2025-07-14-remove-deprecated-fields, r=jieyouxu Remove deprecated fields in bootstrap This PR removes deprecated fields: 1. `description` - part of rust toml 2. `ccache` - part of llvm toml

rust.description was deprecated and now is being removed. These are equivalent according to the code in rust-lang/rust#143926, so no need for a package rebuild. Fixed: 432494675 Change-Id: I1d591ca88a29b9691f389da6a074857801f15b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6765864 Reviewed-by: Zequan Wu <zequanwu@google.com> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/main@{#1488435}

Rollup of 11 pull requests Successful merges: - rust-lang/rust#143326 (Remove deprecated `Error::description` impl from `c_str::FromBytesWithNulError`) - rust-lang/rust#143431 (Use relative visibility when noting sealed trait to reduce false positive) - rust-lang/rust#143550 (resolve: Use interior mutability for extern module map) - rust-lang/rust#143631 (update to literal-escaper-0.0.5) - rust-lang/rust#143793 (Opaque type collection: Guard against endlessly recursing free alias types) - rust-lang/rust#143880 (tests: Test line debuginfo for linebreaked function parameters) - rust-lang/rust#143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - rust-lang/rust#143926 (Remove deprecated fields in bootstrap) - rust-lang/rust#143955 (Make frame spans appear on a separate trace line) - rust-lang/rust#143975 (type_id_eq: check that the hash fully matches the type) - rust-lang/rust#143984 (Fix ice for feature-gated `cfg` attributes applied to the crate) r? `@ghost` `@rustbot` modify labels: rollup

…cated-fields, r=jieyouxu Remove deprecated fields in bootstrap This PR removes deprecated fields: 1. `description` - part of rust toml 2. `ccache` - part of llvm toml

…eltardieu Rollup of 13 pull requests Successful merges: - rust-lang#142301 (tests: Fix duplicated-path-in-error fail with musl) - rust-lang#143630 (Drop `./x suggest`) - rust-lang#143736 (Give all bytes of TypeId provenance) - rust-lang#143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - rust-lang#143837 (Adjust `run_make_support::symbols` helpers) - rust-lang#143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - rust-lang#143905 (Recover and suggest to use `;` to construct array type) - rust-lang#143907 (core: make `str::split_at_unchecked()` inline) - rust-lang#143910 (Add experimental `backtrace-trace-only` std feature) - rust-lang#143927 (Preserve constness in trait objects up to hir ty lowering) - rust-lang#143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - rust-lang#143938 (Update books) - rust-lang#143941 (update `cfg_select!` documentation) Failed merges: - rust-lang#143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#143326 (Remove deprecated `Error::description` impl from `c_str::FromBytesWithNulError`) - rust-lang#143431 (Use relative visibility when noting sealed trait to reduce false positive) - rust-lang#143550 (resolve: Use interior mutability for extern module map) - rust-lang#143631 (update to literal-escaper-0.0.5) - rust-lang#143793 (Opaque type collection: Guard against endlessly recursing free alias types) - rust-lang#143880 (tests: Test line debuginfo for linebreaked function parameters) - rust-lang#143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - rust-lang#143926 (Remove deprecated fields in bootstrap) - rust-lang#143955 (Make frame spans appear on a separate trace line) - rust-lang#143975 (type_id_eq: check that the hash fully matches the type) - rust-lang#143984 (Fix ice for feature-gated `cfg` attributes applied to the crate) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned clubby789 Jul 14, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 14, 2025

jieyouxu reviewed Jul 14, 2025

View reviewed changes

Shourya742 requested a review from jieyouxu July 14, 2025 12:48

jieyouxu approved these changes Jul 14, 2025

View reviewed changes

rustbot assigned jieyouxu and unassigned clubby789 Jul 14, 2025

Shourya742 changed the title ~~Remove description fields in bootstrap~~ Remove deprecated fields in bootstrap Jul 14, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025

Shourya742 force-pushed the 2025-07-14-remove-deprecated-fields branch from 648f7c0 to dee86e6 Compare July 14, 2025 15:36

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jul 14, 2025

This comment has been minimized.

Sign in to view

Shourya742 force-pushed the 2025-07-14-remove-deprecated-fields branch from dee86e6 to c599760 Compare July 14, 2025 15:39

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2025

This comment was marked as resolved.

Sign in to view

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 13 pull requests #143958

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2025

Shourya742 added 3 commits July 15, 2025 21:59

remove description from rust toml struct

e7f5bbe

remove ccache from llvm

76967af

update change tracking with warning on removal of fields.

306928f

Shourya742 force-pushed the 2025-07-14-remove-deprecated-fields branch from c599760 to 306928f Compare July 15, 2025 16:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144036

Closed

matthiaskrgr mentioned this pull request Jul 16, 2025

Rollup of 11 pull requests #144038

Closed

matthiaskrgr mentioned this pull request Jul 17, 2025

Rollup of 11 pull requests #144058

Merged

bors merged commit c97c38b into rust-lang:master Jul 17, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 17, 2025

Uh oh!

Conversation

Shourya742 commented Jul 14, 2025

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Shourya742 commented Jul 14, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

Shourya742 commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

This comment has been minimized.

jieyouxu commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

jieyouxu commented Jul 14, 2025

Uh oh!

This comment was marked as resolved.

jieyouxu commented Jul 14, 2025

Uh oh!

Shourya742 commented Jul 14, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Shourya742 commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants