Skip to content

Remove install Rust script from CI#144053

Merged
bors merged 1 commit intorust-lang:masterfrom
Kobzol:ci-remove-install-rust
Jul 31, 2025
Merged

Remove install Rust script from CI#144053
bors merged 1 commit intorust-lang:masterfrom
Kobzol:ci-remove-install-rust

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 17, 2025 •
edited
Loading

Windows ARM images should contain Rust now (actions/partner-runner-images#77 (comment)).

CC dpaoliello

try-job: *aarch64-msvc*

@Kobzol
Remove install Rust script from CI
b7d2782 
Windows ARM images should contain Rust now.
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 17, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 17, 2025

@bors2 try

@rust-bors
Copy link
Contributor

rust-bors bot commented Jul 17, 2025

⌛ Trying commit b7d2782 with merge 3661f18…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 17, 2025
@rust-bors
Auto merge of #144053 - Kobzol:ci-remove-install-rust, r=<try>
3661f18 
Remove install Rust script from CI

Windows ARM images should contain Rust now (actions/partner-runner-images#77 (comment)).

CC `@dpaoliello`

try-job: `aarch64-msvc*`
@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Jul 17, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jul 17, 2025

You can r=me once try job is 🟢

jieyouxu
jieyouxu approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rust-bors
Copy link
Contributor

rust-bors bot commented Jul 17, 2025

💥 Test timed out

@Kobzol
Copy link
Member Author

Kobzol commented Jul 17, 2025

Hmm, maybe we have missed a webhook in bors, I'll take a look. In any case, isn't relevant to this PR, the jobs actually succeeded.

@bors r=jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

📌 Commit b7d2782 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
@Kobzol Kobzol mentioned this pull request Jul 17, 2025
Merged
@Kobzol
Copy link
Member Author

Kobzol commented Jul 17, 2025

Yeah it looks like there was some race condition around handling of check suites. I added more logging (rust-lang/bors#359).

Kobzol added a commit to Kobzol/rust that referenced this pull request Jul 17, 2025
@Kobzol
Rollup merge of rust-lang#144053 - Kobzol:ci-remove-install-rust, r=j…
0f552cd 
…ieyouxu

Remove install Rust script from CI

Windows ARM images should contain Rust now (actions/partner-runner-images#77 (comment)).

CC dpaoliello

try-job: `*aarch64-msvc*`
@Kobzol Kobzol mentioned this pull request Jul 17, 2025
Closed
bors added a commit that referenced this pull request Jul 18, 2025
@bors
Auto merge of #144085 - Kobzol:rollup-ty9p3ut, r=Kobzol
236c377 
Rollup of 10 pull requests

Successful merges:

 - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - #143649 (Add test for `default_field_values` and `const_default`)
 - #144010 (Boostrap: add warning on `optimize = false`)
 - #144029 (Fix wrong messages from methods with the same name from different traits)
 - #144049 (rustc-dev-guide subtree update)
 - #144053 (Remove install Rust script from CI)
 - #144056 (Copy GCC sources into the build directory even outside CI)
 - #144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels)
 - #144069 (ci: use windows 22 for all free runners)
 - #144083 (miri sleep tests: increase slack)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 18, 2025
@jhpratt
Rollup merge of rust-lang#144053 - Kobzol:ci-remove-install-rust, r=j…
5470de2 
…ieyouxu

Remove install Rust script from CI

Windows ARM images should contain Rust now (actions/partner-runner-images#77 (comment)).

CC dpaoliello

try-job: `*aarch64-msvc*`
@jhpratt jhpratt mentioned this pull request Jul 18, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#144053 - Kobzol:ci-remove-install-rust, r=j…
ab59326 
…ieyouxu

Remove install Rust script from CI

Windows ARM images should contain Rust now (actions/partner-runner-images#77 (comment)).

CC dpaoliello

try-job: `*aarch64-msvc*`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2025
Closed
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Jul 18, 2025

@bors r-
#144085 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 18, 2025

Hmm, clearly the try build and the auto build executed different base ARM Windows images.. what a mess. I'll let this sleep for a bit, until GitHub propagates the new images properly.

@Kobzol Kobzol marked this pull request as draft July 18, 2025 07:24
@jieyouxu
Copy link
Member

jieyouxu commented Jul 18, 2025

Ah yeah, gradual rollouts

@RalfJung
Copy link
Member

RalfJung commented Jul 19, 2025

FWIW in Miri we are also still seeing images without Rust (https://github.com/rust-lang/miri/actions/runs/16386521629/job/46306799159?pr=4479).

@Kobzol
Copy link
Member Author

Kobzol commented Jul 31, 2025

Apparently now it should be there (actions/partner-runner-images#77 (comment)). Trying again.

@bors try

rust-bors bot added a commit that referenced this pull request Jul 31, 2025
@rust-bors
Auto merge of #144053 - Kobzol:ci-remove-install-rust, r=<try>
e261455 
Remove install Rust script from CI

try-job: `*aarch64-msvc*`
@rust-bors
Copy link
Contributor

rust-bors bot commented Jul 31, 2025

⌛ Trying commit b7d2782 with merge e261455…

To cancel the try build, run the command @bors try cancel.

@RalfJung
Copy link
Member

RalfJung commented Jul 31, 2025

In Miri CI, indeed we are seeing rustup in the base image now.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jul 31, 2025

☀️ Try build successful (CI)
Build commit: e261455 (e261455a382c2bce2ac0171587fa16f663823419, parent: 32e7a4b92b109c24e9822c862a7c74436b50e564)

@Kobzol Kobzol marked this pull request as ready for review July 31, 2025 09:12
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jul 31, 2025

r? marcoieni

@rustbot rustbot assigned marcoieni and unassigned jieyouxu Jul 31, 2025
@marcoieni
Copy link
Member

marcoieni commented Jul 31, 2025

@bors r+

Hopefully the rollout of the new image is over and they won't assign us the old image

@bors
Copy link
Collaborator

bors commented Jul 31, 2025

📌 Commit b7d2782 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025
@samueltardieu samueltardieu mentioned this pull request Jul 31, 2025
Merged
bors added a commit that referenced this pull request Jul 31, 2025
@bors
Auto merge of #144731 - samueltardieu:rollup-36y30k2, r=samueltardieu
3fb1b53 
Rollup of 4 pull requests

Successful merges:

 - #136840 (Fix linker-plugin-lto only doing thin lto)
 - #144053 (Remove install Rust script from CI)
 - #144297 (Make `libtest::ERROR_EXIT_CODE` const public to not redefine it in rustdoc)
 - #144721 (`std_detect`: Linux 6.16 support for RISC-V)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d5baad into rust-lang:master Jul 31, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 31, 2025
rust-timer added a commit that referenced this pull request Jul 31, 2025
@rust-timer
Unrolled build for #144053
fae084f 
Rollup merge of #144053 - Kobzol:ci-remove-install-rust, r=marcoieni

Remove install Rust script from CI

Windows ARM images should contain Rust now (actions/partner-runner-images#77 (comment)).

CC dpaoliello

try-job: `*aarch64-msvc*`
@Kobzol Kobzol deleted the ci-remove-install-rust branch July 31, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@marcoieni marcoieni

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Kobzol @rustbot @jieyouxu @bors @matthiaskrgr @RalfJung @marcoieni @Mark-Simulacrum