Skip to content

Don't test panic=unwind in panic_main.rs on Fuchsia#144073

Merged
bors merged 1 commit intorust-lang:masterfrom
erickt:ignore-test-on-fuchsia
Jul 19, 2025
Merged

Don't test panic=unwind in panic_main.rs on Fuchsia#144073
bors merged 1 commit intorust-lang:masterfrom
erickt:ignore-test-on-fuchsia

Conversation

@erickt
Copy link
Contributor

@erickt erickt commented Jul 17, 2025 •
edited
Loading

@Enselic added a few new test conditions to tests/ui/panics/panic-main.rs in #142304, but it is unfortunately causing the test to fail for Fuchsia with the panic=unwind modes since we compile Rust for Fuchsia with panic=abort. This patch just ignores the test for Fuchsia.

Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.

cc @compile-errors, who reviewed the initial PR

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

Failed to set assignee to compile-errors: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2025
@lqd
Copy link
Member

lqd commented Jul 17, 2025 •
edited
Loading

r? lqd

r=me when CI is green close
@bors delegate+
@bors rollup

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

✌️ @erickt, you can now approve this pull request!

If @lqd told you to "r=me" after making some further change, please make that change, then do @bors r=@lqd

@lqd
Copy link
Member

lqd commented Jul 17, 2025 •
edited
Loading

actually, I think we should just mark them as needs-unwind instead of ignoring for fuchsia, and then we can run other builders to test it out. No need to make multiple changes to ignore some platform after the other imo.

@erickt
Copy link
Contributor Author

erickt commented Jul 17, 2025

@lqd good idea, I'll switch to needs-unwind.

@erickt
panic_main.rs panic=unwind tests needs unwinding
0a71873 
Only run the panic=unwind tests on platforms that support unwinding.
@erickt erickt force-pushed the ignore-test-on-fuchsia branch from 1283116 to 0a71873 Compare July 17, 2025 15:42
@erickt
Copy link
Contributor Author

erickt commented Jul 17, 2025

@bors r=@lqd

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

📌 Commit 0a71873 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 18, 2025
@jhpratt
Rollup merge of rust-lang#144073 - erickt:ignore-test-on-fuchsia, r=lqd
0dad5ea 
Don't test panic=unwind in panic_main.rs on Fuchsia

`@Enselic` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia.

Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.

cc `@compile-errors,` who reviewed the initial PR
@jhpratt jhpratt mentioned this pull request Jul 18, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#144073 - erickt:ignore-test-on-fuchsia, r=lqd
ffab549 
Don't test panic=unwind in panic_main.rs on Fuchsia

``@Enselic`` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia.

Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.

cc ``@compile-errors,`` who reviewed the initial PR
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#144073 - erickt:ignore-test-on-fuchsia, r=lqd
daa32df 
Don't test panic=unwind in panic_main.rs on Fuchsia

```@Enselic``` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia.

Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.

cc ```@compile-errors,``` who reviewed the initial PR
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2025
Closed
@bjorn3 bjorn3 mentioned this pull request Jul 18, 2025
Closed
@tshepang tshepang mentioned this pull request Jul 18, 2025
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 19, 2025
Merged
bors added a commit that referenced this pull request Jul 19, 2025
@bors
Auto merge of #144166 - matthiaskrgr:rollup-wccepuo, r=matthiaskrgr
12865ff 
Rollup of 10 pull requests

Successful merges:

 - #141076 (fix Zip unsoundness (again))
 - #142444 (adding run-make test to autodiff)
 - #143704 (Be a bit more careful around exotic cycles in in the inliner)
 - #144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - #144083 (miri sleep tests: increase slack)
 - #144092 (bootstrap: Detect musl hosts)
 - #144098 (Do not lint private-in-public for RPITIT)
 - #144103 (Rename `emit_unless` to `emit_unless_delay`)
 - #144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - #144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5e2416f into rust-lang:master Jul 19, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 19, 2025
rust-timer added a commit that referenced this pull request Jul 19, 2025
@rust-timer
Unrolled build for #144073
a2c0675 
Rollup merge of #144073 - erickt:ignore-test-on-fuchsia, r=lqd

Don't test panic=unwind in panic_main.rs on Fuchsia

````@Enselic```` added a few new test conditions to tests/ui/panics/panic-main.rs in #142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia.

Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.

cc ````@compile-errors,```` who reviewed the initial PR
@Enselic Enselic mentioned this pull request Jul 19, 2025
Merged
5 tasks
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144166 - matthiaskrgr:rollup-wccepuo, r=matthiaskrgr
5d22359 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#141076 (fix Zip unsoundness (again))
 - rust-lang/rust#142444 (adding run-make test to autodiff)
 - rust-lang/rust#143704 (Be a bit more careful around exotic cycles in in the inliner)
 - rust-lang/rust#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - rust-lang/rust#144083 (miri sleep tests: increase slack)
 - rust-lang/rust#144092 (bootstrap: Detect musl hosts)
 - rust-lang/rust#144098 (Do not lint private-in-public for RPITIT)
 - rust-lang/rust#144103 (Rename `emit_unless` to `emit_unless_delay`)
 - rust-lang/rust#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - rust-lang/rust#144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@matthiaskrgr @Muscraft
Rollup merge of rust-lang#144073 - erickt:ignore-test-on-fuchsia, r=lqd
f2f0978 
Don't test panic=unwind in panic_main.rs on Fuchsia

````@Enselic```` added a few new test conditions to tests/ui/panics/panic-main.rs in rust-lang#142304, but it is unfortunately causing the test to fail for Fuchsia with the `panic=unwind` modes since we compile Rust for Fuchsia with `panic=abort`. This patch just ignores the test for Fuchsia.

Note that this test might also need to filter out a few other platforms, since another panicking test we exclude from Fuchsia https://github.com/rust-lang/rust/blob/master/tests/ui/panics/runtime-switch.rs also excludes running on msvc, android, openbsd, and wasm, but I'm not familiar with those platforms so I didn't want to add them here.

cc ````@compile-errors,```` who reviewed the initial PR
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144166 - matthiaskrgr:rollup-wccepuo, r=matth…
d47b125 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#141076 (fix Zip unsoundness (again))
 - rust-lang#142444 (adding run-make test to autodiff)
 - rust-lang#143704 (Be a bit more careful around exotic cycles in in the inliner)
 - rust-lang#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - rust-lang#144083 (miri sleep tests: increase slack)
 - rust-lang#144092 (bootstrap: Detect musl hosts)
 - rust-lang#144098 (Do not lint private-in-public for RPITIT)
 - rust-lang#144103 (Rename `emit_unless` to `emit_unless_delay`)
 - rust-lang#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - rust-lang#144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 29, 2025
@bors
Auto merge of rust-lang#144166 - matthiaskrgr:rollup-wccepuo, r=matth…
3c8e89e 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#141076 (fix Zip unsoundness (again))
 - rust-lang#142444 (adding run-make test to autodiff)
 - rust-lang#143704 (Be a bit more careful around exotic cycles in in the inliner)
 - rust-lang#144073 (Don't test panic=unwind in panic_main.rs on Fuchsia)
 - rust-lang#144083 (miri sleep tests: increase slack)
 - rust-lang#144092 (bootstrap: Detect musl hosts)
 - rust-lang#144098 (Do not lint private-in-public for RPITIT)
 - rust-lang#144103 (Rename `emit_unless` to `emit_unless_delay`)
 - rust-lang#144108 (Ignore tests/run-make/link-eh-frame-terminator/rmake.rs when cross-compiling)
 - rust-lang#144115 (fix outdated comment)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Enselic Enselic Enselic approved these changes

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

5 participants

@erickt @rustbot @lqd @bors @Enselic