Write .cargo/config.toml in x vendor#144124
Conversation
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
Why not just print out the config info captured? That avoids the trailing and avoids automatically overwriting a potentially existing config.toml. |
|
I found this will working on vendoring support for |
|
Sounds good - the broken output is a bit unfortunate but not the end of the world. r=me when green |
|
I don't think people will appreciate when running |
|
|
||
| impl Step for Vendor { | ||
| type Output = VendorOutput; | ||
| type Output = (); |
There was a problem hiding this comment.
Why remove this? GenerateCopyright can still make use of the final path, instead of having to know about VENDOR_DIR, which is an implementation detail of the vendor step.
There was a problem hiding this comment.
VendorOutput only ever contained the data that should be written to .cargo/config.toml.
There was a problem hiding this comment.
I don't like overwriting the config.toml file on disk (as per my other comment), but if we did that, we can at least return the path to the vendor directory from the step, to avoid other steps reaching for VENDOR_DIR.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
☔ The latest upstream changes (presumably #148987) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot author |
x vendor hides the cargo vendor telling you what to write to
.cargo/config.toml. to use the vendored sources, so without this PR it isn't obvious how to use the vendored sources.