Fix `-Ctarget-feature`s getting ignored after `crt-static` by Gelbpunkt · Pull Request #144143 · rust-lang/rust

Gelbpunkt · 2025-07-18T17:02:53Z

The current behaviour introduced by commit a50a3b8 would discard any target features specified after crt-static (the only member of RUSTC_SPECIFIC_FEATURES). This is because it returned instead of continuing processing the next feature.

I wasn't entirely sure how the regression test should look like, but this one should do. If anyone has some suggestions, I'm happy to learn, it's my first test :)

I've confirmed that the test fails without the fix on powerpc64le-unknown-linux-musl and x86_64-unknown-linux-gnu.

cc @RalfJung

fixes #144203

The current behaviour introduced by commit a50a3b8 would discard any target features specified after crt-static (the only member of RUSTC_SPECIFIC_FEATURES). This is because it returned instead of continuing processing the next flag. Signed-off-by: Jens Reidel <adrian@travitia.xyz>

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

rustbot · 2025-07-18T17:02:58Z

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-18T17:02:59Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Gelbpunkt · 2025-07-18T17:30:04Z

This should probably also be backported to 1.89.

apiraino · 2025-07-18T18:45:55Z

Regression introduced in #140920

tgross35 · 2025-07-18T18:59:41Z

Zulip discussion: #t-compiler/help > Lots of ABI/target-feature test fails

Noratrieb · 2025-07-18T20:07:50Z

@Gelbpunkt can you open an issue for this? We usually don't require issues for bug fixes but we use them for tracking backports, so it would be useful here.

RalfJung · 2025-07-19T08:57:23Z

It's a bit odd to make this a fail-test that way, but sure, why not. :) Thanks for finding the issue and fixing it!

r? @RalfJung
@bors r+

bors · 2025-07-19T08:57:26Z

📌 Commit 1b35d5f has been approved by RalfJung

It is now in the queue for this repository.

Gelbpunkt · 2025-07-20T04:53:46Z

@Gelbpunkt can you open an issue for this? We usually don't require issues for bug fixes but we use them for tracking backports, so it would be useful here.

Opened #144203

…ic, r=RalfJung Fix `-Ctarget-feature`s getting ignored after `crt-static` The current behaviour introduced by commit a50a3b8 would discard any target features specified after `crt-static` (the only member of `RUSTC_SPECIFIC_FEATURES`). This is because it returned instead of continuing processing the next feature. I wasn't entirely sure how the regression test should look like, but this one should do. If anyone has some suggestions, I'm happy to learn, it's my first test :) I've confirmed that the test fails without the fix on `powerpc64le-unknown-linux-musl` and `x86_64-unknown-linux-gnu`. cc `@RalfJung`

Rollup of 9 pull requests Successful merges: - #143282 (Add `uX::strict_sub_signed`) - #143423 (address clippy formatting nits) - #143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - #144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - #144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - #144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - #144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - #144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - #144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144143 - Gelbpunkt:target-features-crt-static, r=RalfJung Fix `-Ctarget-feature`s getting ignored after `crt-static` The current behaviour introduced by commit a50a3b8 would discard any target features specified after `crt-static` (the only member of `RUSTC_SPECIFIC_FEATURES`). This is because it returned instead of continuing processing the next feature. I wasn't entirely sure how the regression test should look like, but this one should do. If anyone has some suggestions, I'm happy to learn, it's my first test :) I've confirmed that the test fails without the fix on `powerpc64le-unknown-linux-musl` and `x86_64-unknown-linux-gnu`. cc ``@RalfJung``

Rollup of 9 pull requests Successful merges: - rust-lang/rust#143282 (Add `uX::strict_sub_signed`) - rust-lang/rust#143423 (address clippy formatting nits) - rust-lang/rust#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - rust-lang/rust#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - rust-lang/rust#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - rust-lang/rust#144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - rust-lang/rust#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - rust-lang/rust#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - rust-lang/rust#144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

…ic, r=RalfJung Fix `-Ctarget-feature`s getting ignored after `crt-static` The current behaviour introduced by commit a50a3b8 would discard any target features specified after `crt-static` (the only member of `RUSTC_SPECIFIC_FEATURES`). This is because it returned instead of continuing processing the next feature. I wasn't entirely sure how the regression test should look like, but this one should do. If anyone has some suggestions, I'm happy to learn, it's my first test :) I've confirmed that the test fails without the fix on `powerpc64le-unknown-linux-musl` and `x86_64-unknown-linux-gnu`. cc ``@RalfJung``

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#143282 (Add `uX::strict_sub_signed`) - rust-lang#143423 (address clippy formatting nits) - rust-lang#143720 (Allow `Rvalue::Repeat` to return true in `rvalue_creates_operand` too) - rust-lang#144011 (bootstrap: Don't trigger an unnecessary LLVM build from check builds) - rust-lang#144112 (bootstrap: Ignore `rust.debuginfo-level-tests` for codegen tests) - rust-lang#144125 (Add new `ignore-backends` and `needs-backends` tests annotations) - rust-lang#144143 (Fix `-Ctarget-feature`s getting ignored after `crt-static`) - rust-lang#144150 (tests: assembly: cstring-merging: Disable GlobalMerge pass) - rust-lang#144190 (Give a message with a span on MIR validation error) r? `@ghost` `@rustbot` modify labels: rollup

apiraino · 2025-07-24T14:06:47Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

[beta] backports - Reword mismatched-lifetime-syntaxes text based on feedback #143914 - Fix `-Ctarget-feature`s getting ignored after `crt-static` #144143 - Mitigate `#[align]` name resolution ambiguity regression with a rename #144080 r? cuviper

Gelbpunkt added 2 commits July 18, 2025 18:59

tests: Add a regression test for crt-static with target features

1b35d5f

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

rustbot assigned compiler-errors Jul 18, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2025

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 18, 2025

Gelbpunkt changed the title ~~Fix -Ctarget-features getting ignored after crt-static~~ Fix -Ctarget-features getting ignored after crt-static Jul 18, 2025

workingjubilee added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 18, 2025

rustbot assigned RalfJung and unassigned compiler-errors Jul 19, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025

Gelbpunkt mentioned this pull request Jul 20, 2025

-Ctarget-features get ignored after crt-static #144203

Closed

This was referenced Jul 20, 2025

Rollup of 8 pull requests #144217

Closed

Rollup of 9 pull requests #144219

Merged

bors merged commit 1e6ef24 into rust-lang:master Jul 20, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 20, 2025

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 24, 2025

cuviper mentioned this pull request Jul 24, 2025

[beta] backports #144414

Merged

cuviper modified the milestones: 1.90.0, 1.89.0 Jul 24, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `-Ctarget-feature`s getting ignored after `crt-static`#144143

Fix `-Ctarget-feature`s getting ignored after `crt-static`#144143
bors merged 2 commits intorust-lang:masterfrom
Gelbpunkt:target-features-crt-static

Gelbpunkt commented Jul 18, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

Gelbpunkt commented Jul 18, 2025

Uh oh!

apiraino commented Jul 18, 2025 •

edited

Loading

Uh oh!

tgross35 commented Jul 18, 2025

Uh oh!

Noratrieb commented Jul 18, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

Gelbpunkt commented Jul 20, 2025

Uh oh!

Uh oh!

apiraino commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

Gelbpunkt commented Jul 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

rustbot commented Jul 18, 2025

Uh oh!

Gelbpunkt commented Jul 18, 2025

Uh oh!

apiraino commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Jul 18, 2025

Uh oh!

Noratrieb commented Jul 18, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

Gelbpunkt commented Jul 20, 2025

Uh oh!

Uh oh!

apiraino commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Gelbpunkt commented Jul 18, 2025 •

edited by rustbot

Loading

apiraino commented Jul 18, 2025 •

edited

Loading