Reoganize poison::rwlock file#144175
Closed
connortsui20 wants to merge 2 commits intorust-lang:masterfrom
Closed
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
f48b596 to
5f9c9eb
Compare
This commit reorganizes the `rwlock` tests, moving the tests that involve poisoning away from the ones that do not.
5f9c9eb to
1c6bc6e
Compare
Contributor
Author
|
Closing this in favor of integrating this directly into the PR that implements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a purely cosmetic change to the documentation and ordering of items in the
rwlock.rsfile.This is mainly in preparation for the eventual implementation of
#, and the issue for that can be found in #134645. These changes should make it easier to find things in the code and port things over to a futurenonpoisonvariant ofRwLock.List of changes (lots of small things):
'rwlockinstead of'aReadGuard,WriteGuard,MappedReadGuard,MappedWriteGuard)poisonfield inMappedRwLockWriteGuardtoposion_guarddowngradeto match Stabilizerwlock_downgradelibrary feature #143191Edit: some more cosmetic changes to the
rwlocktest file, and it is simply moving tests up or down depending on if they test poisoning or not. This will again make the implementation ofnonpoison_rwlockmuch easier.