pass build.npm from bootstrap to tidy and use it for npm install by lolbinarycat · Pull Request #144317 · rust-lang/rust

lolbinarycat · 2025-07-22T17:22:18Z

followup to #142924

r? @Kobzol

rustbot · 2025-07-22T17:22:25Z

There are changes to the tidy tool.

cc @jieyouxu

src/tools/tidy/src/ext_tool_checks/rustdoc_js.rs

src/tools/tidy/src/main.rs

Kobzol

Thanks!

Kobzol · 2025-07-22T18:14:35Z

src/tools/tidy/src/main.rs

    let concurrency: NonZeroUsize =
        FromStr::from_str(&env::args().nth(4).expect("need concurrency"))
            .expect("concurrency must be a number");
+    let npm: PathBuf = env::args_os().nth(5).expect("need name/path of npm command").into();


We might want to think about using clap here soon... 😆

If we're going to refactor how bootstrap passes args to internal tools, I would prefer we use something more type-safe and typo-safe than manually serializing and deserializing args at every process boundary, especially considering these tools aren't really meant to be called directly.

my immediate thought would be putting some types into build_helper which get serialized into json blobs that get passed to tools and deserialized. I actually tried doing this in a limited form with compiletest all the way back in #135653, trying to reduce the amount of code that has to be kept in sync on both sides.

I don't know if some people don't use tidy or compiletest outside of bootstrap 🤷 But if not, then yeah, we might make the interface be more machine processing friendly.

Kobzol · 2025-07-22T18:14:59Z

@bors delegate+

You can r=me once PR CI is green.

bors · 2025-07-22T18:15:02Z

✌️ @lolbinarycat, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

lolbinarycat · 2025-07-22T22:14:55Z

@bors r=@Kobzol

bors · 2025-07-22T22:14:58Z

📌 Commit 2d1fccd has been approved by Kobzol

It is now in the queue for this repository.

…r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to rust-lang#142924 r? `@Kobzol`

fmease · 2025-07-23T22:43:37Z

CI failure in rollup, not sure if it's due to this PR? Feels unlikely but it's the only one that touched bootstrap. Sorry in advance if I'm misjudging.

#144380 (comment)
@bors r-

fmease · 2025-07-23T23:15:28Z

Nah, it's a different PR. Also occurred in different PR: #144382 (comment)

@bors r=Kobzol

bors · 2025-07-23T23:15:31Z

📌 Commit 2d1fccd has been approved by Kobzol

It is now in the queue for this repository.

…r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to rust-lang#142924 r? `@Kobzol`

Rollup of 15 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #143374 (Unquerify extern_mod_stmt_cnum.) - #143838 (std: net: uefi: Add support to query connection data) - #144014 (don't link to the nightly version of the Edition Guide in stable lints) - #144094 (Ensure we codegen the main fn) - #144218 (Use serde for target spec json deserialize) - #144221 (generate elf symbol version in raw-dylib) - #144240 (Add more test case to check if the false note related to sealed trait suppressed) - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2) - #144276 (Use less HIR in check_private_in_public.) - #144317 (pass build.npm from bootstrap to tidy and use it for npm install) - #144320 (rustdoc: avoid allocating a temp String for aliases in search index) - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion) - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding) - #144358 (Stop using the old `validate_attr` logic for stability attributes) r? `@ghost` `@rustbot` modify labels: rollup

…r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to rust-lang#142924 r? ``@Kobzol``

Rollup of 16 pull requests Successful merges: - #143374 (Unquerify extern_mod_stmt_cnum.) - #143838 (std: net: uefi: Add support to query connection data) - #144014 (don't link to the nightly version of the Edition Guide in stable lints) - #144094 (Ensure we codegen the main fn) - #144218 (Use serde for target spec json deserialize) - #144221 (generate elf symbol version in raw-dylib) - #144232 (Implement support for `become` and explicit tail call codegen for the LLVM backend) - #144240 (Add more test case to check if the false note related to sealed trait suppressed) - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2) - #144276 (Use less HIR in check_private_in_public.) - #144278 (add Rev::into_inner) - #144317 (pass build.npm from bootstrap to tidy and use it for npm install) - #144320 (rustdoc: avoid allocating a temp String for aliases in search index) - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion) - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding) - #144358 (Stop using the old `validate_attr` logic for stability attributes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #143374 (Unquerify extern_mod_stmt_cnum.) - #143838 (std: net: uefi: Add support to query connection data) - #144014 (don't link to the nightly version of the Edition Guide in stable lints) - #144094 (Ensure we codegen the main fn) - #144218 (Use serde for target spec json deserialize) - #144221 (generate elf symbol version in raw-dylib) - #144240 (Add more test case to check if the false note related to sealed trait suppressed) - #144247 (coretests/num: use ldexp instead of hard-coding a power of 2) - #144276 (Use less HIR in check_private_in_public.) - #144278 (add Rev::into_inner) - #144317 (pass build.npm from bootstrap to tidy and use it for npm install) - #144320 (rustdoc: avoid allocating a temp String for aliases in search index) - #144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion) - #144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding) - #144358 (Stop using the old `validate_attr` logic for stability attributes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144317 - lolbinarycat:tidy-obey-build.npm, r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to #142924 r? ```@Kobzol```

Rollup of 15 pull requests Successful merges: - rust-lang/rust#143374 (Unquerify extern_mod_stmt_cnum.) - rust-lang/rust#143838 (std: net: uefi: Add support to query connection data) - rust-lang/rust#144014 (don't link to the nightly version of the Edition Guide in stable lints) - rust-lang/rust#144094 (Ensure we codegen the main fn) - rust-lang/rust#144218 (Use serde for target spec json deserialize) - rust-lang/rust#144221 (generate elf symbol version in raw-dylib) - rust-lang/rust#144240 (Add more test case to check if the false note related to sealed trait suppressed) - rust-lang/rust#144247 (coretests/num: use ldexp instead of hard-coding a power of 2) - rust-lang/rust#144276 (Use less HIR in check_private_in_public.) - rust-lang/rust#144278 (add Rev::into_inner) - rust-lang/rust#144317 (pass build.npm from bootstrap to tidy and use it for npm install) - rust-lang/rust#144320 (rustdoc: avoid allocating a temp String for aliases in search index) - rust-lang/rust#144334 (rustc_resolve: get rid of unused rustdoc::span_of_fragments_with_expansion) - rust-lang/rust#144335 (Don't suggest assoc ty bound on non-angle-bracketed problematic assoc ty binding) - rust-lang/rust#144358 (Stop using the old `validate_attr` logic for stability attributes) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Kobzol Jul 22, 2025

This comment has been minimized.

Sign in to view

Kobzol reviewed Jul 22, 2025

View reviewed changes

src/tools/tidy/src/ext_tool_checks/rustdoc_js.rs Outdated Show resolved Hide resolved

src/tools/tidy/src/main.rs Outdated Show resolved Hide resolved

lolbinarycat force-pushed the tidy-obey-build.npm branch from 53219e8 to 666fadf Compare July 22, 2025 17:45

pass build.npm from bootstrap to tidy and use it for npm install

2d1fccd

lolbinarycat force-pushed the tidy-obey-build.npm branch from 666fadf to 2d1fccd Compare July 22, 2025 17:46

Kobzol approved these changes Jul 22, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2025

fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025

Rollup merge of rust-lang#144317 - lolbinarycat:tidy-obey-build.npm, …

3ed1f61

…r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to rust-lang#142924 r? `@Kobzol`

fmease mentioned this pull request Jul 23, 2025

Rollup of 16 pull requests #144380

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2025

fmease closed this Jul 23, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 23, 2025

fmease reopened this Jul 23, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 23, 2025

fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025

Rollup merge of rust-lang#144317 - lolbinarycat:tidy-obey-build.npm, …

fafdf5b

…r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to rust-lang#142924 r? `@Kobzol`

fmease mentioned this pull request Jul 24, 2025

Rollup of 15 pull requests #144384

Closed

fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025

Rollup merge of rust-lang#144317 - lolbinarycat:tidy-obey-build.npm, …

d6f2bf8

…r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to rust-lang#142924 r? ``@Kobzol``

fmease mentioned this pull request Jul 24, 2025

Rollup of 16 pull requests #144387

Closed

fmease mentioned this pull request Jul 24, 2025

Rollup of 15 pull requests #144398

Merged

bors merged commit 352e02b into rust-lang:master Jul 24, 2025
22 checks passed

rustbot added this to the 1.90.0 milestone Jul 24, 2025

rust-timer added a commit that referenced this pull request Jul 24, 2025

Unrolled build for #144317

3de5c86

Rollup merge of #144317 - lolbinarycat:tidy-obey-build.npm, r=Kobzol pass build.npm from bootstrap to tidy and use it for npm install followup to #142924 r? ```@Kobzol```

Uh oh!

Conversation

lolbinarycat commented Jul 22, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 22, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Kobzol left a comment

Choose a reason for hiding this comment

Uh oh!

Kobzol Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

lolbinarycat Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Kobzol Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Kobzol commented Jul 22, 2025

Uh oh!

bors commented Jul 22, 2025

Uh oh!

lolbinarycat commented Jul 22, 2025

Uh oh!

bors commented Jul 22, 2025

Uh oh!

fmease commented Jul 23, 2025

Uh oh!

fmease commented Jul 23, 2025

Uh oh!

bors commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lolbinarycat commented Jul 22, 2025 •

edited by rustbot

Loading