UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern` by Oneirical · Pull Request #144340 · rust-lang/rust

Oneirical · 2025-07-23T01:47:14Z

To match convention, rename tests/ui/SUMMARY.md to tests/ui/README.md.

Also, remove misleading lines in the rustc development guide about error-pattern being "not recommended", when it really is just a last resort which should be used in the niche situations where it is useful.

r? @jieyouxu

rustbot · 2025-07-23T01:47:18Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-07-23T01:47:21Z

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

jieyouxu

Thanks, a wording nit, r=me otherwise.

jieyouxu · 2025-07-23T04:09:15Z

src/doc/rustc-dev-guide/src/tests/ui.md

+For compile time tests, it should be preferred to using `error-pattern`, which
+is imprecise and non-exhaustive.


Nit: this might be worded a bit confusingly, maybe

For tests wishing to match against compiler diagnostics, error annotations should be preferred over //@ error-pattern, //@ error-pattern is imprecise and non-exhaustive.

jieyouxu · 2025-07-23T04:09:46Z

@bors delegate+ rollup

bors · 2025-07-23T04:09:50Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

jieyouxu · 2025-07-23T04:14:10Z

@rustbot author

rustbot · 2025-07-23T04:14:14Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

bors · 2025-07-23T21:24:33Z

☔ The latest upstream changes (presumably #144360) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2025-07-24T21:10:46Z

@bors r=@jieyouxu

bors · 2025-07-24T21:10:48Z

📌 Commit 94c0cf8 has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern` To match convention, rename `tests/ui/SUMMARY.md` to `tests/ui/README.md`. Also, remove misleading lines in the rustc development guide about `error-pattern` being "not recommended", when it really is just a last resort which *should* be used in the niche situations where it is useful. r? `@jieyouxu`

Rollup of 17 pull requests Successful merges: - #142569 (Suggest clone in user-write-code instead of inside macro) - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - #143424 (clippy fix: rely on autoderef) - #143970 (Update core::mem::copy documentation) - #143979 (Test fixes for Arm64EC Windows) - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - #144200 (Tweak output for non-`Clone` values moved into closures) - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - #144225 (Don't special-case llvm.* as nounwind) - #144314 (Hint that choose_pivot returns index in bounds) - #144316 (bootstrap: Move musl-root fallback out of sanity check) - #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`) - #144364 (Update `dlmalloc` dependency of libstd) - #144368 (resolve: Remove `Scope::CrateRoot`) - #144390 (Remove dead code and extend test coverage and diagnostics around it) - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) - #144424 (Allow setting `release-blog-post` label with rustbot) r? `@ghost` `@rustbot` modify labels: rollup

…eyouxu UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern` To match convention, rename `tests/ui/SUMMARY.md` to `tests/ui/README.md`. Also, remove misleading lines in the rustc development guide about `error-pattern` being "not recommended", when it really is just a last resort which *should* be used in the niche situations where it is useful. r? ``@jieyouxu``

…eyouxu UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern` To match convention, rename `tests/ui/SUMMARY.md` to `tests/ui/README.md`. Also, remove misleading lines in the rustc development guide about `error-pattern` being "not recommended", when it really is just a last resort which *should* be used in the niche situations where it is useful. r? ```@jieyouxu```

Rollup of 16 pull requests Successful merges: - #142569 (Suggest clone in user-write-code instead of inside macro) - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - #143424 (clippy fix: rely on autoderef) - #143970 (Update core::mem::copy documentation) - #143979 (Test fixes for Arm64EC Windows) - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - #144200 (Tweak output for non-`Clone` values moved into closures) - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - #144314 (Hint that choose_pivot returns index in bounds) - #144316 (bootstrap: Move musl-root fallback out of sanity check) - #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`) - #144364 (Update `dlmalloc` dependency of libstd) - #144368 (resolve: Remove `Scope::CrateRoot`) - #144390 (Remove dead code and extend test coverage and diagnostics around it) - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) - #144424 (Allow setting `release-blog-post` label with rustbot) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - #142569 (Suggest clone in user-write-code instead of inside macro) - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - #143424 (clippy fix: rely on autoderef) - #143970 (Update core::mem::copy documentation) - #143979 (Test fixes for Arm64EC Windows) - #144200 (Tweak output for non-`Clone` values moved into closures) - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - #144314 (Hint that choose_pivot returns index in bounds) - #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`) - #144368 (resolve: Remove `Scope::CrateRoot`) - #144390 (Remove dead code and extend test coverage and diagnostics around it) - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144340 - Oneirical:uncertain-illusion, r=jieyouxu UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern` To match convention, rename `tests/ui/SUMMARY.md` to `tests/ui/README.md`. Also, remove misleading lines in the rustc development guide about `error-pattern` being "not recommended", when it really is just a last resort which *should* be used in the niche situations where it is useful. r? ````@jieyouxu````

Rollup of 12 pull requests Successful merges: - rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro) - rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - rust-lang/rust#143424 (clippy fix: rely on autoderef) - rust-lang/rust#143970 (Update core::mem::copy documentation) - rust-lang/rust#143979 (Test fixes for Arm64EC Windows) - rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures) - rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds) - rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`) - rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`) - rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it) - rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#142569 (Suggest clone in user-write-code instead of inside macro) - rust-lang#143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - rust-lang#143424 (clippy fix: rely on autoderef) - rust-lang#143970 (Update core::mem::copy documentation) - rust-lang#143979 (Test fixes for Arm64EC Windows) - rust-lang#144200 (Tweak output for non-`Clone` values moved into closures) - rust-lang#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - rust-lang#144314 (Hint that choose_pivot returns index in bounds) - rust-lang#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`) - rust-lang#144368 (resolve: Remove `Scope::CrateRoot`) - rust-lang#144390 (Remove dead code and extend test coverage and diagnostics around it) - rust-lang#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro) - rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - rust-lang/rust#143424 (clippy fix: rely on autoderef) - rust-lang/rust#143970 (Update core::mem::copy documentation) - rust-lang/rust#143979 (Test fixes for Arm64EC Windows) - rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures) - rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds) - rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`) - rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`) - rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it) - rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jul 23, 2025

rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2025

jieyouxu approved these changes Jul 23, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2025

jieyouxu mentioned this pull request Jul 24, 2025

Remove hello_world directory #144411

Merged

Rename tests/ui/SUMMARY.md and update rustc dev guide on error-pattern

94c0cf8

Oneirical force-pushed the uncertain-illusion branch from ff8baea to 94c0cf8 Compare July 24, 2025 21:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2025

fmease mentioned this pull request Jul 25, 2025

Rollup of 17 pull requests #144428

Closed

matthiaskrgr mentioned this pull request Jul 25, 2025

Rollup of 16 pull requests #144436

Closed

Kobzol mentioned this pull request Jul 25, 2025

Rollup of 10 pull requests #144437

Closed

jieyouxu mentioned this pull request Jul 25, 2025

tests/ui/issues/: The Issues Strike Back [1/N] #144151

Merged

matthiaskrgr mentioned this pull request Jul 25, 2025

Rollup of 12 pull requests #144440

Merged

bors merged commit 405b2e6 into rust-lang:master Jul 25, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jul 25, 2025

jieyouxu mentioned this pull request Jul 31, 2025

Selectively replace instances of error-pattern with check-run-results #143537

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`#144340

UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`#144340
bors merged 1 commit intorust-lang:masterfrom
Oneirical:uncertain-illusion

Oneirical commented Jul 23, 2025

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

jieyouxu left a comment

Uh oh!

jieyouxu Jul 23, 2025

Uh oh!

jieyouxu commented Jul 23, 2025

Uh oh!

bors commented Jul 23, 2025

Uh oh!

jieyouxu commented Jul 23, 2025

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

bors commented Jul 23, 2025

Uh oh!

Oneirical commented Jul 24, 2025

Uh oh!

bors commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		For compile time tests, it should be preferred to using `error-pattern`, which
		is imprecise and non-exhaustive.

Uh oh!

Conversation

Oneirical commented Jul 23, 2025

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 23, 2025

Uh oh!

bors commented Jul 23, 2025

Uh oh!

jieyouxu commented Jul 23, 2025

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

bors commented Jul 23, 2025

Uh oh!

Oneirical commented Jul 24, 2025

Uh oh!

bors commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants