Skip to content

Add ignore-backends annotations in failing GCC backend ui tests#144356

Merged
bors merged 2 commits intorust-lang:masterfrom
GuillaumeGomez:gcc-ignore-tests
Jul 26, 2025
Merged

Add ignore-backends annotations in failing GCC backend ui tests#144356
bors merged 2 commits intorust-lang:masterfrom
GuillaumeGomez:gcc-ignore-tests

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 23, 2025

Follow-up of #144125.

In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available here.

This PR adds the ignore-backends annotations to the corresponding ui tests.

The second commit is a fix to compiletest, complaining about ignore-backends.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2025

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

Some changes occurred in src/tools/compiletest

cc @jieyouxu

jieyouxu
jieyouxu approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Jul 25, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 25, 2025

📌 Commit 910ee2d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 25, 2025
@GuillaumeGomez
Rollup merge of rust-lang#144356 - GuillaumeGomez:gcc-ignore-tests, r…
2771b07 
…=jieyouxu

Add `ignore-backends` annotations in failing GCC backend ui tests

Follow-up of rust-lang#144125.

In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt).

This PR adds the `ignore-backends` annotations to the corresponding ui tests.

The second commit is a fix to compiletest, complaining about `ignore-backends`.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 25, 2025
Closed
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144450 - GuillaumeGomez:rollup-zffdbtc, r=GuillaumeGomez
188e30b 
Rollup of 13 pull requests

Successful merges:

 - #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests)
 - #144359 (add codegen test for variadics)
 - #144376 (Suggest unwrapping when private method name is available in inner type)
 - #144379 (test using multiple c-variadic ABIs in the same program)
 - #144383 (disable cfg.has_reliable_f128 on amdgcn)
 - #144409 (Stop compilation early if macro expansion failed)
 - #144412 (Small cleanup: Use LocalKey<Cell> methods more)
 - #144421 (Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually)
 - #144422 (library/windows_targets: Fix macro expansion error in 'link' macro)
 - #144424 (Allow setting `release-blog-post` label with rustbot)
 - #144430 (tests: aarch64-outline-atomics: Remove hardcoded target)
 - #144435 (rustc-dev-guide subtree update)
 - #144445 (Fix `./x check bootstrap` (again))

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144450 - GuillaumeGomez:rollup-zffdbtc, r=GuillaumeGomez
8a4c727 
Rollup of 13 pull requests

Successful merges:

 - #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests)
 - #144359 (add codegen test for variadics)
 - #144376 (Suggest unwrapping when private method name is available in inner type)
 - #144379 (test using multiple c-variadic ABIs in the same program)
 - #144383 (disable cfg.has_reliable_f128 on amdgcn)
 - #144409 (Stop compilation early if macro expansion failed)
 - #144412 (Small cleanup: Use LocalKey<Cell> methods more)
 - #144421 (Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually)
 - #144422 (library/windows_targets: Fix macro expansion error in 'link' macro)
 - #144424 (Allow setting `release-blog-post` label with rustbot)
 - #144430 (tests: aarch64-outline-atomics: Remove hardcoded target)
 - #144435 (rustc-dev-guide subtree update)
 - #144445 (Fix `./x check bootstrap` (again))

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144450 - GuillaumeGomez:rollup-zffdbtc, r=GuillaumeGomez
6e522cf 
Rollup of 13 pull requests

Successful merges:

 - #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests)
 - #144359 (add codegen test for variadics)
 - #144376 (Suggest unwrapping when private method name is available in inner type)
 - #144379 (test using multiple c-variadic ABIs in the same program)
 - #144383 (disable cfg.has_reliable_f128 on amdgcn)
 - #144409 (Stop compilation early if macro expansion failed)
 - #144412 (Small cleanup: Use LocalKey<Cell> methods more)
 - #144421 (Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually)
 - #144422 (library/windows_targets: Fix macro expansion error in 'link' macro)
 - #144424 (Allow setting `release-blog-post` label with rustbot)
 - #144430 (tests: aarch64-outline-atomics: Remove hardcoded target)
 - #144435 (rustc-dev-guide subtree update)
 - #144445 (Fix `./x check bootstrap` (again))

r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 25, 2025
@GuillaumeGomez
Rollup merge of rust-lang#144356 - GuillaumeGomez:gcc-ignore-tests, r…
9c233e6 
…=jieyouxu

Add `ignore-backends` annotations in failing GCC backend ui tests

Follow-up of rust-lang#144125.

In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt).

This PR adds the `ignore-backends` annotations to the corresponding ui tests.

The second commit is a fix to compiletest, complaining about `ignore-backends`.

r? ``@jieyouxu``
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 25, 2025
Closed
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144466 - GuillaumeGomez:rollup-pvka4ir, r=GuillaumeGomez
0e2300b 
Rollup of 14 pull requests

Successful merges:

 - #144316 (bootstrap: Move musl-root fallback out of sanity check)
 - #144352 (RustWrapper: Suppress getNextNonDebugInfoInstruction)
 - #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests)
 - #144359 (add codegen test for variadics)
 - #144376 (Suggest unwrapping when private method name is available in inner type)
 - #144379 (test using multiple c-variadic ABIs in the same program)
 - #144383 (disable cfg.has_reliable_f128 on amdgcn)
 - #144412 (Small cleanup: Use LocalKey<Cell> methods more)
 - #144421 (Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually)
 - #144422 (library/windows_targets: Fix macro expansion error in 'link' macro)
 - #144424 (Allow setting `release-blog-post` label with rustbot)
 - #144430 (tests: aarch64-outline-atomics: Remove hardcoded target)
 - #144435 (rustc-dev-guide subtree update)
 - #144445 (Fix `./x check bootstrap` (again))

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35 tgross35 mentioned this pull request Jul 26, 2025
Merged
bors added a commit that referenced this pull request Jul 26, 2025
@bors
Auto merge of #144488 - tgross35:rollup-vn0fpot, r=tgross35
051d0e8 
Rollup of 9 pull requests

Successful merges:

 - #144089 (Rehome 35 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
 - #144171 (pattern_analysis: add option to get a full set of witnesses)
 - #144201 (Mention type that could be `Clone` but isn't in more cases)
 - #144316 (bootstrap: Move musl-root fallback out of sanity check)
 - #144339 (Enable dwarf-mixed-versions-lto.rs test on RISC-V (riscv64))
 - #144341 (Enable const-vector.rs test on RISC-V (riscv64))
 - #144352 (RustWrapper: Suppress getNextNonDebugInfoInstruction)
 - #144356 (Add `ignore-backends` annotations in failing GCC backend ui tests)
 - #144364 (Update `dlmalloc` dependency of libstd)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b1b68f into rust-lang:master Jul 26, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 26, 2025
rust-timer added a commit that referenced this pull request Jul 26, 2025
@rust-timer
Unrolled build for #144356
21fe3fc 
Rollup merge of #144356 - GuillaumeGomez:gcc-ignore-tests, r=jieyouxu

Add `ignore-backends` annotations in failing GCC backend ui tests

Follow-up of #144125.

In the GCC backend, we don't support all ui tests yet and we have a list of tests we currently ignore available [here](https://github.com/rust-lang/rustc_codegen_gcc/blob/master/tests/failing-ui-tests.txt).

This PR adds the `ignore-backends` annotations to the corresponding ui tests.

The second commit is a fix to compiletest, complaining about `ignore-backends`.

r? ```@jieyouxu```
RalfJung
RalfJung reviewed Jul 26, 2025
View reviewed changes
tests/ui/consts/missing_span_in_backtrace.rs
Copy link
Member

@RalfJung RalfJung Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test doesn't do anything backend-specific... so this is a GCC backend bug, right?

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize other ui tests I added annotations to were backend specific. Anyway, I added this annotation because they fail with current GCC backend.

Copy link
Member

@RalfJung RalfJung Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize other ui tests I added annotations to were backend specific

I don't know if they do.^^ I just noticed this annotation since it caused a conflict in my PR, and went "hu? how could this possibly fail in one backend only?" All the logic for this test it outside the backend as far as I know...

But anyway, it seems you are treating all these ignore-backends: gcc annotations as bug. Many ignore annotations are not bugs, they reflect that the test just fundamentally cannot work in that setting. That's why I got confused here.

Copy link
Member Author

@GuillaumeGomez GuillaumeGomez Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, makes more sense. Yes it's currently bugs for GCC backend. :)

@GuillaumeGomez GuillaumeGomez deleted the gcc-ignore-tests branch July 26, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez @rustbot @jieyouxu @bors @RalfJung