remove deprecated Error::description in impls by hkBst · Pull Request #144373 · rust-lang/rust

hkBst · 2025-07-23T18:11:54Z

libs-api permission

r? @cuviper
or @jhpratt

jhpratt · 2025-07-24T05:06:43Z

r? jhpratt

@bors r+

bors · 2025-07-24T05:06:46Z

📌 Commit ab6fd22 has been approved by jhpratt

It is now in the queue for this repository.

remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`

Rollup of 16 pull requests Successful merges: - #142569 (Suggest clone in user-write-code instead of inside macro) - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test) - #143424 (clippy fix: rely on autoderef) - #143970 (Update core::mem::copy documentation) - #143979 (Test fixes for Arm64EC Windows) - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - #144200 (Tweak output for non-`Clone` values moved into closures) - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other) - #144225 (Don't special-case llvm.* as nounwind) - #144314 (Hint that choose_pivot returns index in bounds) - #144316 (bootstrap: Move musl-root fallback out of sanity check) - #144364 (Update `dlmalloc` dependency of libstd) - #144368 (resolve: Remove `Scope::CrateRoot`) - #144373 (remove deprecated Error::description in impls) - #144390 (Remove dead code and extend test coverage and diagnostics around it) - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) r? `@ghost` `@rustbot` modify labels: rollup

fmease · 2025-07-25T01:26:11Z

#144418 (comment)
@bors r-

cuviper · 2025-07-25T18:10:40Z

library/std/src/sys/pal/sgx/os.rs

 use fortanix_sgx_abi::{Error, RESULT_SUCCESS};

-use crate::error::Error as StdError;


This rename is still needed due to the other Error right above.

jhpratt · 2025-08-19T21:06:21Z

ping @hkBst to resolve the error

rustbot · 2025-08-23T20:10:55Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

hkBst · 2025-08-25T10:38:25Z

@bors r=@jhpratt

bors · 2025-08-25T10:38:27Z

📌 Commit 78b8fdf has been approved by jhpratt

It is now in the queue for this repository.

remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`

Rollup of 12 pull requests Successful merges: - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #144373 (remove deprecated Error::description in impls) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-08-26T00:44:24Z

Failed in rollup on dist-various-2: #145860 (comment)

error: unused import: `str`
 --> library/std/src/sys/pal/sgx/os.rs:7:22
  |
7 | use crate::{fmt, io, str};
  |                      ^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`

@bors r-

hkBst · 2025-08-26T06:38:23Z

@bors r=@jhpratt

bors · 2025-08-26T06:38:25Z

📌 Commit 845311a has been approved by jhpratt

It is now in the queue for this repository.

rust-log-analyzer · 2025-08-26T07:58:39Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


warning: `test_docs` (lib doc) generated 4 warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.61s
   Generated /checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html
npm ERR! code E429
npm ERR! 429 Too Many Requests - GET https://registry.npmjs.org/zod/-/zod-3.23.8.tgz

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-08-26T07_45_03_116Z-debug-0.log
npm install did not exit successfully

thread 'main' panicked at src/tools/rustdoc-gui-test/src/main.rs:69:10:
unable to install browser-ui-test: Custom { kind: Other, error: "npm install returned exit code exit status: 1" }
stack backtrace:
   0: __rustc::rust_begin_unwind
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/std/src/panicking.rs:697:5
   1: core::panicking::panic_fmt
             at /rustc/788da80fcfcef3f34c90def5baa32813e39a1a41/library/core/src/panicking.rs:75:14

jhpratt · 2025-08-26T08:31:56Z

@bors try

remove deprecated Error::description in impls

rust-bors · 2025-08-26T10:49:17Z

☀️ Try build successful (CI)
Build commit: 45318cf (45318cffd3df5d6f20234d5dd53afbe00f1f7c14, parent: ace9a74442aec13c75532d34e15d97428056866d)

Rollup of 11 pull requests Successful merges: - #144373 (remove deprecated Error::description in impls) - #144551 (Add aarch64_be-unknown-linux-musl target) - #145076 (Add new Tier-3 target: riscv64a23-unknown-linux-gnu) - #145481 (Add parentheses for closure when suggesting calling closure) - #145596 (Losslessly optimize PNG files) - #145615 (Fix doc of `std::os::windows::io::BorrowedSocket::borrow_raw`) - #145841 (Always build miri for the host in `x run miri`) - #145861 (bootstrap: vendor `clippy_test_deps` too) - #145863 (formatting_options: Make all methods `const`) - #145867 (cg_llvm: Assert that LLVM range-attribute values don't exceed 128 bits) - #145875 (Make bootstrap command caching opt-in) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144373 - hkBst:remove-deprecated-1, r=jhpratt remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`

remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`

rustbot assigned cuviper Jul 23, 2025

rustbot assigned jhpratt and unassigned cuviper Jul 24, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2025

fmease mentioned this pull request Jul 24, 2025

Rollup of 16 pull requests #144418

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2025

cuviper reviewed Jul 25, 2025

View reviewed changes

rust-cloud-vms bot force-pushed the remove-deprecated-1 branch from ab6fd22 to b04360d Compare August 23, 2025 19:49

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the remove-deprecated-1 branch from b04360d to f5fe78f Compare August 23, 2025 20:10

rust-cloud-vms bot force-pushed the remove-deprecated-1 branch from 4e4325c to 78b8fdf Compare August 25, 2025 08:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2025

jhpratt mentioned this pull request Aug 25, 2025

Rollup of 12 pull requests #145860

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2025

remove deprecated Error::description in impls

845311a

rust-cloud-vms bot force-pushed the remove-deprecated-1 branch from 78b8fdf to 845311a Compare August 26, 2025 06:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Aug 26, 2025

Auto merge of #144373 - hkBst:remove-deprecated-1, r=<try>

45318cf

remove deprecated Error::description in impls

GuillaumeGomez mentioned this pull request Aug 26, 2025

Rollup of 11 pull requests #145886

Merged

bors merged commit 9bb7d17 into rust-lang:master Aug 26, 2025
9 of 11 checks passed

rustbot added this to the 1.91.0 milestone Aug 26, 2025

hkBst deleted the remove-deprecated-1 branch August 26, 2025 18:51

ADD-SP mentioned this pull request Oct 14, 2025

nightly-2025-10-12 adds a breaking change to std::io::Error::description() #147658

Closed

		use fortanix_sgx_abi::{Error, RESULT_SUCCESS};

		use crate::error::Error as StdError;

Uh oh!

Conversation

hkBst commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jul 24, 2025

Uh oh!

bors commented Jul 24, 2025

Uh oh!

fmease commented Jul 25, 2025

Uh oh!

cuviper Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

jhpratt commented Aug 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 23, 2025

Uh oh!

hkBst commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

jieyouxu commented Aug 26, 2025

Uh oh!

hkBst commented Aug 26, 2025

Uh oh!

bors commented Aug 26, 2025

Uh oh!

rust-log-analyzer commented Aug 26, 2025

Uh oh!

jhpratt commented Aug 26, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hkBst commented Jul 23, 2025 •

edited

Loading