Add aarch64_be-unknown-linux-musl target#144551
Conversation
Gelbpunkt
left a comment
There was a problem hiding this comment.
also needs platform support documentation
compiler/rustc_target/src/spec/targets/aarch64_be_unknown_linux_musl.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_target/src/spec/targets/aarch64_be_unknown_linux_musl.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
71f7a6c to
79014d7
Compare
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
|
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
r? compiler_leads |
| ## Requirements | ||
|
|
||
| The target requires a `aarch64_be-*-linux-musl` toolchain, which likely has to | ||
| be built from source because this is a rare combination. [Buildroot] provides |
There was a problem hiding this comment.
I just noticed that musl.cc/musl-cross-make includes an aarch64_be toolchain, which necessitates some rephrasing in this paragraph.
davidtwco
left a comment
There was a problem hiding this comment.
Could you also include the completed target tier policy compliance affirmations like in the description of #144962 (comment)?
compiler/rustc_target/src/spec/targets/aarch64_be_unknown_linux_musl.rs
Outdated
Show resolved
Hide resolved
|
☔ The latest upstream changes (presumably #145366) made this pull request unmergeable. Please resolve the merge conflicts. |
79014d7 to
199e54c
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
The target maintainers will be:
The name
ACK
No license irregularities.
No new dependencies.
No proprietary dependencies. aarch64_be code can be built with upstream
ACK
ACK
Done, see markdown file.
ACK
ACK
Upstream LLVM codegen works, albeit with bugs.
ACK |
|
@bors r+ rollup Out of curiosity, what are you using this target for? |
Just experimentation, nothing "productive" at this point. I am interested in aarch64_be in general, because it's (hardware-wise) probably the most accessible big-endian platform today, and I'm interested in portability and finding endian bugs. |
Rollup of 11 pull requests Successful merges: - #144373 (remove deprecated Error::description in impls) - #144551 (Add aarch64_be-unknown-linux-musl target) - #145076 (Add new Tier-3 target: riscv64a23-unknown-linux-gnu) - #145481 (Add parentheses for closure when suggesting calling closure) - #145596 (Losslessly optimize PNG files) - #145615 (Fix doc of `std::os::windows::io::BorrowedSocket::borrow_raw`) - #145841 (Always build miri for the host in `x run miri`) - #145861 (bootstrap: vendor `clippy_test_deps` too) - #145863 (formatting_options: Make all methods `const`) - #145867 (cg_llvm: Assert that LLVM range-attribute values don't exceed 128 bits) - #145875 (Make bootstrap command caching opt-in) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #144551 - neuschaefer:a64be-musl, r=davidtwco Add aarch64_be-unknown-linux-musl target This PR adds a target definition for big-endian Aarch64 with musl-libc. cc `@Gelbpunkt`
This PR adds a target definition for big-endian Aarch64 with musl-libc.
cc @Gelbpunkt