Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases#144565
Closed
CaiWeiran wants to merge 5 commits intorust-lang:masterfrom
CaiWeiran:fix_ci_test
Closed
Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases#144565CaiWeiran wants to merge 5 commits intorust-lang:masterfrom CaiWeiran:fix_ci_test
CaiWeiran wants to merge 5 commits intorust-lang:masterfrom
CaiWeiran:fix_ci_test
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
compiler-errors
suggested changes
Jul 28, 2025
Contributor
compiler-errors
left a comment
There was a problem hiding this comment.
Please squash this, and it would be useful if you actually described what effect these changes had and why they're only important for RISCV codegen.
added 5 commits
July 28, 2025 16:22
Collaborator
|
Insufficient permissions to issue commands to rust-timer. |
Contributor
|
@CaiWeiran: 🔑 Insufficient privileges: not in try users |
Collaborator
|
Insufficient permissions to issue commands to rust-timer. |
Collaborator
|
☔ The latest upstream changes (presumably #145423) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses and resolves several test failures that occurred when running
./x teston the RISC-V architecture. The issues were due to platform-specific behavior, ABI differences, or code generation inconsistencies specific to RISC-V.The following tests have been fixed:
codegen-llvm/enum/enum-match.rscodegen-llvm/enum/enum-transparent-extract.rscodegen-llvm/repeat-operand-zero-len.rscodegen-llvm/enum/enum-aggregate.rscodegen-llvm/uninhabited-transparent-return-abi.rsAll changes have been tested locally with
./x teston a RISC-V target and now pass as expected.Notes: