Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases by CaiWeiran · Pull Request #144567 · rust-lang/rust

CaiWeiran · 2025-07-28T07:26:55Z

This PR resolves several test failures encountered when running ./x test on the RISC-V architecture. These failures were caused by platform-specific behavior, ABI differences, or codegen inconsistencies unique to RISC-V.

The following test cases have been fixed to ensure compatibility with RISC-V:

codegen-llvm/enum/enum-match.rs
codegen-llvm/enum/enum-transparent-extract.rs
codegen-llvm/repeat-operand-zero-len.rs
codegen-llvm/enum/enum-aggregate.rs
codegen-llvm/uninhabited-transparent-return-abi.rs

In addition, this PR adjusts tests/codegen-llvm/transmute-scalar.rs to explicitly specify the target architecture:

//@ compile-flags: --target=x86_64-unknown-linux-gnu
//@ needs-llvm-components: x86

As suggested by @nikic, this test is not target-specific and already uses minicore, implying it is meant to run against a stable triple regardless of the host architecture. Explicitly setting the target ensures consistent codegen behavior, particularly when testing on non-x86 platforms such as riscv64.

All changes have been tested locally on a RISC-V target and now pass as expected.

Notes:

These fixes are scoped specifically to enable full test suite compliance for RISC-V.
No changes impact other architectures.
The change to transmute-scalar.rs aligns with the intent of [#143915](Fix RISC-V Test Failures in ./x test for Multiple Codegen and Assembly Cases #143915) and prevents architecture-dependent discrepancies during CI or local testing.

rustbot · 2025-07-28T07:27:00Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/codegen-llvm/transmute-scalar.rs

Mark-Simulacrum · 2025-08-03T23:28:03Z

r=me with commits squashed

CaiWeiran · 2025-08-04T04:46:33Z

r=me with commits squashedr=me，提交被压缩

@Mark-Simulacrum Thanks! Commits squashed as requested.

bors · 2025-08-15T13:38:09Z

☔ The latest upstream changes (presumably #145423) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-08-18T01:34:53Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

CaiWeiran · 2025-08-18T12:24:14Z

@rustbot ready
r? @Mark-Simulacrum

Squashed to a single commit as requested. CI is green locally; please r+ when convenient. Thanks!

rustbot · 2025-08-18T12:24:16Z

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

nikic · 2025-08-18T15:18:15Z

@bors r+ rollup=iffy codegen tests

bors · 2025-08-18T15:18:19Z

📌 Commit 9d08596 has been approved by nikic

It is now in the queue for this repository.

Resolve several ./x test failures on RISC-V caused by ABI and codegen differences. Update multiple codegen-llvm tests for compatibility, and explicitly set the target for transmute-scalar.rs to x86_64 to ensure consistent behavior across hosts.

…=nikic Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases This PR resolves several test failures encountered when running `./x test` on the RISC-V architecture. These failures were caused by platform-specific behavior, ABI differences, or codegen inconsistencies unique to RISC-V. The following test cases have been fixed to ensure compatibility with RISC-V: * `codegen-llvm/enum/enum-match.rs` * `codegen-llvm/enum/enum-transparent-extract.rs` * `codegen-llvm/repeat-operand-zero-len.rs` * `codegen-llvm/enum/enum-aggregate.rs` * `codegen-llvm/uninhabited-transparent-return-abi.rs` In addition, this PR adjusts `tests/codegen-llvm/transmute-scalar.rs` to explicitly specify the target architecture: ```rust //@ compile-flags: --target=x86_64-unknown-linux-gnu //@ needs-llvm-components: x86 ``` As suggested by `@nikic,` this test is not target-specific and already uses `minicore`, implying it is meant to run against a stable triple regardless of the host architecture. Explicitly setting the target ensures consistent codegen behavior, particularly when testing on non-x86 platforms such as riscv64. All changes have been tested locally on a RISC-V target and now pass as expected. ### Notes: * These fixes are scoped specifically to enable full test suite compliance for RISC-V. * No changes impact other architectures. * The change to `transmute-scalar.rs` aligns with the intent of [[rust-lang#143915](https://github.com/rust-lang/rust/pull/143915)](https://github.com/rust-lang/rust/pull/143915) and prevents architecture-dependent discrepancies during CI or local testing.

…=nikic Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases This PR resolves several test failures encountered when running `./x test` on the RISC-V architecture. These failures were caused by platform-specific behavior, ABI differences, or codegen inconsistencies unique to RISC-V. The following test cases have been fixed to ensure compatibility with RISC-V: * `codegen-llvm/enum/enum-match.rs` * `codegen-llvm/enum/enum-transparent-extract.rs` * `codegen-llvm/repeat-operand-zero-len.rs` * `codegen-llvm/enum/enum-aggregate.rs` * `codegen-llvm/uninhabited-transparent-return-abi.rs` In addition, this PR adjusts `tests/codegen-llvm/transmute-scalar.rs` to explicitly specify the target architecture: ```rust //@ compile-flags: --target=x86_64-unknown-linux-gnu //@ needs-llvm-components: x86 ``` As suggested by ``@nikic,`` this test is not target-specific and already uses `minicore`, implying it is meant to run against a stable triple regardless of the host architecture. Explicitly setting the target ensures consistent codegen behavior, particularly when testing on non-x86 platforms such as riscv64. All changes have been tested locally on a RISC-V target and now pass as expected. ### Notes: * These fixes are scoped specifically to enable full test suite compliance for RISC-V. * No changes impact other architectures. * The change to `transmute-scalar.rs` aligns with the intent of [[rust-lang#143915](https://github.com/rust-lang/rust/pull/143915)](https://github.com/rust-lang/rust/pull/143915) and prevents architecture-dependent discrepancies during CI or local testing.

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`) - #142871 (Trivial improve doc for transpose ) - #144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std) - #144476 (rustdoc-search: search backend with partitioned suffix tree) - #144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144960 ([RTE-513] Ignore sleep_until test on SGX) - #145013 (overhaul `&mut` suggestions in borrowck errors) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths) - #145432 (cg_llvm: Small cleanups to `owned_target_machine`) - #145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings) - #145557 (Fix uplifting in `Assemble` step) - #145563 (Remove the `From` derive macro from prelude) - #145565 (Improve context of bootstrap errors in CI) - #145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance) Failed merges: - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145573 (Add an experimental unsafe(force_target_feature) attribute.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144567 - CaiWeiran:transmute-scalar_test, r=nikic Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases This PR resolves several test failures encountered when running `./x test` on the RISC-V architecture. These failures were caused by platform-specific behavior, ABI differences, or codegen inconsistencies unique to RISC-V. The following test cases have been fixed to ensure compatibility with RISC-V: * `codegen-llvm/enum/enum-match.rs` * `codegen-llvm/enum/enum-transparent-extract.rs` * `codegen-llvm/repeat-operand-zero-len.rs` * `codegen-llvm/enum/enum-aggregate.rs` * `codegen-llvm/uninhabited-transparent-return-abi.rs` In addition, this PR adjusts `tests/codegen-llvm/transmute-scalar.rs` to explicitly specify the target architecture: ```rust //@ compile-flags: --target=x86_64-unknown-linux-gnu //@ needs-llvm-components: x86 ``` As suggested by ```@nikic,``` this test is not target-specific and already uses `minicore`, implying it is meant to run against a stable triple regardless of the host architecture. Explicitly setting the target ensures consistent codegen behavior, particularly when testing on non-x86 platforms such as riscv64. All changes have been tested locally on a RISC-V target and now pass as expected. ### Notes: * These fixes are scoped specifically to enable full test suite compliance for RISC-V. * No changes impact other architectures. * The change to `transmute-scalar.rs` aligns with the intent of [[#143915](https://github.com/rust-lang/rust/pull/143915)](https://github.com/rust-lang/rust/pull/143915) and prevents architecture-dependent discrepancies during CI or local testing.

Zalathar · 2025-08-19T08:27:33Z

Bors hasn't noticed that this was merged.

@bors r- retry

Rollup of 19 pull requests Successful merges: - rust-lang/rust#140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - rust-lang/rust#141744 (Stabilize `ip_from`) - rust-lang/rust#142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`) - rust-lang/rust#142871 (Trivial improve doc for transpose ) - rust-lang/rust#144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std) - rust-lang/rust#144476 (rustdoc-search: search backend with partitioned suffix tree) - rust-lang/rust#144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases) - rust-lang/rust#144804 (Don't warn on never to any `as` casts as unreachable) - rust-lang/rust#144960 ([RTE-513] Ignore sleep_until test on SGX) - rust-lang/rust#145013 (overhaul `&mut` suggestions in borrowck errors) - rust-lang/rust#145041 (rework GAT borrowck limitation error) - rust-lang/rust#145243 (take attr style into account in diagnostics) - rust-lang/rust#145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths) - rust-lang/rust#145432 (cg_llvm: Small cleanups to `owned_target_machine`) - rust-lang/rust#145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings) - rust-lang/rust#145557 (Fix uplifting in `Assemble` step) - rust-lang/rust#145563 (Remove the `From` derive macro from prelude) - rust-lang/rust#145565 (Improve context of bootstrap errors in CI) - rust-lang/rust#145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance) Failed merges: - rust-lang/rust#145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - rust-lang/rust#145573 (Add an experimental unsafe(force_target_feature) attribute.) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Jul 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2025

nikic reviewed Jul 28, 2025

View reviewed changes

tests/codegen-llvm/transmute-scalar.rs Show resolved Hide resolved

CaiWeiran requested a review from nikic August 4, 2025 00:58

CaiWeiran changed the title ~~Fix tests/codegen-llvm/transmute-scalar.rs test failure on riscv64~~ Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases Aug 4, 2025

CaiWeiran mentioned this pull request Aug 4, 2025

Fix RISC-V Test Failures in ./x test for Multiple Codegen and Assembly Cases #143915

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025

Zalathar mentioned this pull request Aug 19, 2025

Rollup of 19 pull requests #145589

Merged

bors merged commit 3a03bb9 into rust-lang:master Aug 19, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases#144567

Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases#144567
bors merged 1 commit intorust-lang:masterfrom
CaiWeiran:transmute-scalar_test

CaiWeiran commented Jul 28, 2025 •

edited

Loading

Uh oh!

rustbot commented Jul 28, 2025

Uh oh!

Uh oh!

Mark-Simulacrum commented Aug 3, 2025

Uh oh!

CaiWeiran commented Aug 4, 2025

Uh oh!

bors commented Aug 15, 2025

Uh oh!

rustbot commented Aug 18, 2025

Uh oh!

This comment has been minimized.

CaiWeiran commented Aug 18, 2025

Uh oh!

rustbot commented Aug 18, 2025

Uh oh!

nikic commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

CaiWeiran commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes:

Uh oh!

rustbot commented Jul 28, 2025

Uh oh!

Uh oh!

Mark-Simulacrum commented Aug 3, 2025

Uh oh!

CaiWeiran commented Aug 4, 2025

Uh oh!

bors commented Aug 15, 2025

Uh oh!

rustbot commented Aug 18, 2025

Uh oh!

This comment has been minimized.

CaiWeiran commented Aug 18, 2025

Uh oh!

rustbot commented Aug 18, 2025

Uh oh!

nikic commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CaiWeiran commented Jul 28, 2025 •

edited

Loading