[test] Correct llvm-component to tests that need x86#144620
Closed
daltenty wants to merge 1 commit intorust-lang:masterfrom
Closed
[test] Correct llvm-component to tests that need x86#144620daltenty wants to merge 1 commit intorust-lang:masterfrom
daltenty wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Collaborator
|
Some changes occurred in tests/codegen-llvm/sanitizer cc @rcvalle |
rustbot
added
PG-exploit-mitigations
daltenty
changed the title
Member
|
Hi, thanks for the PR. However, this was already being addressed in #144042. |
Contributor
Author
Awesome, thanks. Will close this in favour of the existing one. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These codegen test added in #105452 require the x86 backend in LLVM, but the constraint is missing for some reason, so the test will fail when run without that backend available.