Rollup of 13 pull requests by Zalathar · Pull Request #144633 · rust-lang/rust

Zalathar · 2025-07-29T10:19:55Z

Successful merges:

Implementation: #[feature(sync_nonpoison)], #[feature(nonpoison_mutex)] #144022 (Implementation: #[feature(sync_nonpoison)], #[feature(nonpoison_mutex)])
Document why Range*<&T> as RangeBounds<T> impls are not T: ?Sized, and give an alternative. #144167 (Document why Range*<&T> as RangeBounds<T> impls are not T: ?Sized, and give an alternative.)
fix(debuginfo): disable overflow check for recursive non-enum types #144407 (fix(debuginfo): disable overflow check for recursive non-enum types)
fix: Reject upvar scrutinees for loop_match #144451 (fix: Reject upvar scrutinees for loop_match)
Add explicit download methods to download module in bootstrap #144482 (Add explicit download methods to download module in bootstrap)
thread name in stack overflow message #144500 (thread name in stack overflow message)
tidy: increase performance of auto extra checks feature #144511 (tidy: increase performance of auto extra checks feature)
bootstrap: enable tidy auto extra checks on tools profile #144599 (bootstrap: enable tidy auto extra checks on tools profile)
Ensure external paths passed via flags end up in rustdoc depinfo #144600 (Ensure external paths passed via flags end up in rustdoc depinfo)
feat: Right align line numbers #144609 (feat: Right align line numbers)
miri subtree update #144623 (miri subtree update)
cc dependencies: clarify comment #144626 (cc dependencies: clarify comment)
Add a test case for the issue #129882 #144627 (Add a test case for the issue [ICE]: None in compiler/rustc_middle/src/ty/sty.rs #129882)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Automatic Rustup

non-deterministically truncate reads/writes

Automatic Rustup

CI: add windows-arm runner

Use `josh-sync` instead of `miri-script` for Josh synchronization

…ntentionally not `T: ?Sized`, and document (publically) an alternative.

make the missing-MIR message more clear

This updates the rust-version file to b56aaec.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: b56aaec Filtered ref: 12f5e3255df658296af9fc953d8c1ab79ba91ea3 This merge was created using https://github.com/rust-lang/josh-sync.

Fix cronjob Zulip message

Perfetto gives an error if an id does not fit in an 64-bit signed integer in 2's complement.

Automatic Rustup

Zalathar · 2025-07-29T10:20:21Z

@bors r+ rollup=never p=5

bors · 2025-07-29T10:20:23Z

📌 Commit ba29c0d has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-07-29T10:21:56Z

⌛ Testing commit ba29c0d with merge 7278554...

Zalathar · 2025-07-29T10:22:25Z

Subset of #144628.

bors · 2025-07-29T13:36:48Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 7278554 to master...

github-actions · 2025-07-29T13:40:06Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5529041 (parent) -> 7278554 (this PR)

Test differences

Show 76 test diffs

Stage 1

mutex::lots_and_lots: pass -> [missing] (J0)
mutex::nonpoison_lots_and_lots: [missing] -> pass (J0)
mutex::nonpoison_smoke: [missing] -> pass (J0)
mutex::nonpoison_test_get_cloned: [missing] -> pass (J0)
mutex::nonpoison_test_get_mut: [missing] -> pass (J0)
mutex::nonpoison_test_into_inner: [missing] -> pass (J0)
mutex::nonpoison_test_into_inner_drop: [missing] -> pass (J0)
mutex::nonpoison_test_mapping_mapped_guard: [missing] -> pass (J0)
mutex::nonpoison_test_mutex_arc_access_in_unwind: [missing] -> pass (J0)
mutex::nonpoison_test_mutex_arc_nested: [missing] -> pass (J0)
mutex::nonpoison_test_mutex_unsized: [missing] -> pass (J0)
mutex::nonpoison_test_panics: [missing] -> pass (J0)
mutex::nonpoison_test_replace: [missing] -> pass (J0)
mutex::nonpoison_test_set: [missing] -> pass (J0)
mutex::nonpoison_test_set_drop: [missing] -> pass (J0)
mutex::nonpoison_try_lock: [missing] -> pass (J0)
mutex::poison_lots_and_lots: [missing] -> pass (J0)
mutex::poison_smoke: [missing] -> pass (J0)
mutex::poison_test_get_cloned: [missing] -> pass (J0)
mutex::poison_test_get_mut: [missing] -> pass (J0)
mutex::poison_test_into_inner: [missing] -> pass (J0)
mutex::poison_test_into_inner_drop: [missing] -> pass (J0)
mutex::poison_test_mapping_mapped_guard: [missing] -> pass (J0)
mutex::poison_test_mutex_arc_access_in_unwind: [missing] -> pass (J0)
mutex::poison_test_mutex_arc_nested: [missing] -> pass (J0)
mutex::poison_test_mutex_unsized: [missing] -> pass (J0)
mutex::poison_test_panics: [missing] -> pass (J0)
mutex::poison_test_replace: [missing] -> pass (J0)
mutex::poison_test_set: [missing] -> pass (J0)
mutex::poison_test_set_drop: [missing] -> pass (J0)
mutex::poison_try_lock: [missing] -> pass (J0)
mutex::smoke: pass -> [missing] (J0)
mutex::test_get_cloned: pass -> [missing] (J0)
mutex::test_get_mut: pass -> [missing] (J0)
mutex::test_into_inner: pass -> [missing] (J0)
mutex::test_into_inner_drop: pass -> [missing] (J0)
mutex::test_mapping_mapped_guard: pass -> [missing] (J0)
mutex::test_mutex_arc_access_in_unwind: pass -> [missing] (J0)
mutex::test_mutex_arc_nested: pass -> [missing] (J0)
mutex::test_mutex_unsized: pass -> [missing] (J0)
mutex::test_replace: pass -> [missing] (J0)
mutex::test_set: pass -> [missing] (J0)
mutex::try_lock: pass -> [missing] (J0)
[codegen] tests/codegen-llvm/debuginfo-cyclic-structure.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/generic_const_exprs/feature-attribute-missing-in-dependent-crate-ice.rs: [missing] -> pass (J1)
[ui] tests/ui/loop-match/upvar-scrutinee.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/const-generics/generic_const_exprs/feature-attribute-missing-in-dependent-crate-ice.rs: [missing] -> pass (J2)
[ui] tests/ui/loop-match/upvar-scrutinee.rs: [missing] -> pass (J2)
[codegen] tests/codegen-llvm/debuginfo-cyclic-structure.rs: [missing] -> pass (J3)

Additionally, 27 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7278554d82fa474a4e8b5c67afb009e11e41a841 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 5834.1s -> 9008.5s (54.4%)
aarch64-apple: 4281.8s -> 5754.6s (34.4%)
dist-aarch64-apple: 5934.3s -> 7099.4s (19.6%)
dist-apple-various: 5383.4s -> 4745.7s (-11.8%)
aarch64-msvc-2: 5703.7s -> 5053.6s (-11.4%)
dist-arm-linux-gnueabi: 5131.6s -> 4736.2s (-7.7%)
x86_64-apple-2: 4381.2s -> 4698.9s (7.3%)
x86_64-gnu-tools: 3565.4s -> 3342.9s (-6.2%)
x86_64-apple-1: 8854.9s -> 8346.4s (-5.7%)
dist-armv7-linux: 5216.3s -> 4960.1s (-4.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-29T13:40:37Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144022	Implementation: `#[feature(sync_nonpoison)]`, `#[feature(no…	`16c5ba6e385f4e96dc75fc911ac6ac3006e33e9e` (link)
#144167	Document why `Range*<&T> as RangeBounds<T>` impls are not `…	`8773bd2fdfb705b26ddb7a23eb50677a424ad42d` (link)
#144407	fix(debuginfo): disable overflow check for recursive non-en…	`3ab275bb4013c403ab9f5aa5fcb0cbda894f3bce` (link)
#144451	fix: Reject upvar scrutinees for `loop_match`	`c1cbf9f921c296db56766fcdd56daf69441b18b1` (link)
#144482	Add explicit download methods to download module in bootstr…	`fcb73360b77e3ed841eac20ec415f6cacde4f55d` (link)
#144500	thread name in stack overflow message	`a9feef6960008239f06779732ee5cda8d6bb62be` (link)
#144511	tidy: increase performance of auto extra checks feature	`94c61a34c78de2eaa9e242dd8a3d51f6e8aee4c9` (link)
#144599	bootstrap: enable tidy auto extra checks on tools profile	`057aa95bbc7303769598a9cfe3b9284ac50bb5cd` (link)
#144600	Ensure external paths passed via flags end up in rustdoc de…	`6e5b186c9aac93baa2ec1f1e5ad1ad7109d93671` (link)
#144609	feat: Right align line numbers	`391bb6805849170db5b543b20c1f00c7e17981dc` (link)
#144623	miri subtree update	`10af6e892537e2dc2c0f5cb4bdf0ac862907c5ac` (link)
#144626	cc dependencies: clarify comment	`1a31a7204a452b920ed56fbc52e673a6c3ace4ef` (link)
#144627	Add a test case for the issue #129882	`8d29047b8acfb01b939e929fcd7e04d315e2ac20` (link)

previous master: 552904134b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-07-29T17:28:39Z

Finished benchmarking commit (7278554): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary -0.3%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[2.1%, 4.4%]	2
Regressions ❌ (secondary)	2.6%	[2.4%, 2.9%]	2
Improvements ✅ (primary)	-3.9%	[-5.7%, -2.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-5.7%, 4.4%]	4

Cycles

Results (secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[3.6%, 4.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.9%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	4
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	38
All ❌✅ (primary)	0.0%	[-0.1%, 0.2%]	7

Bootstrap: 468.885s -> 467.638s (-0.27%)
Artifact size: 376.79 MiB -> 376.88 MiB (0.02%)

RalfJung and others added 30 commits July 19, 2025 15:39

don't halt execution when we write to a read-only file

8acdee7

non-deterministically truncate reads/writes

d3fc02c

Preparing for merge from rustc

72ba7c5

Merge from rustc

e3e711b

Merge pull request rust-lang#4486 from rust-lang/rustup-2025-07-21

9ef15d2

Automatic Rustup

Merge pull request rust-lang#4481 from RalfJung/read-write-truncate

800d805

non-deterministically truncate reads/writes

Preparing for merge from rustc

6f06667

Merge from rustc

4d62686

Merge pull request rust-lang#4487 from rust-lang/rustup-2025-07-22

7a8288b

Automatic Rustup

CI: add windows-arm runner

08d7787

Init josh-sync config file

a6c1093

Remove Josh code from miri-script

a61657e

Merge pull request rust-lang#4479 from RalfJung/ci-win-arm

037b2f6

CI: add windows-arm runner

Update CONTRIBUTING.md

e685e90

Update CI workflow

48963fa

Remove Zulip API keys and use set -x

8664aa7

Merge pull request rust-lang#4490 from Kobzol/use-josh-sync

cbd1557

Use `josh-sync` instead of `miri-script` for Josh synchronization

Document (internally) that Range*<&T> as RangeBounds<T> impls are i…

477814a

…ntentionally not `T: ?Sized`, and document (publically) an alternative.

make the missing-MIR message more clear

fd114d4

Merge pull request rust-lang#4491 from RalfJung/missing-mir

94f725f

make the missing-MIR message more clear

Prepare for merging from rust-lang/rust

0258894

This updates the rust-version file to b56aaec.

Merge ref 'b56aaec52bc0' from rust-lang/rust

8ff5894

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: b56aaec Filtered ref: 12f5e3255df658296af9fc953d8c1ab79ba91ea3 This merge was created using https://github.com/rust-lang/josh-sync.

fmt

0dba9f5

Fix cronjob Zulip message

60b0545

Merge pull request rust-lang#4493 from Kobzol/ci-fail-message

80c9f78

Fix cronjob Zulip message

Use i64 for tracing chrome "id"

2a81b4f

Perfetto gives an error if an id does not fit in an 64-bit signed integer in 2's complement.

Fix missing $ in enter_trace_span!

00de833

Fix double "fatal error: " in message

c7b81f3

fix target json

d2ba3c8

Merge pull request rust-lang#4492 from rust-lang/rustup-2025-07-25

dd96ec6

Automatic Rustup

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2025

Zalathar mentioned this pull request Jul 29, 2025

miri subtree update #144623

Merged

bors mentioned this pull request Jul 29, 2025

expand: Micro-optimize prelude injection #144587

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 29, 2025

bors merged commit 7278554 into rust-lang:master Jul 29, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 29, 2025

Zalathar deleted the rollup-h984m13 branch July 29, 2025 13:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 13 pull requests#144633

Rollup of 13 pull requests#144633
bors merged 85 commits intorust-lang:masterfrom
Zalathar:rollup-h984m13

Zalathar commented Jul 29, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Jul 29, 2025

Uh oh!

bors commented Jul 29, 2025

Uh oh!

bors commented Jul 29, 2025

Uh oh!

Zalathar commented Jul 29, 2025

Uh oh!

bors commented Jul 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jul 29, 2025

Uh oh!

rust-timer commented Jul 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

Zalathar commented Jul 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Jul 29, 2025

Uh oh!

bors commented Jul 29, 2025

Uh oh!

bors commented Jul 29, 2025

Uh oh!

Zalathar commented Jul 29, 2025

Uh oh!

bors commented Jul 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 29, 2025

Uh oh!

rust-timer commented Jul 29, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Zalathar commented Jul 29, 2025 •

edited by rustbot

Loading