Skip to content

Use new public libtest ERROR_EXIT_CODE constant in rustdoc#144739

Merged
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:rustdoc-test-cleanup
Aug 10, 2025
Merged

Use new public libtest ERROR_EXIT_CODE constant in rustdoc#144739
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:rustdoc-test-cleanup

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 31, 2025 •
edited by rustbot
Loading

Followup of #144297.

@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 31, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jul 31, 2025

Ah, I guess I need to wait one day before the CI can pass...

@fmease fmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025
@fmease fmease assigned fmease and unassigned notriddle Jul 31, 2025
@fmease
Copy link
Member

fmease commented Jul 31, 2025 •
edited
Loading

r=me once unblocked.
@bors rollup

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease
Copy link
Member

fmease commented Aug 1, 2025

Still private even tho it's pub on master, is test from the sysroot of the bootstrap/beta compiler? 🤔

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 1, 2025

Wondering the same thing. Do you know @Kobzol by any chance?

@Kobzol
Copy link
Member

Kobzol commented Aug 1, 2025

Stage 1 rustdoc is compiled with stage 0 rustc, which means that it uses the stage 0 stdlib.

@Kobzol
Copy link
Member

Kobzol commented Aug 1, 2025

In other words, you have to wait for a stage0 bump. But since today beta is being branched off, it should happen soon-ish.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease
Copy link
Member

fmease commented Aug 6, 2025

(blocked on #144997)

@fmease
Copy link
Member

fmease commented Aug 9, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 9, 2025

📌 Commit 339be84 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
f7eaf6a 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
427d004 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
@Zalathar Zalathar mentioned this pull request Aug 9, 2025
Closed
bors added a commit that referenced this pull request Aug 9, 2025
@bors
Auto merge of #145161 - Zalathar:rollup-uyqbw90, r=Zalathar
33792e0 
Rollup of 8 pull requests

Successful merges:

 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145146 (remove `P`)
 - #145152 (Use `to_ascii_lowercase` to avoid heap alloc in `detect_confuse_type`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])

Failed merges:

 - #145145 (some `derive_more` refactors)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
edd8735 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
f46214b 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
a10e87c 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
d9c745c 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145197 - Zalathar:rollup-9a642pd, r=Zalathar
ba1a4f0 
Rollup of 19 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144544 (Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies)
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145175 (Enable limit_rdylib_exports on Solaris)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
02c12e2 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Closed
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145204 - Zalathar:rollup-eyrrf5y, r=Zalathar
b6f3e72 
Rollup of 18 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145175 (Enable limit_rdylib_exports on Solaris)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 10, 2025
@Zalathar
Rollup merge of rust-lang#144739 - GuillaumeGomez:rustdoc-test-cleanu…
ac09d9e 
…p, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of rust-lang#144297.
@Zalathar Zalathar mentioned this pull request Aug 10, 2025
Merged
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145210 - Zalathar:rollup-dm4reb2, r=Zalathar
80ff75f 
Rollup of 17 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 10, 2025
@bors
Auto merge of #145210 - Zalathar:rollup-dm4reb2, r=Zalathar
18eeac0 
Rollup of 17 pull requests

Successful merges:

 - #141624 (unstable-book: Add stubs for environment variables; document some of the important ones)
 - #143093 (Simplify polonius location-sensitive analysis)
 - #144402 (Stabilize loongarch32 inline asm)
 - #144403 (`tests/ui/issues/`: The Issues Strike Back [4/N])
 - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc)
 - #145089 (Improve error output when a command fails in bootstrap)
 - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC)
 - #145129 ([win][arm64ec] Add `/machine:arm64ec` when linking LLVM as Arm64EC)
 - #145130 (improve "Documentation problem" issue template.)
 - #145135 (Stabilize `duration_constructors_lite` feature)
 - #145145 (some `derive_more` refactors)
 - #145147 (rename `TraitRef::from_method` to `from_assoc`)
 - #145156 (Override custom Cargo `build-dir` in bootstrap)
 - #145160 (Change days-threshold to 28 in [behind-upstream])
 - #145162 (`{BTree,Hash}Map`: add "`Entry` API" section heading)
 - #145187 (Fix an unstable feature comment that wasn't a doc comment)
 - #145191 (`suggest_borrow_generic_arg`: use the correct generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3d6976c into rust-lang:master Aug 10, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 10, 2025
rust-timer added a commit that referenced this pull request Aug 10, 2025
@rust-timer
Unrolled build for #144739
077bc8e 
Rollup merge of #144739 - GuillaumeGomez:rustdoc-test-cleanup, r=fmease

Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc

Followup of #144297.
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-test-cleanup branch August 10, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez @rustbot @rust-log-analyzer @fmease @Kobzol @bors @notriddle