Rollup of 7 pull requests by jhpratt · Pull Request #144768 · rust-lang/rust

jhpratt · 2025-08-01T04:38:23Z

Successful merges:

rustdoc: never link to unnamable items #143849 (rustdoc: never link to unnamable items)
Simplify library dependencies on compiler-builtins #144683 (Simplify library dependencies on compiler-builtins)
Extend is_case_difference to handle digit-letter confusables #144691 (Extend is_case_difference to handle digit-letter confusables)
rustdoc-json: Move #[macro_export] from Other to it's own variant #144700 (rustdoc-json: Move #[macro_export] from Other to it's own variant)
Add correct dynamic_lib_extension for aix #144751 (Add correct dynamic_lib_extension for aix)
Ping Muscraft when emitter change #144757 (Ping Muscraft when emitter change)
triagebot: Label compiler-builtins T-libs #144759 (triagebot: Label compiler-builtins T-libs)

r? @ghost
@rustbot modify labels: rollup

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

`compiler_builtins` shouldn't be called directly. Change the `PartialEq` implementation for `DevicePathNode` to use slice equality instead, which will call `memcmp`/`bcmp` via the intrinsic.

The three panic-related library crates need to have access to `core`, and `compiler-builtins` needs to be in the crate graph. Rather than specifying both dependencies, switch these crates to use `rustc-std-workspace-core` which already does this. This means there is now a single place that the `compiler-builtins` dependency needs to get configured, for everything other than `alloc` and `std`.

`compiler-builtins` is already in the crate graph via `alloc`, and all features related to `compiler-builtins` goes through `alloc`. There isn't any reason that `std` needs this direct dependency, so remove it.

Changes to `compiler-builtins` don't currently get a `T-` label, but it is mostly managed by libs. Add the autolabel here.

…e-143222, r=GuillaumeGomez rustdoc: never link to unnamable items fixes rust-lang#143222

…e, r=bjorn3,Noratrieb Simplify library dependencies on `compiler-builtins` The three panic-related library crates need to have access to `core`, and `compiler-builtins` needs to be in the crate graph. Rather than specifying both dependencies, switch these crates to use `rustc-std-workspace-core` which already does this. This means there is now a single place that the `compiler-builtins` dependency needs to get configured, for everything other than `alloc` and `std`. The second commit removes `compiler-builtins` from `std` (more details in the message).

Extend `is_case_difference` to handle digit-letter confusables This PR extends `is_case_difference` to handle digit-letter confusables Add support for detecting 0/O, 1/l, 5/S, 8/B, 9/g confusables in error suggestions. r? `@estebank`

…o-fools, r=GuillaumeGomez rustdoc-json: Move `#[macro_export]` from `Other` to it's own variant Followup to rust-lang#142936. cargo-semver-checks [cares about this attribute](https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/4a0d1b0ca19b3115bb65d0b6695c388d7f474ac9/src/visibility_tracker.rs#L459-L476), and it wasn't included in the initial PR for structured attributes CC `@obi1kenobi.` r? `@GuillaumeGomez`

… r=Noratrieb Add correct dynamic_lib_extension for aix AIX uses `.a` for static and shared libraries, this fixes a number of `run-make` tests on AIX

…r=lqd Ping Muscraft when emitter change While I am working towards `annotate-snippets` being the default emitter for `rustc`, it would be helpful if I were pinged when the default emitter is modified so that I can more easily maintain parity in output between `rustc` and `annotate-snippets`.

triagebot: Label `compiler-builtins` T-libs Changes to `compiler-builtins` don't currently get a `T-` label, but it is mostly managed by libs. Add the autolabel here.

jhpratt · 2025-08-01T04:38:33Z

@bors r+ rollup=never p=5

bors · 2025-08-01T04:38:36Z

📌 Commit 74d5b09 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-08-01T07:09:47Z

⌛ Testing commit 74d5b09 with merge e3ee7f7...

bors · 2025-08-01T10:19:00Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing e3ee7f7 to master...

rust-timer · 2025-08-01T10:21:01Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#143849	rustdoc: never link to unnamable items	`2c4a23ab94fa09e2ce03d6b7f806f1cfa7a8c2eb` (link)
#144683	Simplify library dependencies on `compiler-builtins`	`b34f9114c5a5b368e42041a3f4e0063294449ef1` (link)
#144691	Extend `is_case_difference` to handle digit-letter confusab…	`b32d325f7a1289c1a7cf982d898793c8119ee631` (link)
#144700	rustdoc-json: Move `#[macro_export]` from `Other` to it's o…	`031f2934a39e2b19fef3375324bb8c48726a8a05` (link)
#144751	Add correct dynamic_lib_extension for aix	`fc9278fa8ae795612f58aa0c968231312aba46c2` (link)
#144757	Ping Muscraft when emitter change	`78971b669392f374ddae9fc5736a5c6708eed220` (link)
#144759	triagebot: Label `compiler-builtins` T-libs	`201cdb3fb6a66f8dd6da348ce4d0605f678093f7` (link)

previous master: 6c02dd4eae

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-08-01T10:22:09Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6c02dd4 (parent) -> e3ee7f7 (this PR)

Test differences

Show 79 test diffs

Stage 1

[rustdoc-json] tests/rustdoc-json/attrs/macro_export.rs: [missing] -> pass (J0)
[rustdoc] tests/rustdoc/reexport/wrapped-unnamble-type-143222.rs: [missing] -> pass (J0)
[ui] tests/ui/suggestions/case-difference-suggestions.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/suggestions/case-difference-suggestions.rs: [missing] -> pass (J1)
[rustdoc] tests/rustdoc/reexport/wrapped-unnamble-type-143222.rs: [missing] -> pass (J2)
[rustdoc-json] tests/rustdoc-json/attrs/macro_export.rs: [missing] -> pass (J3)

Additionally, 73 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e3ee7f7aea5b45af3b42b5e4713da43876a65ac9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 4262.9s -> 7287.2s (70.9%)
dist-aarch64-apple: 5594.5s -> 7794.8s (39.3%)
dist-x86_64-apple: 9673.1s -> 7729.5s (-20.1%)
dist-x86_64-freebsd: 5728.2s -> 4886.9s (-14.7%)
dist-apple-various: 4528.8s -> 5162.6s (14.0%)
aarch64-gnu: 7135.0s -> 6626.7s (-7.1%)
dist-ohos-armv7: 3863.0s -> 4122.8s (6.7%)
x86_64-apple-1: 8791.6s -> 8253.2s (-6.1%)
pr-check-1: 1862.3s -> 1748.9s (-6.1%)
dist-x86_64-illumos: 6148.4s -> 5784.1s (-5.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-01T11:30:45Z

Finished benchmarking commit (e3ee7f7): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.7%]	12
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	0.4%	[0.2%, 0.7%]	12

Max RSS (memory usage)

Results (secondary 4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.3%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-4.2%, -4.2%]	1
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.393s -> 467.735s (0.07%)
Artifact size: 376.76 MiB -> 376.75 MiB (-0.00%)

lqd · 2025-08-01T11:39:46Z

Maybe #143849

panstromek · 2025-08-04T13:42:44Z

perf triage:

doc regression on various benchmarks.

Maybe #143849

I think so. Based on detailed results, it's in the def_kind query, and #143849 adds a callsite. Other PRs look mostly unrelated (few triagebot and config changes, confusables improvement, minor rustdoc-json change).

lolbinarycat and others added 22 commits July 22, 2025 17:11

add regression test for RUST-143222

293f95f

rustdoc: never try to link to unnamable types

4762694

fix regression test

94700f8

rustdoc: actually never link to unnamable types

f57283d

impl items are never unnamable

05a62c8

rustdoc-json: Add test for #[macro_use] attribute

1a515e6

rustdoc-json: Move #[macro_export] from Other to it's own variant

a33e084

Extend is_case_difference to handle digit-letter confusables

7b667e7

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>

add correct dynamic_lib_extension for aix

37d52ed

chore: Ping Muscraft when annnotate snippets emitter is modified

eae1d39

chore: Ping Muscraft when rustc_errors::emitter is modified

1f78738

uefi: Use slice equality rather than memcmp

8d0b92a

`compiler_builtins` shouldn't be called directly. Change the `PartialEq` implementation for `DevicePathNode` to use slice equality instead, which will call `memcmp`/`bcmp` via the intrinsic.

Remove std's dependency on compiler-builtins

42bf044

`compiler-builtins` is already in the crate graph via `alloc`, and all features related to `compiler-builtins` goes through `alloc`. There isn't any reason that `std` needs this direct dependency, so remove it.

triagebot: Label compiler-builtins T-libs

5622816

Changes to `compiler-builtins` don't currently get a `T-` label, but it is mostly managed by libs. Add the autolabel here.

Rollup merge of rust-lang#143849 - lolbinarycat:rustdoc-priv-normaliz…

e6b80f3

…e-143222, r=GuillaumeGomez rustdoc: never link to unnamable items fixes rust-lang#143222

Rollup merge of rust-lang#144751 - dalvescb:curtisd/aix_libextension,…

e11bcb6

… r=Noratrieb Add correct dynamic_lib_extension for aix AIX uses `.a` for static and shared libraries, this fixes a number of `run-make` tests on AIX

Rollup merge of rust-lang#144759 - tgross35:triagebot-label, r=lqd

74d5b09

triagebot: Label `compiler-builtins` T-libs Changes to `compiler-builtins` don't currently get a `T-` label, but it is mostly managed by libs. Add the autolabel here.

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Aug 1, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2025

bors merged commit e3ee7f7 into rust-lang:master Aug 1, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Aug 1, 2025

rustbot added the perf-regression Performance regression. label Aug 1, 2025

panstromek mentioned this pull request Aug 4, 2025

rustdoc: never link to unnamable items #143849

Merged

jhpratt deleted the rollup-otf1yfj branch August 12, 2025 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#144768

Rollup of 7 pull requests#144768
bors merged 22 commits intorust-lang:masterfrom
jhpratt:rollup-otf1yfj

jhpratt commented Aug 1, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 1, 2025

Uh oh!

lqd commented Aug 1, 2025

Uh oh!

panstromek commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

jhpratt commented Aug 1, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 1, 2025

Uh oh!

github-actions bot commented Aug 1, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 1, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

lqd commented Aug 1, 2025

Uh oh!

panstromek commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jhpratt commented Aug 1, 2025 •

edited by rustbot

Loading